[INFO] updating cached repository ickshonpe/texture-packer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ickshonpe/texture-packer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/texture-packer" "work/ex/clippy-test-run/sources/stable/gh/ickshonpe/texture-packer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ickshonpe/texture-packer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/texture-packer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/texture-packer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/texture-packer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52474cb81d5969736ecb320e495e08067abd264e [INFO] sha for GitHub repo ickshonpe/texture-packer: 52474cb81d5969736ecb320e495e08067abd264e [INFO] validating manifest of ickshonpe/texture-packer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ickshonpe/texture-packer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ickshonpe/texture-packer [INFO] finished frobbing ickshonpe/texture-packer [INFO] frobbed toml for ickshonpe/texture-packer written to work/ex/clippy-test-run/sources/stable/gh/ickshonpe/texture-packer/Cargo.toml [INFO] started frobbing ickshonpe/texture-packer [INFO] finished frobbing ickshonpe/texture-packer [INFO] frobbed toml for ickshonpe/texture-packer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/texture-packer/Cargo.toml [INFO] crate ickshonpe/texture-packer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ickshonpe/texture-packer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ickshonpe/texture-packer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e810735d143530991ce29f2a2295a1f29b63c44d391640493c0e2d7169760fc [INFO] running `"docker" "start" "-a" "0e810735d143530991ce29f2a2295a1f29b63c44d391640493c0e2d7169760fc"` [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking texture_packer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let ref mut image_output_file = File::create(&Path::new("tileset.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------- help: try: `let image_output_file = &mut File::create(&Path::new("tileset.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | let ref mut manifest_output_file = File::create(&Path::new("tileset.json")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------- help: try: `let manifest_output_file = &mut File::create(&Path::new("tileset.json")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let ref mut image_output_file = File::create(&Path::new("tileset.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------------- help: try: `let image_output_file = &mut File::create(&Path::new("tileset.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | let ref mut manifest_output_file = File::create(&Path::new("tileset.json")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------------------------- help: try: `let manifest_output_file = &mut File::create(&Path::new("tileset.json")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.70s [INFO] running `"docker" "inspect" "0e810735d143530991ce29f2a2295a1f29b63c44d391640493c0e2d7169760fc"` [INFO] running `"docker" "rm" "-f" "0e810735d143530991ce29f2a2295a1f29b63c44d391640493c0e2d7169760fc"` [INFO] [stdout] 0e810735d143530991ce29f2a2295a1f29b63c44d391640493c0e2d7169760fc