[INFO] updating cached repository ickshonpe/rust-data-structures [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ickshonpe/rust-data-structures [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/rust-data-structures" "work/ex/clippy-test-run/sources/stable/gh/ickshonpe/rust-data-structures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ickshonpe/rust-data-structures'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/rust-data-structures" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/rust-data-structures"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/rust-data-structures'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af0bf8f5e24687dad2a324e4518931fdbad50590 [INFO] sha for GitHub repo ickshonpe/rust-data-structures: af0bf8f5e24687dad2a324e4518931fdbad50590 [INFO] validating manifest of ickshonpe/rust-data-structures on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ickshonpe/rust-data-structures on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ickshonpe/rust-data-structures [INFO] finished frobbing ickshonpe/rust-data-structures [INFO] frobbed toml for ickshonpe/rust-data-structures written to work/ex/clippy-test-run/sources/stable/gh/ickshonpe/rust-data-structures/Cargo.toml [INFO] started frobbing ickshonpe/rust-data-structures [INFO] finished frobbing ickshonpe/rust-data-structures [INFO] frobbed toml for ickshonpe/rust-data-structures written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/rust-data-structures/Cargo.toml [INFO] crate ickshonpe/rust-data-structures has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ickshonpe/rust-data-structures against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ickshonpe/rust-data-structures:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44286090c9041302e1cafcde1054bd1cda89028fb2c79a1e8b03c4d5995dcefa [INFO] running `"docker" "start" "-a" "44286090c9041302e1cafcde1054bd1cda89028fb2c79a1e8b03c4d5995dcefa"` [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking data-structures v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::mem` [INFO] [stderr] --> src/list.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::mem; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `list::*` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use list::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem` [INFO] [stderr] --> src/list.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::mem; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `list::*` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use list::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `merge_sort` [INFO] [stderr] --> src/merge_sort.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn merge_sort(xs: &[T]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `merge` [INFO] [stderr] --> src/merge_sort.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn merge(mut left: &[T], mut right: &[T]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `id` [INFO] [stderr] --> src/tricks.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn id(x: T) -> T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Link` [INFO] [stderr] --> src/list.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | type Link = Option>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back` [INFO] [stderr] --> src/list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | fn back(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back_id` [INFO] [stderr] --> src/list.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn back_id(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back_tmp` [INFO] [stderr] --> src/list.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn back_tmp(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `quick_sort` [INFO] [stderr] --> src/quick_sort_slice.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn quick_sort(data: &mut [T]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `partition` [INFO] [stderr] --> src/quick_sort_slice.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | fn partition(data: &mut [T]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `example` [INFO] [stderr] --> src/quick_sort_slice.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn example() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `quick_sort` [INFO] [stderr] --> src/parallel_quick_sort.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn quick_sort(data: &mut [T]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `split_at_exclusive_mut` [INFO] [stderr] --> src/parallel_quick_sort.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn split_at_exclusive_mut(data: &mut [T], p: usize) -> (&mut [T], &mut [T]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `partition` [INFO] [stderr] --> src/parallel_quick_sort.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn partition(data: &mut [T]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `example` [INFO] [stderr] --> src/parallel_quick_sort.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn example() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `list::List` [INFO] [stderr] --> src/list.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Self { [INFO] [stderr] 34 | | List { head: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/list.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | match *cursor { [INFO] [stderr] 21 | | Some(ref node) => { [INFO] [stderr] 22 | | len += 1; [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(ref node) = *cursor { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/list.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.cursor { [INFO] [stderr] 174 | | &None => None, [INFO] [stderr] 175 | | &Some(ref node) => { [INFO] [stderr] 176 | | self.cursor = &node.next; [INFO] [stderr] 177 | | Some(&node.item) [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *self.cursor { [INFO] [stderr] 174 | None => None, [INFO] [stderr] 175 | Some(ref node) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use as_mut() instead [INFO] [stderr] --> src/list.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | cursor: match self.head { [INFO] [stderr] | _____________________^ [INFO] [stderr] 194 | | None => None, [INFO] [stderr] 195 | | Some(ref mut node) => { [INFO] [stderr] 196 | | Some(node) [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ help: try this: `self.head.as_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: function is never used: `merge_sort` [INFO] [stderr] --> src/merge_sort.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn merge_sort(xs: &[T]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `merge` [INFO] [stderr] --> src/merge_sort.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn merge(mut left: &[T], mut right: &[T]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `id` [INFO] [stderr] --> src/tricks.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn id(x: T) -> T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Link` [INFO] [stderr] --> src/list.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | type Link = Option>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back` [INFO] [stderr] --> src/list.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | fn back(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back_id` [INFO] [stderr] --> src/list.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn back_id(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `back_tmp` [INFO] [stderr] --> src/list.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fn back_tmp(&mut self) -> &mut Link { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `example` [INFO] [stderr] --> src/quick_sort_slice.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn example() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `example` [INFO] [stderr] --> src/parallel_quick_sort.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn example() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `list::List` [INFO] [stderr] --> src/list.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Self { [INFO] [stderr] 34 | | List { head: None } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/list.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | match *cursor { [INFO] [stderr] 21 | | Some(ref node) => { [INFO] [stderr] 22 | | len += 1; [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(ref node) = *cursor { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/list.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.cursor { [INFO] [stderr] 174 | | &None => None, [INFO] [stderr] 175 | | &Some(ref node) => { [INFO] [stderr] 176 | | self.cursor = &node.next; [INFO] [stderr] 177 | | Some(&node.item) [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *self.cursor { [INFO] [stderr] 174 | None => None, [INFO] [stderr] 175 | Some(ref node) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use as_mut() instead [INFO] [stderr] --> src/list.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | cursor: match self.head { [INFO] [stderr] | _____________________^ [INFO] [stderr] 194 | | None => None, [INFO] [stderr] 195 | | Some(ref mut node) => { [INFO] [stderr] 196 | | Some(node) [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ help: try this: `self.head.as_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/list.rs:244:14 [INFO] [stderr] | [INFO] [stderr] 244 | for i in (2..reps + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `(2..=reps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.16s [INFO] running `"docker" "inspect" "44286090c9041302e1cafcde1054bd1cda89028fb2c79a1e8b03c4d5995dcefa"` [INFO] running `"docker" "rm" "-f" "44286090c9041302e1cafcde1054bd1cda89028fb2c79a1e8b03c4d5995dcefa"` [INFO] [stdout] 44286090c9041302e1cafcde1054bd1cda89028fb2c79a1e8b03c4d5995dcefa