[INFO] updating cached repository ickshonpe/boulderdash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ickshonpe/boulderdash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/boulderdash" "work/ex/clippy-test-run/sources/stable/gh/ickshonpe/boulderdash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ickshonpe/boulderdash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ickshonpe/boulderdash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/boulderdash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/boulderdash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] acf612a2016eff38f82c01acb4ed520d68913a06 [INFO] sha for GitHub repo ickshonpe/boulderdash: acf612a2016eff38f82c01acb4ed520d68913a06 [INFO] validating manifest of ickshonpe/boulderdash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ickshonpe/boulderdash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ickshonpe/boulderdash [INFO] finished frobbing ickshonpe/boulderdash [INFO] frobbed toml for ickshonpe/boulderdash written to work/ex/clippy-test-run/sources/stable/gh/ickshonpe/boulderdash/Cargo.toml [INFO] started frobbing ickshonpe/boulderdash [INFO] finished frobbing ickshonpe/boulderdash [INFO] frobbed toml for ickshonpe/boulderdash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ickshonpe/boulderdash/Cargo.toml [INFO] crate ickshonpe/boulderdash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ickshonpe/boulderdash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ickshonpe/boulderdash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a4f312de4332b3b47d733679230247c17b32fa70bfb25dec49d73af233bb9de [INFO] running `"docker" "start" "-a" "9a4f312de4332b3b47d733679230247c17b32fa70bfb25dec49d73af233bb9de"` [INFO] [stderr] Checking deflate v0.7.8 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking piston-gfx_texture v0.23.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-gfx_graphics v0.39.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.36.0 [INFO] [stderr] Checking piston_window v0.65.0 [INFO] [stderr] Checking boulderdash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | LevelMap { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/game.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | let d = select_random(Direction::Left, Direction::Right); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/game.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | let n = p.to(d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | LevelMap { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:25:10 [INFO] [stderr] | [INFO] [stderr] 25 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/game.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | let d = select_random(Direction::Left, Direction::Right); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/game.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | let n = p.to(d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return self.up(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.up()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return self.down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.down()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | return self.left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return self.right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.right()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `find_folder::Error` [INFO] [stderr] --> src/assets.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use find_folder::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rect::Rect` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use rect::Rect; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `vecmath::*` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use vecmath::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::*` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use image::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `E` [INFO] [stderr] --> src/assets.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Result::Err(E) => { panic!("Assets folder not found.") } [INFO] [stderr] | ^ help: consider using `_E` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `old_input_state` [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | let mut old_input_state = HashSet::::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_old_input_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | fn draw_map(r: &RenderArgs, g2d: &mut G2d, game_state: [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/mapping.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | for (i, c) in self { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y1` [INFO] [stderr] --> src/rect.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(x1: usize, x2: usize, y1: usize, y2: usize) -> Rect { [INFO] [stderr] | ^^ help: consider using `_y1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y2` [INFO] [stderr] --> src/rect.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(x1: usize, x2: usize, y1: usize, y2: usize) -> Rect { [INFO] [stderr] | ^^ help: consider using `_y2` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | let mut old_input_state = HashSet::::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | let mut m = &mut g.map; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_map` [INFO] [stderr] --> src/mapping.rs:180:1 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn print_map(m: &LevelMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `put_border_wall` [INFO] [stderr] --> src/mapgen.rs:5:4 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn put_border_wall(map: &mut LevelMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `put_wall` [INFO] [stderr] --> src/mapgen.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn put_wall(map: &mut LevelMap, p: Pos) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | / match player_command { [INFO] [stderr] 115 | | Some(command) => { [INFO] [stderr] 116 | | let r = p.to(command); [INFO] [stderr] 117 | | match m[r].tile { [INFO] [stderr] ... | [INFO] [stderr] 146 | | None => {} [INFO] [stderr] 147 | | } [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(command) = player_command { [INFO] [stderr] 115 | let r = p.to(command); [INFO] [stderr] 116 | match m[r].tile { [INFO] [stderr] 117 | Tile::Empty | Tile::Mud => { [INFO] [stderr] 118 | m[p].tile = Tile::Empty; [INFO] [stderr] 119 | m[r].tile = Tile::Player; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapgen.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn read_map(data: &Vec<&str>) -> LevelMap { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/assets.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Result::Err(E) => { panic!("Assets folder not found.") } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | game_state.player_lives = game_state.player_lives - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_state.player_lives -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:23 [INFO] [stderr] | [INFO] [stderr] 90 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:72 [INFO] [stderr] | [INFO] [stderr] 90 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:72 [INFO] [stderr] | [INFO] [stderr] 96 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | let height = context.viewport.unwrap().window_size[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:46 [INFO] [stderr] | [INFO] [stderr] 110 | let text_context = context.trans(context.viewport.unwrap().window_size[0] as f64 - 300.0, 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:46 [INFO] [stderr] | [INFO] [stderr] 119 | let text_context = context.trans(context.viewport.unwrap().window_size[0] as f64 - 500.0, 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / let mut tile = c.tile; [INFO] [stderr] 161 | | if c.tile == Tile::Exit && !m.has_no_diamonds() { [INFO] [stderr] 162 | | tile = Tile::Wall; [INFO] [stderr] 163 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let tile = if c.tile == Tile::Exit && !m.has_no_diamonds() { Tile::Wall } else { c.tile };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return self.up(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.up()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return self.down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.down()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | return self.left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pos.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | return self.right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.right()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `find_folder::Error` [INFO] [stderr] --> src/assets.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use find_folder::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rect::Rect` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use rect::Rect; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `vecmath::*` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use vecmath::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::*` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use image::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `E` [INFO] [stderr] --> src/assets.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Result::Err(E) => { panic!("Assets folder not found.") } [INFO] [stderr] | ^ help: consider using `_E` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `old_input_state` [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | let mut old_input_state = HashSet::::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_old_input_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | fn draw_map(r: &RenderArgs, g2d: &mut G2d, game_state: [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/mapping.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | for (i, c) in self { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y1` [INFO] [stderr] --> src/rect.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(x1: usize, x2: usize, y1: usize, y2: usize) -> Rect { [INFO] [stderr] | ^^ help: consider using `_y1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y2` [INFO] [stderr] --> src/rect.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new(x1: usize, x2: usize, y1: usize, y2: usize) -> Rect { [INFO] [stderr] | ^^ help: consider using `_y2` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | let mut old_input_state = HashSet::::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | let mut m = &mut g.map; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_map` [INFO] [stderr] --> src/mapping.rs:180:1 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn print_map(m: &LevelMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `put_border_wall` [INFO] [stderr] --> src/mapgen.rs:5:4 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn put_border_wall(map: &mut LevelMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `put_wall` [INFO] [stderr] --> src/mapgen.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn put_wall(map: &mut LevelMap, p: Pos) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | / match player_command { [INFO] [stderr] 115 | | Some(command) => { [INFO] [stderr] 116 | | let r = p.to(command); [INFO] [stderr] 117 | | match m[r].tile { [INFO] [stderr] ... | [INFO] [stderr] 146 | | None => {} [INFO] [stderr] 147 | | } [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | if let Some(command) = player_command { [INFO] [stderr] 115 | let r = p.to(command); [INFO] [stderr] 116 | match m[r].tile { [INFO] [stderr] 117 | Tile::Empty | Tile::Mud => { [INFO] [stderr] 118 | m[p].tile = Tile::Empty; [INFO] [stderr] 119 | m[r].tile = Tile::Player; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapgen.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn read_map(data: &Vec<&str>) -> LevelMap { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/assets.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Result::Err(E) => { panic!("Assets folder not found.") } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | game_state.player_lives = game_state.player_lives - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_state.player_lives -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:23 [INFO] [stderr] | [INFO] [stderr] 90 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:90:72 [INFO] [stderr] | [INFO] [stderr] 90 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:72 [INFO] [stderr] | [INFO] [stderr] 96 | (context.viewport.unwrap().window_size[0] as f64, context.viewport.unwrap().window_size[1] as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | let height = context.viewport.unwrap().window_size[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:46 [INFO] [stderr] | [INFO] [stderr] 110 | let text_context = context.trans(context.viewport.unwrap().window_size[0] as f64 - 300.0, 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:46 [INFO] [stderr] | [INFO] [stderr] 119 | let text_context = context.trans(context.viewport.unwrap().window_size[0] as f64 - 500.0, 30.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(context.viewport.unwrap().window_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | / let mut tile = c.tile; [INFO] [stderr] 161 | | if c.tile == Tile::Exit && !m.has_no_diamonds() { [INFO] [stderr] 162 | | tile = Tile::Wall; [INFO] [stderr] 163 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let tile = if c.tile == Tile::Exit && !m.has_no_diamonds() { Tile::Wall } else { c.tile };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.94s [INFO] running `"docker" "inspect" "9a4f312de4332b3b47d733679230247c17b32fa70bfb25dec49d73af233bb9de"` [INFO] running `"docker" "rm" "-f" "9a4f312de4332b3b47d733679230247c17b32fa70bfb25dec49d73af233bb9de"` [INFO] [stdout] 9a4f312de4332b3b47d733679230247c17b32fa70bfb25dec49d73af233bb9de