[INFO] updating cached repository icewind1991/notify-redis [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/icewind1991/notify-redis [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/icewind1991/notify-redis" "work/ex/clippy-test-run/sources/stable/gh/icewind1991/notify-redis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/icewind1991/notify-redis'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/icewind1991/notify-redis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icewind1991/notify-redis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icewind1991/notify-redis'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77be5f9dff3e171e27acad1decf20909d114dd5a [INFO] sha for GitHub repo icewind1991/notify-redis: 77be5f9dff3e171e27acad1decf20909d114dd5a [INFO] validating manifest of icewind1991/notify-redis on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of icewind1991/notify-redis on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing icewind1991/notify-redis [INFO] finished frobbing icewind1991/notify-redis [INFO] frobbed toml for icewind1991/notify-redis written to work/ex/clippy-test-run/sources/stable/gh/icewind1991/notify-redis/Cargo.toml [INFO] started frobbing icewind1991/notify-redis [INFO] finished frobbing icewind1991/notify-redis [INFO] frobbed toml for icewind1991/notify-redis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/icewind1991/notify-redis/Cargo.toml [INFO] crate icewind1991/notify-redis has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting icewind1991/notify-redis against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/icewind1991/notify-redis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf5aedfcee6a559cc9742bcf0926b3ba21d96cc0e6180aee55be26a3db8b19b0 [INFO] running `"docker" "start" "-a" "bf5aedfcee6a559cc9742bcf0926b3ba21d96cc0e6180aee55be26a3db8b19b0"` [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking notify-redis v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return con.lpush(list, formatted_event); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `con.lpush(list, formatted_event)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:62 [INFO] [stderr] | [INFO] [stderr] 46 | fn push_event(event: DebouncedEvent, con: &Connection, list: &String) -> RedisResult<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return con.lpush(list, formatted_event); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `con.lpush(list, formatted_event)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:62 [INFO] [stderr] | [INFO] [stderr] 46 | fn push_event(event: DebouncedEvent, con: &Connection, list: &String) -> RedisResult<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.04s [INFO] running `"docker" "inspect" "bf5aedfcee6a559cc9742bcf0926b3ba21d96cc0e6180aee55be26a3db8b19b0"` [INFO] running `"docker" "rm" "-f" "bf5aedfcee6a559cc9742bcf0926b3ba21d96cc0e6180aee55be26a3db8b19b0"` [INFO] [stdout] bf5aedfcee6a559cc9742bcf0926b3ba21d96cc0e6180aee55be26a3db8b19b0