[INFO] updating cached repository ibrokemypie/psr-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ibrokemypie/psr-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ibrokemypie/psr-rust" "work/ex/clippy-test-run/sources/stable/gh/ibrokemypie/psr-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ibrokemypie/psr-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ibrokemypie/psr-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibrokemypie/psr-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibrokemypie/psr-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8b84f03ed09e39fde4f555b499e0420c4e87dc05
[INFO] sha for GitHub repo ibrokemypie/psr-rust: 8b84f03ed09e39fde4f555b499e0420c4e87dc05
[INFO] validating manifest of ibrokemypie/psr-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ibrokemypie/psr-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ibrokemypie/psr-rust
[INFO] finished frobbing ibrokemypie/psr-rust
[INFO] frobbed toml for ibrokemypie/psr-rust written to work/ex/clippy-test-run/sources/stable/gh/ibrokemypie/psr-rust/Cargo.toml
[INFO] started frobbing ibrokemypie/psr-rust
[INFO] finished frobbing ibrokemypie/psr-rust
[INFO] frobbed toml for ibrokemypie/psr-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibrokemypie/psr-rust/Cargo.toml
[INFO] crate ibrokemypie/psr-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ibrokemypie/psr-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ibrokemypie/psr-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4e4d976b983eaae1ad236b11692a9778aba5eca606afae450c02f735851ccca3
[INFO] running `"docker" "start" "-a" "4e4d976b983eaae1ad236b11692a9778aba5eca606afae450c02f735851ccca3"`
[INFO] [stderr]     Checking psr v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return choice.to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `choice.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return n;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_expr)] on by default
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("q") || c.starts_with("Q") {
[INFO] [stderr]                println!("Quit game");
[INFO] [stderr]                n = 4;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'q'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:49:50
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |                                                  ^^^ help: try using a char instead: `'Q'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("p") || c.starts_with("P") {
[INFO] [stderr]                n = 1;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:53:35
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'p'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:53:57
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'P'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:56:19
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("s") || c.starts_with("S") {
[INFO] [stderr]                n = 2;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:56:35
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:56:57
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'S'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("r") || c.starts_with("R") {
[INFO] [stderr]                n = 3;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:59:35
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'r'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:59:57
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'R'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return choice.to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `choice.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return n;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:49:12
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_expr)] on by default
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("q") || c.starts_with("Q") {
[INFO] [stderr]                println!("Quit game");
[INFO] [stderr]                n = 4;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'q'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:49:50
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if { c.starts_with("q") || c.starts_with("Q") } {
[INFO] [stderr]    |                                                  ^^^ help: try using a char instead: `'Q'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("p") || c.starts_with("P") {
[INFO] [stderr]                n = 1;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:53:35
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'p'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:53:57
[INFO] [stderr]    |
[INFO] [stderr] 53 |         } else if { c.starts_with("p") || c.starts_with("P") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'P'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:56:19
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("s") || c.starts_with("S") {
[INFO] [stderr]                n = 2;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:56:35
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:56:57
[INFO] [stderr]    |
[INFO] [stderr] 56 |         } else if { c.starts_with("s") || c.starts_with("S") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'S'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: omit braces around single expression condition
[INFO] [stderr]   --> src/main.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: try
[INFO] [stderr]            if c.starts_with("r") || c.starts_with("R") {
[INFO] [stderr]                n = 3;
[INFO] [stderr]                break;
[INFO] [stderr]            } ... 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:59:35
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'r'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:59:57
[INFO] [stderr]    |
[INFO] [stderr] 59 |         } else if { c.starts_with("r") || c.starts_with("R") } {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `'R'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.01s
[INFO] running `"docker" "inspect" "4e4d976b983eaae1ad236b11692a9778aba5eca606afae450c02f735851ccca3"`
[INFO] running `"docker" "rm" "-f" "4e4d976b983eaae1ad236b11692a9778aba5eca606afae450c02f735851ccca3"`
[INFO] [stdout] 4e4d976b983eaae1ad236b11692a9778aba5eca606afae450c02f735851ccca3