[INFO] updating cached repository ibodrov/fov [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ibodrov/fov [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ibodrov/fov" "work/ex/clippy-test-run/sources/stable/gh/ibodrov/fov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ibodrov/fov'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ibodrov/fov" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibodrov/fov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibodrov/fov'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ff183b4f0f63f708de3debc73764872dc1ddd1e [INFO] sha for GitHub repo ibodrov/fov: 4ff183b4f0f63f708de3debc73764872dc1ddd1e [INFO] validating manifest of ibodrov/fov on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ibodrov/fov on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ibodrov/fov [INFO] finished frobbing ibodrov/fov [INFO] frobbed toml for ibodrov/fov written to work/ex/clippy-test-run/sources/stable/gh/ibodrov/fov/Cargo.toml [INFO] started frobbing ibodrov/fov [INFO] finished frobbing ibodrov/fov [INFO] frobbed toml for ibodrov/fov written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ibodrov/fov/Cargo.toml [INFO] crate ibodrov/fov has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ibodrov/fov against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ibodrov/fov:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1abb355c9e13d15c735299e090b0a1a6d33469238e53a3512570247061413ec [INFO] running `"docker" "start" "-a" "c1abb355c9e13d15c735299e090b0a1a6d33469238e53a3512570247061413ec"` [INFO] [stderr] Checking fov v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | numerator: numerator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `numerator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | longest: longest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `longest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | shortest: shortest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shortest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | dx1: dx1, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dx1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | dy1: dy1, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dy1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | dx2: dx2, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dx2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | dy2: dy2, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dy2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:30 [INFO] [stderr] | [INFO] [stderr] 147 | Some(BresenhamStep { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:36 [INFO] [stderr] | [INFO] [stderr] 147 | Some(BresenhamStep { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | numerator: numerator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `numerator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | longest: longest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `longest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | shortest: shortest, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shortest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | dx1: dx1, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dx1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | dy1: dy1, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dy1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | dx2: dx2, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dx2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | dy2: dy2, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dy2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:30 [INFO] [stderr] | [INFO] [stderr] 147 | Some(BresenhamStep { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:36 [INFO] [stderr] | [INFO] [stderr] 147 | Some(BresenhamStep { x: x, y: y }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if !(longest > shortest) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `longest <= shortest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if !(longest > shortest) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `longest <= shortest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.53s [INFO] running `"docker" "inspect" "c1abb355c9e13d15c735299e090b0a1a6d33469238e53a3512570247061413ec"` [INFO] running `"docker" "rm" "-f" "c1abb355c9e13d15c735299e090b0a1a6d33469238e53a3512570247061413ec"` [INFO] [stdout] c1abb355c9e13d15c735299e090b0a1a6d33469238e53a3512570247061413ec