[INFO] updating cached repository ianwjhalliday/jsparse.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianwjhalliday/jsparse.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianwjhalliday/jsparse.rs" "work/ex/clippy-test-run/sources/stable/gh/ianwjhalliday/jsparse.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianwjhalliday/jsparse.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianwjhalliday/jsparse.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianwjhalliday/jsparse.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianwjhalliday/jsparse.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea0d6b8fcd3e5037a51f412b0967f448b88cbbed [INFO] sha for GitHub repo ianwjhalliday/jsparse.rs: ea0d6b8fcd3e5037a51f412b0967f448b88cbbed [INFO] validating manifest of ianwjhalliday/jsparse.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianwjhalliday/jsparse.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianwjhalliday/jsparse.rs [INFO] finished frobbing ianwjhalliday/jsparse.rs [INFO] frobbed toml for ianwjhalliday/jsparse.rs written to work/ex/clippy-test-run/sources/stable/gh/ianwjhalliday/jsparse.rs/Cargo.toml [INFO] started frobbing ianwjhalliday/jsparse.rs [INFO] finished frobbing ianwjhalliday/jsparse.rs [INFO] frobbed toml for ianwjhalliday/jsparse.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianwjhalliday/jsparse.rs/Cargo.toml [INFO] crate ianwjhalliday/jsparse.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianwjhalliday/jsparse.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ianwjhalliday/jsparse.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 41ab1113b0e2c55736f30d8ca6f0c99af7bfd583050f8876bf06921d22544ada [INFO] running `"docker" "start" "-a" "41ab1113b0e2c55736f30d8ca6f0c99af7bfd583050f8876bf06921d22544ada"` [INFO] [stderr] Checking jsparse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | while let Some(c) = id_chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for c in id_chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | fn parse(tokens: &Vec) -> ast::Node { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | while let Some(c) = id_chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `for c in id_chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | fn parse(tokens: &Vec) -> ast::Node { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "41ab1113b0e2c55736f30d8ca6f0c99af7bfd583050f8876bf06921d22544ada"` [INFO] running `"docker" "rm" "-f" "41ab1113b0e2c55736f30d8ca6f0c99af7bfd583050f8876bf06921d22544ada"` [INFO] [stdout] 41ab1113b0e2c55736f30d8ca6f0c99af7bfd583050f8876bf06921d22544ada