[INFO] updating cached repository ianrrees/kicad_halftone [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianrrees/kicad_halftone [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianrrees/kicad_halftone" "work/ex/clippy-test-run/sources/stable/gh/ianrrees/kicad_halftone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianrrees/kicad_halftone'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianrrees/kicad_halftone" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianrrees/kicad_halftone"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianrrees/kicad_halftone'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 35e2b63bffa6e4497f87af4deeef99cf2a217885 [INFO] sha for GitHub repo ianrrees/kicad_halftone: 35e2b63bffa6e4497f87af4deeef99cf2a217885 [INFO] validating manifest of ianrrees/kicad_halftone on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianrrees/kicad_halftone on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianrrees/kicad_halftone [INFO] finished frobbing ianrrees/kicad_halftone [INFO] frobbed toml for ianrrees/kicad_halftone written to work/ex/clippy-test-run/sources/stable/gh/ianrrees/kicad_halftone/Cargo.toml [INFO] started frobbing ianrrees/kicad_halftone [INFO] finished frobbing ianrrees/kicad_halftone [INFO] frobbed toml for ianrrees/kicad_halftone written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianrrees/kicad_halftone/Cargo.toml [INFO] crate ianrrees/kicad_halftone has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianrrees/kicad_halftone against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ianrrees/kicad_halftone:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 168d9632acedf49b8c7ba1a2bc5bdac7ef5963ea358f06fb3c54b1e33d65e8f4 [INFO] running `"docker" "start" "-a" "168d9632acedf49b8c7ba1a2bc5bdac7ef5963ea358f06fb3c54b1e33d65e8f4"` [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking kicad_halftone v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(e.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | / return Ok(ProgramSettings::Cli{ [INFO] [stderr] 183 | | source_image, [INFO] [stderr] 184 | | output_path, [INFO] [stderr] 185 | | params [INFO] [stderr] 186 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | Ok(ProgramSettings::Cli{ [INFO] [stderr] 183 | source_image, [INFO] [stderr] 184 | output_path, [INFO] [stderr] 185 | params [INFO] [stderr] 186 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(e.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | / return Ok(ProgramSettings::Cli{ [INFO] [stderr] 183 | | source_image, [INFO] [stderr] 184 | | output_path, [INFO] [stderr] 185 | | params [INFO] [stderr] 186 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | Ok(ProgramSettings::Cli{ [INFO] [stderr] 183 | source_image, [INFO] [stderr] 184 | output_path, [INFO] [stderr] 185 | params [INFO] [stderr] 186 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | out.write(s.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/kicad_mod/mod.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn write(shapes: &Vec, out: &mut Write) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Shape]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | out.write(b"(module test (layer F.Cu) (tedit 5BDB7444)\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | out.write(b")\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:284:30 [INFO] [stderr] | [INFO] [stderr] 284 | score += px as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(px)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:285:34 [INFO] [stderr] | [INFO] [stderr] 285 | max_score += u8::max_value() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kicad_halftone`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | out.write(s.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/kicad_mod/mod.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn write(shapes: &Vec, out: &mut Write) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Shape]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | out.write(b"(module test (layer F.Cu) (tedit 5BDB7444)\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/kicad_mod/mod.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | out.write(b")\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:284:30 [INFO] [stderr] | [INFO] [stderr] 284 | score += px as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(px)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:285:34 [INFO] [stderr] | [INFO] [stderr] 285 | max_score += u8::max_value() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `kicad_halftone`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "168d9632acedf49b8c7ba1a2bc5bdac7ef5963ea358f06fb3c54b1e33d65e8f4"` [INFO] running `"docker" "rm" "-f" "168d9632acedf49b8c7ba1a2bc5bdac7ef5963ea358f06fb3c54b1e33d65e8f4"` [INFO] [stdout] 168d9632acedf49b8c7ba1a2bc5bdac7ef5963ea358f06fb3c54b1e33d65e8f4