[INFO] updating cached repository ianprime0509/rsudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianprime0509/rsudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianprime0509/rsudoku" "work/ex/clippy-test-run/sources/stable/gh/ianprime0509/rsudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianprime0509/rsudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianprime0509/rsudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/rsudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/rsudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 705536f0546f8f62d2ea311c6d7730ba4582e010 [INFO] sha for GitHub repo ianprime0509/rsudoku: 705536f0546f8f62d2ea311c6d7730ba4582e010 [INFO] validating manifest of ianprime0509/rsudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianprime0509/rsudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianprime0509/rsudoku [INFO] finished frobbing ianprime0509/rsudoku [INFO] frobbed toml for ianprime0509/rsudoku written to work/ex/clippy-test-run/sources/stable/gh/ianprime0509/rsudoku/Cargo.toml [INFO] started frobbing ianprime0509/rsudoku [INFO] finished frobbing ianprime0509/rsudoku [INFO] frobbed toml for ianprime0509/rsudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/rsudoku/Cargo.toml [INFO] crate ianprime0509/rsudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianprime0509/rsudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ianprime0509/rsudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4af125c5a5db0fbaf9d3ac8f45e7bb526f6ccec935d4437530c08ee0d4ae5ccb [INFO] running `"docker" "start" "-a" "4af125c5a5db0fbaf9d3ac8f45e7bb526f6ccec935d4437530c08ee0d4ae5ccb"` [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking backtrace-sys v0.1.12 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking itertools v0.6.2 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking chan-signal v0.3.1 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking rsudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/sudoku.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | write!(f, "+---+---+---+\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/sudoku.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tui.rs:570:13 [INFO] [stderr] | [INFO] [stderr] 570 | "(press any key to close help)" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/sudoku.rs:350:13 [INFO] [stderr] | [INFO] [stderr] 350 | write!(f, "+---+---+---+\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/sudoku.rs:366:17 [INFO] [stderr] | [INFO] [stderr] 366 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tui.rs:570:13 [INFO] [stderr] | [INFO] [stderr] 570 | "(press any key to close help)" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tui.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | / match signal.unwrap() { [INFO] [stderr] 197 | | Signal::WINCH => { [INFO] [stderr] 198 | | write!(self.stdout, "{}", clear::All).unwrap(); [INFO] [stderr] 199 | | self.draw_all(); [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 196 | if let Signal::WINCH = signal.unwrap() { [INFO] [stderr] 197 | write!(self.stdout, "{}", clear::All).unwrap(); [INFO] [stderr] 198 | self.draw_all(); [INFO] [stderr] 199 | self.stdout.flush().unwrap(); [INFO] [stderr] 200 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tui.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | / match signal.unwrap() { [INFO] [stderr] 197 | | Signal::WINCH => { [INFO] [stderr] 198 | | write!(self.stdout, "{}", clear::All).unwrap(); [INFO] [stderr] 199 | | self.draw_all(); [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => {} [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 196 | if let Signal::WINCH = signal.unwrap() { [INFO] [stderr] 197 | write!(self.stdout, "{}", clear::All).unwrap(); [INFO] [stderr] 198 | self.draw_all(); [INFO] [stderr] 199 | self.stdout.flush().unwrap(); [INFO] [stderr] 200 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tui.rs:437:42 [INFO] [stderr] | [INFO] [stderr] 437 | char::from_digit(n as u32, 10).unwrap(), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tui.rs:512:46 [INFO] [stderr] | [INFO] [stderr] 512 | let c = char::from_digit(self.game.board()[i][j] as u32, 10).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.game.board()[i][j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tui.rs:437:42 [INFO] [stderr] | [INFO] [stderr] 437 | char::from_digit(n as u32, 10).unwrap(), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tui.rs:512:46 [INFO] [stderr] | [INFO] [stderr] 512 | let c = char::from_digit(self.game.board()[i][j] as u32, 10).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.game.board()[i][j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.10s [INFO] running `"docker" "inspect" "4af125c5a5db0fbaf9d3ac8f45e7bb526f6ccec935d4437530c08ee0d4ae5ccb"` [INFO] running `"docker" "rm" "-f" "4af125c5a5db0fbaf9d3ac8f45e7bb526f6ccec935d4437530c08ee0d4ae5ccb"` [INFO] [stdout] 4af125c5a5db0fbaf9d3ac8f45e7bb526f6ccec935d4437530c08ee0d4ae5ccb