[INFO] updating cached repository ianprime0509/euler-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianprime0509/euler-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianprime0509/euler-rs" "work/ex/clippy-test-run/sources/stable/gh/ianprime0509/euler-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianprime0509/euler-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianprime0509/euler-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/euler-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/euler-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 30a6ea3e2e929ea2ed054e12283e13a8d878fbf0 [INFO] sha for GitHub repo ianprime0509/euler-rs: 30a6ea3e2e929ea2ed054e12283e13a8d878fbf0 [INFO] validating manifest of ianprime0509/euler-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianprime0509/euler-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianprime0509/euler-rs [INFO] finished frobbing ianprime0509/euler-rs [INFO] frobbed toml for ianprime0509/euler-rs written to work/ex/clippy-test-run/sources/stable/gh/ianprime0509/euler-rs/Cargo.toml [INFO] started frobbing ianprime0509/euler-rs [INFO] finished frobbing ianprime0509/euler-rs [INFO] frobbed toml for ianprime0509/euler-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianprime0509/euler-rs/Cargo.toml [INFO] crate ianprime0509/euler-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianprime0509/euler-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ianprime0509/euler-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a50ca5f4028bc38c4792ec009b203969565b597ff1e4257c1940420c8b01b605 [INFO] running `"docker" "start" "-a" "a50ca5f4028bc38c4792ec009b203969565b597ff1e4257c1940420c8b01b605"` [INFO] [stderr] Checking rustc-serialize v0.3.20 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/primes.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | prime_bits: prime_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prime_bits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/primes.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | primes: primes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `primes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/primes.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | prime_bits: prime_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prime_bits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/primes.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | primes: primes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `primes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p000.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | let sieve = Sieve::sieve_to(100000u32); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p000.rs:14:52 [INFO] [stderr] | [INFO] [stderr] 14 | ((end - start) as f64) / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p002.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | while f1 < 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p003.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let mut n = 600851475143u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `600_851_475_143u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p008.rs:3:16 [INFO] [stderr] | [INFO] [stderr] 3 | const NUMBER: &'static str = "73167176531330624919225119674426574742355349194934 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p010.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | let sieve = Sieve::sieve_to(2000000u64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p011.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | const GRID: &'static str = "08 02 22 97 38 15 00 40 00 75 04 05 07 78 52 12 50 77 91 08 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p013.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | const NUMS: &'static str = "37107287533902102798797998220837590246510135740250 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p018.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | const TRI: &'static str = "75 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p022.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const NAMES: &'static str = include_str!("resources/p022.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p034.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for n in 10..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p034.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | 9 => 362880, [INFO] [stderr] | ^^^^^^ help: consider: `362_880` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p000.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | let sieve = Sieve::sieve_to(100000u32); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p000.rs:14:52 [INFO] [stderr] | [INFO] [stderr] 14 | ((end - start) as f64) / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p002.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | while f1 < 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p003.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let mut n = 600851475143u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `600_851_475_143u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p008.rs:3:16 [INFO] [stderr] | [INFO] [stderr] 3 | const NUMBER: &'static str = "73167176531330624919225119674426574742355349194934 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p010.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | let sieve = Sieve::sieve_to(2000000u64); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p011.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | const GRID: &'static str = "08 02 22 97 38 15 00 40 00 75 04 05 07 78 52 12 50 77 91 08 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p013.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | const NUMS: &'static str = "37107287533902102798797998220837590246510135740250 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p018.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | const TRI: &'static str = "75 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/solutions/p022.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const NAMES: &'static str = include_str!("resources/p022.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p034.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for n in 10..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solutions/p034.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | 9 => 362880, [INFO] [stderr] | ^^^^^^ help: consider: `362_880` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `answer` [INFO] [stderr] --> src/solutions/mod.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn answer(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lcm` [INFO] [stderr] --> src/math/numeric.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn lcm(n: &T, m: &T) -> T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p001.rs:6:69 [INFO] [stderr] | [INFO] [stderr] 6 | .filter(|x| x % 3 == 0 || x % 5 == 0) [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 7 | | .fold(0, |acc, x| acc + x))) [INFO] [stderr] | |_________________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `digits`. [INFO] [stderr] --> src/solutions/p008.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for j in i..(i + prod_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in digits.iter().skip(i).take(prod_len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/solutions/p008.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | prod *= digits[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(digits[j])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p010.rs:7:36 [INFO] [stderr] | [INFO] [stderr] 7 | let sum = sieve.primes().iter().fold(0, |acc, p| acc + p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `grid`. [INFO] [stderr] --> src/solutions/p011.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | for k in i..(i + 4) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in grid.iter().skip(i).take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/solutions/p013.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | Solution::new(&format!("{}", &sum.to_string()[..10])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&sum.to_string()[..10].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/solutions/p020.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | while &m <= n { [INFO] [stderr] | --^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `names` [INFO] [stderr] --> src/solutions/p022.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | for i in 0..names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 13 | for (i, ) in names.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/solutions/p022.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | s.bytes().fold(0, |acc, b| acc + (b - b'A' + 1) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(b - b'A' + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/solutions/p023.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(_) = abundant.binary_search(&(n - a)) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 23 | | // n - a is abundant, so n is the sum of two abundant numbers [INFO] [stderr] 24 | | continue 'outer; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________- help: try this: `if abundant.binary_search(&(n - a)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/solutions/p024.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | Solution::new(&format!("{}", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `result.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/solutions/p028.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | for k in 1..((SPIRAL_SIZE - 1) / 2 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=(SPIRAL_SIZE - 1) / 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p032.rs:75:47 [INFO] [stderr] | [INFO] [stderr] 75 | let answer = format!("{}", products.iter().fold(0, |acc, x| acc + x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prime_bits` [INFO] [stderr] --> src/math/primes.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..prime_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (i, ) in prime_bits.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lcm` [INFO] [stderr] --> src/math/numeric.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn lcm(n: &T, m: &T) -> T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p001.rs:6:69 [INFO] [stderr] | [INFO] [stderr] 6 | .filter(|x| x % 3 == 0 || x % 5 == 0) [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 7 | | .fold(0, |acc, x| acc + x))) [INFO] [stderr] | |_________________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `digits`. [INFO] [stderr] --> src/solutions/p008.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for j in i..(i + prod_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in digits.iter().skip(i).take(prod_len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/solutions/p008.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | prod *= digits[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(digits[j])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p010.rs:7:36 [INFO] [stderr] | [INFO] [stderr] 7 | let sum = sieve.primes().iter().fold(0, |acc, p| acc + p); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `grid`. [INFO] [stderr] --> src/solutions/p011.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | for k in i..(i + 4) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in grid.iter().skip(i).take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/solutions/p013.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | Solution::new(&format!("{}", &sum.to_string()[..10])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&sum.to_string()[..10].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/solutions/p020.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | while &m <= n { [INFO] [stderr] | --^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `names` [INFO] [stderr] --> src/solutions/p022.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | for i in 0..names.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 13 | for (i, ) in names.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/solutions/p022.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | s.bytes().fold(0, |acc, b| acc + (b - b'A' + 1) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(b - b'A' + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/solutions/p023.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if let Ok(_) = abundant.binary_search(&(n - a)) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 23 | | // n - a is abundant, so n is the sum of two abundant numbers [INFO] [stderr] 24 | | continue 'outer; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________- help: try this: `if abundant.binary_search(&(n - a)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/solutions/p024.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | Solution::new(&format!("{}", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `result.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/solutions/p028.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | for k in 1..((SPIRAL_SIZE - 1) / 2 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=(SPIRAL_SIZE - 1) / 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/solutions/p032.rs:75:47 [INFO] [stderr] | [INFO] [stderr] 75 | let answer = format!("{}", products.iter().fold(0, |acc, x| acc + x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prime_bits` [INFO] [stderr] --> src/math/primes.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..prime_bits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (i, ) in prime_bits.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.31s [INFO] running `"docker" "inspect" "a50ca5f4028bc38c4792ec009b203969565b597ff1e4257c1940420c8b01b605"` [INFO] running `"docker" "rm" "-f" "a50ca5f4028bc38c4792ec009b203969565b597ff1e4257c1940420c8b01b605"` [INFO] [stdout] a50ca5f4028bc38c4792ec009b203969565b597ff1e4257c1940420c8b01b605