[INFO] updating cached repository ianks/fast_woothee [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ianks/fast_woothee [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ianks/fast_woothee" "work/ex/clippy-test-run/sources/stable/gh/ianks/fast_woothee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ianks/fast_woothee'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ianks/fast_woothee" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianks/fast_woothee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianks/fast_woothee'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 681d9c32fb2962bb8fb082af2dd52e92c5f7d966 [INFO] sha for GitHub repo ianks/fast_woothee: 681d9c32fb2962bb8fb082af2dd52e92c5f7d966 [INFO] validating manifest of ianks/fast_woothee on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ianks/fast_woothee on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ianks/fast_woothee [INFO] finished frobbing ianks/fast_woothee [INFO] frobbed toml for ianks/fast_woothee written to work/ex/clippy-test-run/sources/stable/gh/ianks/fast_woothee/Cargo.toml [INFO] started frobbing ianks/fast_woothee [INFO] finished frobbing ianks/fast_woothee [INFO] frobbed toml for ianks/fast_woothee written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ianks/fast_woothee/Cargo.toml [INFO] crate ianks/fast_woothee has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ianks/fast_woothee against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ianks/fast_woothee:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 72275112a1d175b4fb4f12b4739c41ce2fbc2689996a763ab924fdcef97a1a61 [INFO] running `"docker" "start" "-a" "72275112a1d175b4fb4f12b4739c41ce2fbc2689996a763ab924fdcef97a1a61"` [INFO] [stderr] Compiling ruby-sys v0.2.20 [INFO] [stderr] Compiling woothee v0.7.3 [INFO] [stderr] Checking ruru v0.9.3 [INFO] [stderr] Checking fast_woothee v1.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | match parser.parse(ua_string.unwrap_or(RString::new("")).to_str()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:38:52 [INFO] [stderr] | [INFO] [stderr] 38 | Boolean::new(woothee::is_crawler(ua_string.unwrap_or(RString::new("")).to_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | match parser.parse(ua_string.unwrap_or(RString::new("")).to_str()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:38:52 [INFO] [stderr] | [INFO] [stderr] 38 | Boolean::new(woothee::is_crawler(ua_string.unwrap_or(RString::new("")).to_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.17s [INFO] running `"docker" "inspect" "72275112a1d175b4fb4f12b4739c41ce2fbc2689996a763ab924fdcef97a1a61"` [INFO] running `"docker" "rm" "-f" "72275112a1d175b4fb4f12b4739c41ce2fbc2689996a763ab924fdcef97a1a61"` [INFO] [stdout] 72275112a1d175b4fb4f12b4739c41ce2fbc2689996a763ab924fdcef97a1a61