[INFO] updating cached repository iThinkyouknow/pong
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/iThinkyouknow/pong
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/iThinkyouknow/pong" "work/ex/clippy-test-run/sources/stable/gh/iThinkyouknow/pong"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iThinkyouknow/pong'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/iThinkyouknow/pong" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iThinkyouknow/pong"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iThinkyouknow/pong'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d8dc5163077fd5141bba352984cd35c1b339ed9f
[INFO] sha for GitHub repo iThinkyouknow/pong: d8dc5163077fd5141bba352984cd35c1b339ed9f
[INFO] validating manifest of iThinkyouknow/pong on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of iThinkyouknow/pong on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing iThinkyouknow/pong
[INFO] finished frobbing iThinkyouknow/pong
[INFO] frobbed toml for iThinkyouknow/pong written to work/ex/clippy-test-run/sources/stable/gh/iThinkyouknow/pong/Cargo.toml
[INFO] started frobbing iThinkyouknow/pong
[INFO] finished frobbing iThinkyouknow/pong
[INFO] frobbed toml for iThinkyouknow/pong written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iThinkyouknow/pong/Cargo.toml
[INFO] crate iThinkyouknow/pong has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting iThinkyouknow/pong against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iThinkyouknow/pong:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 06a298d43d8c9dca8e54a4e51b5e6d129325fbb1bd36c47a8554413533159bfc
[INFO] running `"docker" "start" "-a" "06a298d43d8c9dca8e54a4e51b5e6d129325fbb1bd36c47a8554413533159bfc"`
[INFO] [stderr]    Compiling x11-dl v2.18.0
[INFO] [stderr]     Checking inflate v0.3.4
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking piston2d-graphics v0.24.0
[INFO] [stderr]    Compiling gl v0.7.0
[INFO] [stderr]    Compiling glutin v0.10.1
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking wayland-window v0.8.0
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking rayon v1.0.2
[INFO] [stderr]     Checking pistoncore-window v0.30.0
[INFO] [stderr]     Checking winit v0.8.3
[INFO] [stderr]     Checking pistoncore-event_loop v0.35.0
[INFO] [stderr]     Checking piston v0.35.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.43.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.50.0
[INFO] [stderr]     Checking pong v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:36:24
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let left_pos = self.left_pos as f64;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:38:25
[INFO] [stderr]    |
[INFO] [stderr] 38 |         let right_pos = self.right_pos as f64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:41:22
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let ball_x = self.ball_x as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let ball_y = self.ball_y as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:51:35
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 c.transform.trans(args.width as f64 - 10.0, right_pos),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn update(&mut self, _args: &UpdateArgs) {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 108 | |             match key {
[INFO] [stderr] 109 | |                 Key::Up => {
[INFO] [stderr] 110 | |                     self.right_vel = -1;
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |             }
[INFO] [stderr] 123 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 107 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 128 | |             match key {
[INFO] [stderr] 129 | |                 Key::Up => {
[INFO] [stderr] 130 | |                     self.right_vel = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 143 | |             }
[INFO] [stderr] 144 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:36:24
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let left_pos = self.left_pos as f64;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:38:25
[INFO] [stderr]    |
[INFO] [stderr] 38 |         let right_pos = self.right_pos as f64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:41:22
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let ball_x = self.ball_x as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let ball_y = self.ball_y as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:51:35
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 c.transform.trans(args.width as f64 - 10.0, right_pos),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |     fn update(&mut self, _args: &UpdateArgs) {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 108 | |             match key {
[INFO] [stderr] 109 | |                 Key::Up => {
[INFO] [stderr] 110 | |                     self.right_vel = -1;
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |             }
[INFO] [stderr] 123 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 107 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 | /         if let &Button::Keyboard(key) = args {
[INFO] [stderr] 128 | |             match key {
[INFO] [stderr] 129 | |                 Key::Up => {
[INFO] [stderr] 130 | |                     self.right_vel = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 143 | |             }
[INFO] [stderr] 144 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if let Button::Keyboard(key) = *args {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 44.01s
[INFO] running `"docker" "inspect" "06a298d43d8c9dca8e54a4e51b5e6d129325fbb1bd36c47a8554413533159bfc"`
[INFO] running `"docker" "rm" "-f" "06a298d43d8c9dca8e54a4e51b5e6d129325fbb1bd36c47a8554413533159bfc"`
[INFO] [stdout] 06a298d43d8c9dca8e54a4e51b5e6d129325fbb1bd36c47a8554413533159bfc