[INFO] updating cached repository iH8c0ff33/rust-trie [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iH8c0ff33/rust-trie [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iH8c0ff33/rust-trie" "work/ex/clippy-test-run/sources/stable/gh/iH8c0ff33/rust-trie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iH8c0ff33/rust-trie'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iH8c0ff33/rust-trie" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iH8c0ff33/rust-trie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iH8c0ff33/rust-trie'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea4770e936a4be7fef9b0454dec45e6e4c804d4d [INFO] sha for GitHub repo iH8c0ff33/rust-trie: ea4770e936a4be7fef9b0454dec45e6e4c804d4d [INFO] validating manifest of iH8c0ff33/rust-trie on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iH8c0ff33/rust-trie on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iH8c0ff33/rust-trie [INFO] finished frobbing iH8c0ff33/rust-trie [INFO] frobbed toml for iH8c0ff33/rust-trie written to work/ex/clippy-test-run/sources/stable/gh/iH8c0ff33/rust-trie/Cargo.toml [INFO] started frobbing iH8c0ff33/rust-trie [INFO] finished frobbing iH8c0ff33/rust-trie [INFO] frobbed toml for iH8c0ff33/rust-trie written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iH8c0ff33/rust-trie/Cargo.toml [INFO] crate iH8c0ff33/rust-trie has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iH8c0ff33/rust-trie against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iH8c0ff33/rust-trie:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0197314f7115ddadc2c4967b5675807c58e0783277ef7ac5088303c14aa4fc71 [INFO] running `"docker" "start" "-a" "0197314f7115ddadc2c4967b5675807c58e0783277ef7ac5088303c14aa4fc71"` [INFO] [stderr] Checking trie v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/trie_traversal.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 28 | | if let Some(position) = self [INFO] [stderr] 29 | | .children [INFO] [stderr] 30 | | .iter_mut() [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if let Some(position) = self [INFO] [stderr] 28 | .children [INFO] [stderr] 29 | .iter_mut() [INFO] [stderr] 30 | .position(|child| child.key == tail[0]) [INFO] [stderr] 31 | { [INFO] [stderr] 32 | self.children[position].insert(tail.to_vec()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_node.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | boundary: tail.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_node.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | children: if tail.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_traversal.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if tail.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/trie_traversal.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn $name<'a>(trie: $trie_type, prefix: Vec) -> Option<$trie_type> { [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 74 | get_fn!(name: trie_get, trie_type: &Trie, iter_fn: iter); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/trie_traversal.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn $name<'a>(trie: $trie_type, prefix: Vec) -> Option<$trie_type> { [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 75 | get_fn!(name: trie_get_mut, trie_type: &mut Trie, iter_fn: iter_mut); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_traversal.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if parent.children[pos].children.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parent.children[pos].children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_iter.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.acc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/trie_traversal.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 28 | | if let Some(position) = self [INFO] [stderr] 29 | | .children [INFO] [stderr] 30 | | .iter_mut() [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if let Some(position) = self [INFO] [stderr] 28 | .children [INFO] [stderr] 29 | .iter_mut() [INFO] [stderr] 30 | .position(|child| child.key == tail[0]) [INFO] [stderr] 31 | { [INFO] [stderr] 32 | self.children[position].insert(tail.to_vec()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_node.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | boundary: tail.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_node.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | children: if tail.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_traversal.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | if tail.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tail.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/trie_traversal.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn $name<'a>(trie: $trie_type, prefix: Vec) -> Option<$trie_type> { [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 74 | get_fn!(name: trie_get, trie_type: &Trie, iter_fn: iter); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/trie_traversal.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | fn $name<'a>(trie: $trie_type, prefix: Vec) -> Option<$trie_type> { [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 75 | get_fn!(name: trie_get_mut, trie_type: &mut Trie, iter_fn: iter_mut); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_traversal.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if parent.children[pos].children.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parent.children[pos].children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trie_iter.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if self.acc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.07s [INFO] running `"docker" "inspect" "0197314f7115ddadc2c4967b5675807c58e0783277ef7ac5088303c14aa4fc71"` [INFO] running `"docker" "rm" "-f" "0197314f7115ddadc2c4967b5675807c58e0783277ef7ac5088303c14aa4fc71"` [INFO] [stdout] 0197314f7115ddadc2c4967b5675807c58e0783277ef7ac5088303c14aa4fc71