[INFO] updating cached repository iBelieve/orgmode-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/iBelieve/orgmode-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/iBelieve/orgmode-rs" "work/ex/clippy-test-run/sources/stable/gh/iBelieve/orgmode-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iBelieve/orgmode-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/iBelieve/orgmode-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iBelieve/orgmode-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iBelieve/orgmode-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6a29ae3036138f445772a6652069fcf23bee50f9
[INFO] sha for GitHub repo iBelieve/orgmode-rs: 6a29ae3036138f445772a6652069fcf23bee50f9
[INFO] validating manifest of iBelieve/orgmode-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of iBelieve/orgmode-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing iBelieve/orgmode-rs
[INFO] finished frobbing iBelieve/orgmode-rs
[INFO] frobbed toml for iBelieve/orgmode-rs written to work/ex/clippy-test-run/sources/stable/gh/iBelieve/orgmode-rs/Cargo.toml
[INFO] started frobbing iBelieve/orgmode-rs
[INFO] finished frobbing iBelieve/orgmode-rs
[INFO] frobbed toml for iBelieve/orgmode-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iBelieve/orgmode-rs/Cargo.toml
[INFO] crate iBelieve/orgmode-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting iBelieve/orgmode-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iBelieve/orgmode-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2dceb77c2eecd3527c20f229b233a3cd465f54958bea95225c194154b60f1547
[INFO] running `"docker" "start" "-a" "2dceb77c2eecd3527c20f229b233a3cd465f54958bea95225c194154b60f1547"`
[INFO] [stderr]    Compiling syn v0.15.15
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]     Checking orgmode v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/document.rs:312:13
[INFO] [stderr]     |
[INFO] [stderr] 312 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/list.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 write!(f, "\n")?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/document.rs:312:13
[INFO] [stderr]     |
[INFO] [stderr] 312 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/list.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |                 write!(f, "\n")?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/list.rs:236:20
[INFO] [stderr]     |
[INFO] [stderr] 236 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 237 | |                 if bullet[..bullet.len() - 1].chars().all(|c| c.is_numeric()) {
[INFO] [stderr] 238 | |                     ListKind::OrderedNumber
[INFO] [stderr] 239 | |                 } else {
[INFO] [stderr] 240 | |                     ListKind::OrderedLetter
[INFO] [stderr] 241 | |                 }
[INFO] [stderr] 242 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 236 |             } else if bullet[..bullet.len() - 1].chars().all(|c| c.is_numeric()) {
[INFO] [stderr] 237 |     ListKind::OrderedNumber
[INFO] [stderr] 238 | } else {
[INFO] [stderr] 239 |     ListKind::OrderedLetter
[INFO] [stderr] 240 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/list.rs:236:20
[INFO] [stderr]     |
[INFO] [stderr] 236 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 237 | |                 if bullet[..bullet.len() - 1].chars().all(|c| c.is_numeric()) {
[INFO] [stderr] 238 | |                     ListKind::OrderedNumber
[INFO] [stderr] 239 | |                 } else {
[INFO] [stderr] 240 | |                     ListKind::OrderedLetter
[INFO] [stderr] 241 | |                 }
[INFO] [stderr] 242 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 236 |             } else if bullet[..bullet.len() - 1].chars().all(|c| c.is_numeric()) {
[INFO] [stderr] 237 |     ListKind::OrderedNumber
[INFO] [stderr] 238 | } else {
[INFO] [stderr] 239 |     ListKind::OrderedLetter
[INFO] [stderr] 240 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/parser.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn next(&mut self) -> Option<String> {
[INFO] [stderr] 36 | |         match self.lines.next() {
[INFO] [stderr] 37 | |             Some(Ok(line)) => {
[INFO] [stderr] 38 | |                 self.current_line += 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/parser.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn next(&mut self) -> Option<String> {
[INFO] [stderr] 36 | |         match self.lines.next() {
[INFO] [stderr] 37 | |             Some(Ok(line)) => {
[INFO] [stderr] 38 | |                 self.current_line += 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/agenda.rs:27:56
[INFO] [stderr]    |
[INFO] [stderr] 27 |             AgendaRange::Week => date - Duration::days(date.weekday().number_from_monday() as i64 - 1)
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.weekday().number_from_monday())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/agenda.rs:27:56
[INFO] [stderr]    |
[INFO] [stderr] 27 |             AgendaRange::Week => date - Duration::days(date.weekday().number_from_monday() as i64 - 1)
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(date.weekday().number_from_monday())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/agenda.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             let date = self.start_date.clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start_date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/agenda.rs:70:24
[INFO] [stderr]    |
[INFO] [stderr] 70 |             let date = self.start_date.clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.start_date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:145:32
[INFO] [stderr]     |
[INFO] [stderr] 145 |         self.tree.child_ids(id.unwrap_or(self.tree.root_id()))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:149:31
[INFO] [stderr]     |
[INFO] [stderr] 149 |         self.tree.children(id.unwrap_or(self.tree.root_id()))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:194:14
[INFO] [stderr]     |
[INFO] [stderr] 194 |             .unwrap_or(self.tree.root_id());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/document.rs:221:15
[INFO] [stderr]     |
[INFO] [stderr] 221 |         date: &'a Date,
[INFO] [stderr]     |               ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:145:32
[INFO] [stderr]     |
[INFO] [stderr] 145 |         self.tree.child_ids(id.unwrap_or(self.tree.root_id()))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:149:31
[INFO] [stderr]     |
[INFO] [stderr] 149 |         self.tree.children(id.unwrap_or(self.tree.root_id()))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/document.rs:194:14
[INFO] [stderr]     |
[INFO] [stderr] 194 |             .unwrap_or(self.tree.root_id());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.tree.root_id())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/document.rs:221:15
[INFO] [stderr]     |
[INFO] [stderr] 221 |         date: &'a Date,
[INFO] [stderr]     |               ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `library::Library`
[INFO] [stderr]   --> src/library.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Self {
[INFO] [stderr] 22 | |         Library {
[INFO] [stderr] 23 | |             next_id: 0,
[INFO] [stderr] 24 | |             documents: HashMap::new()
[INFO] [stderr] 25 | |         }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/headline.rs:187:35
[INFO] [stderr]     |
[INFO] [stderr] 187 |         for headline in headlines.into_iter() {
[INFO] [stderr]     |                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `library::Library`
[INFO] [stderr]   --> src/library.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Self {
[INFO] [stderr] 22 | |         Library {
[INFO] [stderr] 23 | |             next_id: 0,
[INFO] [stderr] 24 | |             documents: HashMap::new()
[INFO] [stderr] 25 | |         }
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/list.rs:274:12
[INFO] [stderr]     |
[INFO] [stderr] 274 |         if self.elements.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.elements.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/node.rs:95:38
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/node.rs:101:15
[INFO] [stderr]     |
[INFO] [stderr] 101 |         date: &'a Date,
[INFO] [stderr]     |               ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/list.rs:274:12
[INFO] [stderr]     |
[INFO] [stderr] 274 |         if self.elements.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.elements.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/node.rs:95:38
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/node.rs:101:15
[INFO] [stderr]     |
[INFO] [stderr] 101 |         date: &'a Date,
[INFO] [stderr]     |               ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/section.rs:43:38
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/section.rs:47:52
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn timestamps_for_date<'a>(&'a self, date: &'a Date) -> impl Iterator<Item=Timestamp> + 'a {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/section.rs:43:38
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/section.rs:47:52
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn timestamps_for_date<'a>(&'a self, date: &'a Date) -> impl Iterator<Item=Timestamp> + 'a {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/table.rs:105:36
[INFO] [stderr]     |
[INFO] [stderr] 105 |         } else if line.starts_with("|") {
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/table.rs:105:36
[INFO] [stderr]     |
[INFO] [stderr] 105 |         } else if line.starts_with("|") {
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/text.rs:50:27
[INFO] [stderr]    |
[INFO] [stderr] 50 |             + &text.split("\n").join(&line_prefix)
[INFO] [stderr]    |                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/text.rs:50:27
[INFO] [stderr]    |
[INFO] [stderr] 50 |             + &text.split("\n").join(&line_prefix)
[INFO] [stderr]    |                           ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/timestamp.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             other >= &self.date && other <= end_date
[INFO] [stderr]    |             ^^^^^^^^^----------
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: use the right value directly: `self.date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/timestamp.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             other >= &self.date && other <= end_date
[INFO] [stderr]    |             ^^^^^^^^^----------
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: use the right value directly: `self.date`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/timestamp.rs:165:33
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn matches(&self, date: &Date) -> bool {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/timestamp.rs:169:44
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn timestamp_for_date(&self, date: &Date) -> Option<Timestamp> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/timestamp.rs:170:33
[INFO] [stderr]     |
[INFO] [stderr] 170 |         if !self.is_active() || date < &self.date {
[INFO] [stderr]     |                                 ^^^^^^^----------
[INFO] [stderr]     |                                        |
[INFO] [stderr]     |                                        help: use the right value directly: `self.date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/timestamp.rs:176:12
[INFO] [stderr]     |
[INFO] [stderr] 176 |         if date <= &today && (self.kind == TimestampKind::Scheduled || self.kind == TimestampKind::Deadline) {
[INFO] [stderr]     |            ^^^^^^^^------
[INFO] [stderr]     |                    |
[INFO] [stderr]     |                    help: use the right value directly: `today`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/timestamp.rs:214:34
[INFO] [stderr]     |
[INFO] [stderr] 214 |                 timestamp.date = date.clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^ help: try dereferencing it: `*date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/timestamps.rs:25:38
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/timestamps.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.timestamps.iter().find(|timestamp| timestamp.matches(date)).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|timestamp| timestamp.matches(date)).is_some()` with `any(|timestamp| timestamp.matches(date))`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/timestamps.rs:29:52
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn timestamps_for_date<'a>(&'a self, date: &'a Date) -> impl Iterator<Item=Timestamp> + 'a {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::Tree<Node>`
[INFO] [stderr]   --> src/tree.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> Self {
[INFO] [stderr] 17 | |         Tree {
[INFO] [stderr] 18 | |             nodes: HashMap::new(),
[INFO] [stderr] 19 | |             children: HashMap::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/timestamp.rs:165:33
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn matches(&self, date: &Date) -> bool {
[INFO] [stderr]     |                                 ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/tree.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         self.nodes.keys().map(|id| *id)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/tree.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         self.children.get(&id)
[INFO] [stderr] 68 | |             .map(|vec| vec.as_slice())
[INFO] [stderr] 69 | |             .unwrap_or(&[])
[INFO] [stderr] 70 | |             .iter()
[INFO] [stderr] 71 | |             .map(|id| *id)
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 67 |         self.children.get(&id)
[INFO] [stderr] 68 |             .map(|vec| vec.as_slice())
[INFO] [stderr] 69 |             .unwrap_or(&[])
[INFO] [stderr] 70 |             .iter().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/timestamp.rs:169:44
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn timestamp_for_date(&self, date: &Date) -> Option<Timestamp> {
[INFO] [stderr]     |                                            ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/timestamp.rs:170:33
[INFO] [stderr]     |
[INFO] [stderr] 170 |         if !self.is_active() || date < &self.date {
[INFO] [stderr]     |                                 ^^^^^^^----------
[INFO] [stderr]     |                                        |
[INFO] [stderr]     |                                        help: use the right value directly: `self.date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/timestamp.rs:176:12
[INFO] [stderr]     |
[INFO] [stderr] 176 |         if date <= &today && (self.kind == TimestampKind::Scheduled || self.kind == TimestampKind::Deadline) {
[INFO] [stderr]     |            ^^^^^^^^------
[INFO] [stderr]     |                    |
[INFO] [stderr]     |                    help: use the right value directly: `today`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/timestamp.rs:214:34
[INFO] [stderr]     |
[INFO] [stderr] 214 |                 timestamp.date = date.clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^ help: try dereferencing it: `*date`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `orgmode`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/timestamps.rs:25:38
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn matches_date(&self, date: &Date) -> bool {
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/timestamps.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.timestamps.iter().find(|timestamp| timestamp.matches(date)).is_some()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|timestamp| timestamp.matches(date)).is_some()` with `any(|timestamp| timestamp.matches(date))`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/timestamps.rs:29:52
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn timestamps_for_date<'a>(&'a self, date: &'a Date) -> impl Iterator<Item=Timestamp> + 'a {
[INFO] [stderr]    |                                                    ^^^^^^^^ help: consider passing by value instead: `Date`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tree::Tree<Node>`
[INFO] [stderr]   --> src/tree.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> Self {
[INFO] [stderr] 17 | |         Tree {
[INFO] [stderr] 18 | |             nodes: HashMap::new(),
[INFO] [stderr] 19 | |             children: HashMap::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/tree.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         self.nodes.keys().map(|id| *id)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/tree.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         self.children.get(&id)
[INFO] [stderr] 68 | |             .map(|vec| vec.as_slice())
[INFO] [stderr] 69 | |             .unwrap_or(&[])
[INFO] [stderr] 70 | |             .iter()
[INFO] [stderr] 71 | |             .map(|id| *id)
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 67 |         self.children.get(&id)
[INFO] [stderr] 68 |             .map(|vec| vec.as_slice())
[INFO] [stderr] 69 |             .unwrap_or(&[])
[INFO] [stderr] 70 |             .iter().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "2dceb77c2eecd3527c20f229b233a3cd465f54958bea95225c194154b60f1547"`
[INFO] running `"docker" "rm" "-f" "2dceb77c2eecd3527c20f229b233a3cd465f54958bea95225c194154b60f1547"`
[INFO] [stdout] 2dceb77c2eecd3527c20f229b233a3cd465f54958bea95225c194154b60f1547