[INFO] updating cached repository hyperum/ontologica [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hyperum/ontologica [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hyperum/ontologica" "work/ex/clippy-test-run/sources/stable/gh/hyperum/ontologica"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hyperum/ontologica'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hyperum/ontologica" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hyperum/ontologica"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hyperum/ontologica'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebd0e3d63b02751f6efae7bfe067ca4d2474f4dc [INFO] sha for GitHub repo hyperum/ontologica: ebd0e3d63b02751f6efae7bfe067ca4d2474f4dc [INFO] validating manifest of hyperum/ontologica on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyperum/ontologica on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyperum/ontologica [INFO] finished frobbing hyperum/ontologica [INFO] frobbed toml for hyperum/ontologica written to work/ex/clippy-test-run/sources/stable/gh/hyperum/ontologica/Cargo.toml [INFO] started frobbing hyperum/ontologica [INFO] finished frobbing hyperum/ontologica [INFO] frobbed toml for hyperum/ontologica written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hyperum/ontologica/Cargo.toml [INFO] crate hyperum/ontologica has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyperum/ontologica against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hyperum/ontologica:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8621d5eef7c4895e8f9775b731dc8d96b580403f3f0617b724ed5238117cbcee [INFO] running `"docker" "start" "-a" "8621d5eef7c4895e8f9775b731dc8d96b580403f3f0617b724ed5238117cbcee"` [INFO] [stderr] Compiling pest v2.0.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking ontologica v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ontology.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ontology.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | let relation = self.arcs.get(relation_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.arcs[relation_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | if !tokens.peek().is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokens.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | if !tokens.peek().is_none() && tokens.peek().unwrap().as_rule() == Rule::composition [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokens.peek().is_some() && tokens.peek().unwrap().as_rule() == Rule::composition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ontology.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | let relation = self.arcs.get(relation_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.arcs[relation_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | if !tokens.peek().is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokens.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | if !tokens.peek().is_none() && tokens.peek().unwrap().as_rule() == Rule::composition [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tokens.peek().is_some() && tokens.peek().unwrap().as_rule() == Rule::composition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.31s [INFO] running `"docker" "inspect" "8621d5eef7c4895e8f9775b731dc8d96b580403f3f0617b724ed5238117cbcee"` [INFO] running `"docker" "rm" "-f" "8621d5eef7c4895e8f9775b731dc8d96b580403f3f0617b724ed5238117cbcee"` [INFO] [stdout] 8621d5eef7c4895e8f9775b731dc8d96b580403f3f0617b724ed5238117cbcee