[INFO] updating cached repository hwchen/ika
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hwchen/ika
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hwchen/ika" "work/ex/clippy-test-run/sources/stable/gh/hwchen/ika"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hwchen/ika'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hwchen/ika" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwchen/ika"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwchen/ika'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 526c0a765d15b614c00dc848f5aede583b347814
[INFO] sha for GitHub repo hwchen/ika: 526c0a765d15b614c00dc848f5aede583b347814
[INFO] validating manifest of hwchen/ika on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hwchen/ika on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hwchen/ika
[INFO] finished frobbing hwchen/ika
[INFO] frobbed toml for hwchen/ika written to work/ex/clippy-test-run/sources/stable/gh/hwchen/ika/Cargo.toml
[INFO] started frobbing hwchen/ika
[INFO] finished frobbing hwchen/ika
[INFO] frobbed toml for hwchen/ika written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hwchen/ika/Cargo.toml
[INFO] crate hwchen/ika has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hwchen/ika against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hwchen/ika:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ffca7f9b95b8b325b88388032a8164e78207aa1e3cfdba2133989bb324663558
[INFO] running `"docker" "start" "-a" "ffca7f9b95b8b325b88388032a8164e78207aa1e3cfdba2133989bb324663558"`
[INFO] [stderr]     Checking fallible-iterator v0.1.5
[INFO] [stderr]    Compiling actix-web v0.7.14
[INFO] [stderr]     Checking stringprep v0.1.2
[INFO] [stderr]     Checking ring v0.13.5
[INFO] [stderr]     Checking digest v0.7.6
[INFO] [stderr]     Checking serde_urlencoded v0.5.4
[INFO] [stderr]    Compiling structopt-derive v0.2.13
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking sha2 v0.7.1
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]     Checking tokio-signal v0.2.7
[INFO] [stderr]     Checking trust-dns-proto v0.5.0
[INFO] [stderr]     Checking pretty_env_logger v0.2.5
[INFO] [stderr]     Checking postgres-protocol v0.3.2
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking structopt v0.2.13
[INFO] [stderr]     Checking postgres-shared v0.4.2
[INFO] [stderr]     Checking postgres v0.15.2
[INFO] [stderr]     Checking trust-dns-resolver v0.10.0
[INFO] [stderr]     Checking r2d2_postgres v0.14.0
[INFO] [stderr]     Checking actix v0.7.7
[INFO] [stderr]     Checking actix-net v0.2.4
[INFO] [stderr]     Checking ika v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/handlers.rs:42:31
[INFO] [stderr]    |
[INFO] [stderr] 42 |       let (agg_type, col_idx) = match &query.agg.split('.').collect::<Vec<_>>()[..2] {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 43 | |         &[agg_type, col_idx] => (agg_type, col_idx),
[INFO] [stderr] 44 | |             _ => panic!("incorrect syntax for agg"),
[INFO] [stderr] 45 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let (agg_type, col_idx) = match query.agg.split('.').collect::<Vec<_>>()[..2] {
[INFO] [stderr] 43 |         [agg_type, col_idx] => (agg_type, col_idx),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:27:35
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let server_addr = opt.address.unwrap_or("127.0.0.1:4000".to_owned());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:4000".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:10
[INFO] [stderr]    |
[INFO] [stderr] 30 |         .or(opt.database_url.ok_or(format_err!("")))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| opt.database_url.ok_or(format_err!("")))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:30
[INFO] [stderr]    |
[INFO] [stderr] 30 |         .or(opt.database_url.ok_or(format_err!("")))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:45:10
[INFO] [stderr]    |
[INFO] [stderr] 45 |         .expect(&format!("cannot find to {}", server_addr))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("cannot find to {}", server_addr))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/handlers.rs:42:31
[INFO] [stderr]    |
[INFO] [stderr] 42 |       let (agg_type, col_idx) = match &query.agg.split('.').collect::<Vec<_>>()[..2] {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 43 | |         &[agg_type, col_idx] => (agg_type, col_idx),
[INFO] [stderr] 44 | |             _ => panic!("incorrect syntax for agg"),
[INFO] [stderr] 45 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let (agg_type, col_idx) = match query.agg.split('.').collect::<Vec<_>>()[..2] {
[INFO] [stderr] 43 |         [agg_type, col_idx] => (agg_type, col_idx),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:27:35
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let server_addr = opt.address.unwrap_or("127.0.0.1:4000".to_owned());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:4000".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:10
[INFO] [stderr]    |
[INFO] [stderr] 30 |         .or(opt.database_url.ok_or(format_err!("")))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| opt.database_url.ok_or(format_err!("")))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:30:30
[INFO] [stderr]    |
[INFO] [stderr] 30 |         .or(opt.database_url.ok_or(format_err!("")))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:45:10
[INFO] [stderr]    |
[INFO] [stderr] 45 |         .expect(&format!("cannot find to {}", server_addr))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("cannot find to {}", server_addr))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 55.33s
[INFO] running `"docker" "inspect" "ffca7f9b95b8b325b88388032a8164e78207aa1e3cfdba2133989bb324663558"`
[INFO] running `"docker" "rm" "-f" "ffca7f9b95b8b325b88388032a8164e78207aa1e3cfdba2133989bb324663558"`
[INFO] [stdout] ffca7f9b95b8b325b88388032a8164e78207aa1e3cfdba2133989bb324663558