[INFO] updating cached repository huwsun/Tiny_Three-Pass_Compiler
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/huwsun/Tiny_Three-Pass_Compiler
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/huwsun/Tiny_Three-Pass_Compiler" "work/ex/clippy-test-run/sources/stable/gh/huwsun/Tiny_Three-Pass_Compiler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huwsun/Tiny_Three-Pass_Compiler'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/huwsun/Tiny_Three-Pass_Compiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Tiny_Three-Pass_Compiler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Tiny_Three-Pass_Compiler'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0ee9b751ab0c696659365e94bd1e03813f111812
[INFO] sha for GitHub repo huwsun/Tiny_Three-Pass_Compiler: 0ee9b751ab0c696659365e94bd1e03813f111812
[INFO] validating manifest of huwsun/Tiny_Three-Pass_Compiler on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huwsun/Tiny_Three-Pass_Compiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huwsun/Tiny_Three-Pass_Compiler
[INFO] finished frobbing huwsun/Tiny_Three-Pass_Compiler
[INFO] frobbed toml for huwsun/Tiny_Three-Pass_Compiler written to work/ex/clippy-test-run/sources/stable/gh/huwsun/Tiny_Three-Pass_Compiler/Cargo.toml
[INFO] started frobbing huwsun/Tiny_Three-Pass_Compiler
[INFO] finished frobbing huwsun/Tiny_Three-Pass_Compiler
[INFO] frobbed toml for huwsun/Tiny_Three-Pass_Compiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Tiny_Three-Pass_Compiler/Cargo.toml
[INFO] crate huwsun/Tiny_Three-Pass_Compiler has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huwsun/Tiny_Three-Pass_Compiler against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/huwsun/Tiny_Three-Pass_Compiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b43f434aaaead70625eb45d3d7554abdba22a5e096f056681b832d4355ede384
[INFO] running `"docker" "start" "-a" "b43f434aaaead70625eb45d3d7554abdba22a5e096f056681b832d4355ede384"`
[INFO] [stderr]     Checking compiler v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:22:20
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Compiler { op: op,step:0 }
[INFO] [stderr]    |                    ^^^^^^ help: replace it with: `op`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:22:20
[INFO] [stderr]    |
[INFO] [stderr] 22 |         Compiler { op: op,step:0 }
[INFO] [stderr]    |                    ^^^^^^ help: replace it with: `op`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `argv`
[INFO] [stderr]    --> src/main.rs:320:9
[INFO] [stderr]     |
[INFO] [stderr] 320 |     let argv=vec![3i32,1,2];
[INFO] [stderr]     |         ^^^^ help: consider using `_argv` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `compile`
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     fn compile(&mut self, program: &str) -> Vec<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `pass1_1`
[INFO] [stderr]    --> src/main.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 |     fn pass1_1(&mut self, program: &str) -> Ast {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `simulate`
[INFO] [stderr]    --> src/main.rs:294:1
[INFO] [stderr]     |
[INFO] [stderr] 294 | fn simulate(assembly : Vec<&str>, argv : Vec<i32>) -> i32 {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         loop {
[INFO] [stderr] 30 | |             match iter.peek() {
[INFO] [stderr] 31 | |                 Some(&c) => match c {
[INFO] [stderr] 32 | |                     'a' ... 'z' | 'A' ... 'Z' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             }
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(&c) = iter.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:73:29
[INFO] [stderr]    |
[INFO] [stderr] 73 |         while let Some(s) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:98:30
[INFO] [stderr]    |
[INFO] [stderr] 98 |         while let Some(s) =  iter.next() {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:125:33
[INFO] [stderr]     |
[INFO] [stderr] 125 |                         if p == ")".to_string() {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:171:29
[INFO] [stderr]     |
[INFO] [stderr] 171 |         while let Some(s) = iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:207:33
[INFO] [stderr]     |
[INFO] [stderr] 207 |                         if p == "(".to_string() {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `"("`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         match ast {
[INFO] [stderr] 237 | |             &BinOp(ref op, ref a, ref b) => {
[INFO] [stderr] 238 | |                 let a = self.pass2(&*a);
[INFO] [stderr] 239 | |                 let b = self.pass2(&*b);
[INFO] [stderr] ...   |
[INFO] [stderr] 258 | |             }
[INFO] [stderr] 259 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 236 |         match *ast {
[INFO] [stderr] 237 |             BinOp(ref op, ref a, ref b) => {
[INFO] [stderr] 238 |                 let a = self.pass2(&*a);
[INFO] [stderr] 239 |                 let b = self.pass2(&*b);
[INFO] [stderr] 240 | 
[INFO] [stderr] 241 |                 match (&a, &b) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:265:9
[INFO] [stderr]     |
[INFO] [stderr] 265 | /         match ast {
[INFO] [stderr] 266 | |             &UnOp(ref op, n) => {
[INFO] [stderr] 267 | |                 if op == "imm" {
[INFO] [stderr] 268 | |                     asm.push(format!("IM {}", n));
[INFO] [stderr] ...   |
[INFO] [stderr] 287 | |             }
[INFO] [stderr] 288 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 265 |         match *ast {
[INFO] [stderr] 266 |             UnOp(ref op, n) => {
[INFO] [stderr] 267 |                 if op == "imm" {
[INFO] [stderr] 268 |                     asm.push(format!("IM {}", n));
[INFO] [stderr] 269 |                 } else if op == "arg" {
[INFO] [stderr] 270 |                     asm.push(format!("AR {}", n));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `argv`
[INFO] [stderr]    --> src/main.rs:320:9
[INFO] [stderr]     |
[INFO] [stderr] 320 |     let argv=vec![3i32,1,2];
[INFO] [stderr]     |         ^^^^ help: consider using `_argv` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `compile`
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     fn compile(&mut self, program: &str) -> Vec<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `pass1_1`
[INFO] [stderr]    --> src/main.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 |     fn pass1_1(&mut self, program: &str) -> Ast {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `simulate`
[INFO] [stderr]    --> src/main.rs:294:1
[INFO] [stderr]     |
[INFO] [stderr] 294 | fn simulate(assembly : Vec<&str>, argv : Vec<i32>) -> i32 {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         loop {
[INFO] [stderr] 30 | |             match iter.peek() {
[INFO] [stderr] 31 | |                 Some(&c) => match c {
[INFO] [stderr] 32 | |                     'a' ... 'z' | 'A' ... 'Z' => {
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             }
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(&c) = iter.peek() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:73:29
[INFO] [stderr]    |
[INFO] [stderr] 73 |         while let Some(s) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:98:30
[INFO] [stderr]    |
[INFO] [stderr] 98 |         while let Some(s) =  iter.next() {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:125:33
[INFO] [stderr]     |
[INFO] [stderr] 125 |                         if p == ")".to_string() {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:171:29
[INFO] [stderr]     |
[INFO] [stderr] 171 |         while let Some(s) = iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^ help: try: `for s in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:207:33
[INFO] [stderr]     |
[INFO] [stderr] 207 |                         if p == "(".to_string() {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `"("`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         match ast {
[INFO] [stderr] 237 | |             &BinOp(ref op, ref a, ref b) => {
[INFO] [stderr] 238 | |                 let a = self.pass2(&*a);
[INFO] [stderr] 239 | |                 let b = self.pass2(&*b);
[INFO] [stderr] ...   |
[INFO] [stderr] 258 | |             }
[INFO] [stderr] 259 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 236 |         match *ast {
[INFO] [stderr] 237 |             BinOp(ref op, ref a, ref b) => {
[INFO] [stderr] 238 |                 let a = self.pass2(&*a);
[INFO] [stderr] 239 |                 let b = self.pass2(&*b);
[INFO] [stderr] 240 | 
[INFO] [stderr] 241 |                 match (&a, &b) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:265:9
[INFO] [stderr]     |
[INFO] [stderr] 265 | /         match ast {
[INFO] [stderr] 266 | |             &UnOp(ref op, n) => {
[INFO] [stderr] 267 | |                 if op == "imm" {
[INFO] [stderr] 268 | |                     asm.push(format!("IM {}", n));
[INFO] [stderr] ...   |
[INFO] [stderr] 287 | |             }
[INFO] [stderr] 288 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 265 |         match *ast {
[INFO] [stderr] 266 |             UnOp(ref op, n) => {
[INFO] [stderr] 267 |                 if op == "imm" {
[INFO] [stderr] 268 |                     asm.push(format!("IM {}", n));
[INFO] [stderr] 269 |                 } else if op == "arg" {
[INFO] [stderr] 270 |                     asm.push(format!("AR {}", n));
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.31s
[INFO] running `"docker" "inspect" "b43f434aaaead70625eb45d3d7554abdba22a5e096f056681b832d4355ede384"`
[INFO] running `"docker" "rm" "-f" "b43f434aaaead70625eb45d3d7554abdba22a5e096f056681b832d4355ede384"`
[INFO] [stdout] b43f434aaaead70625eb45d3d7554abdba22a5e096f056681b832d4355ede384