[INFO] updating cached repository huwsun/Simple_Interactive_Interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/huwsun/Simple_Interactive_Interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/huwsun/Simple_Interactive_Interpreter" "work/ex/clippy-test-run/sources/stable/gh/huwsun/Simple_Interactive_Interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huwsun/Simple_Interactive_Interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/huwsun/Simple_Interactive_Interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Simple_Interactive_Interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Simple_Interactive_Interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df9d62c13133762414aa64ccc222de8ee7a690c2 [INFO] sha for GitHub repo huwsun/Simple_Interactive_Interpreter: df9d62c13133762414aa64ccc222de8ee7a690c2 [INFO] validating manifest of huwsun/Simple_Interactive_Interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of huwsun/Simple_Interactive_Interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing huwsun/Simple_Interactive_Interpreter [INFO] finished frobbing huwsun/Simple_Interactive_Interpreter [INFO] frobbed toml for huwsun/Simple_Interactive_Interpreter written to work/ex/clippy-test-run/sources/stable/gh/huwsun/Simple_Interactive_Interpreter/Cargo.toml [INFO] started frobbing huwsun/Simple_Interactive_Interpreter [INFO] finished frobbing huwsun/Simple_Interactive_Interpreter [INFO] frobbed toml for huwsun/Simple_Interactive_Interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwsun/Simple_Interactive_Interpreter/Cargo.toml [INFO] crate huwsun/Simple_Interactive_Interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting huwsun/Simple_Interactive_Interpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/huwsun/Simple_Interactive_Interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18269e0ce2578167dd66941a0fb9a5335afbba26112508233df5b1e9d7758a2a [INFO] running `"docker" "start" "-a" "18269e0ce2578167dd66941a0fb9a5335afbba26112508233df5b1e9d7758a2a"` [INFO] [stderr] Checking interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:200:43 [INFO] [stderr] | [INFO] [stderr] 200 | Parser { lexer: lexer.peekable(), funcs: funcs } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `funcs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:200:43 [INFO] [stderr] | [INFO] [stderr] 200 | Parser { lexer: lexer.peekable(), funcs: funcs } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `funcs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Lexer` [INFO] [stderr] --> src/main.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | use interpreter::{Interpreter,Lexer}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Lexer` [INFO] [stderr] --> src/main.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | use interpreter::{Interpreter,Lexer}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | ret.map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | .cloned().ok_or(format!("unknown variable `{}`", name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown variable `{}`", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | .cloned().ok_or(format!("unknown function `{}`", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown function `{}`", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | return Err(format!("duplicate arguments")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"duplicate arguments".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter.rs:206:23 [INFO] [stderr] | [INFO] [stderr] 206 | match op.clone() { [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | ret.map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | .cloned().ok_or(format!("unknown variable `{}`", name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown variable `{}`", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/interpreter.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | .cloned().ok_or(format!("unknown function `{}`", name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown function `{}`", name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/interpreter.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | return Err(format!("duplicate arguments")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"duplicate arguments".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interpreter.rs:206:23 [INFO] [stderr] | [INFO] [stderr] 206 | match op.clone() { [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "18269e0ce2578167dd66941a0fb9a5335afbba26112508233df5b1e9d7758a2a"` [INFO] running `"docker" "rm" "-f" "18269e0ce2578167dd66941a0fb9a5335afbba26112508233df5b1e9d7758a2a"` [INFO] [stdout] 18269e0ce2578167dd66941a0fb9a5335afbba26112508233df5b1e9d7758a2a