[INFO] updating cached repository huwb/learningrust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/huwb/learningrust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/learningrust" "work/ex/clippy-test-run/sources/stable/gh/huwb/learningrust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/huwb/learningrust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/huwb/learningrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/learningrust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/learningrust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 419b6eacb02bba0520897cba8888fb5184f3a1b8
[INFO] sha for GitHub repo huwb/learningrust: 419b6eacb02bba0520897cba8888fb5184f3a1b8
[INFO] validating manifest of huwb/learningrust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huwb/learningrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huwb/learningrust
[INFO] finished frobbing huwb/learningrust
[INFO] frobbed toml for huwb/learningrust written to work/ex/clippy-test-run/sources/stable/gh/huwb/learningrust/Cargo.toml
[INFO] started frobbing huwb/learningrust
[INFO] finished frobbing huwb/learningrust
[INFO] frobbed toml for huwb/learningrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/huwb/learningrust/Cargo.toml
[INFO] crate huwb/learningrust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huwb/learningrust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/huwb/learningrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 93db584dc87d640ca51e72701846275bfe4c96cbce4c0a0fe50955c5b1ac8484
[INFO] running `"docker" "start" "-a" "93db584dc87d640ca51e72701846275bfe4c96cbce4c0a0fe50955c5b1ac8484"`
[INFO] [stderr]     Checking simple-stopwatch v0.1.4
[INFO] [stderr]     Checking learningrust v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/points.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Point { x: x, y: y }
[INFO] [stderr]    |                 ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/points.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Point { x: x, y: y }
[INFO] [stderr]    |                       ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/points.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Point { x: x, y: y }
[INFO] [stderr]    |                 ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/points.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Point { x: x, y: y }
[INFO] [stderr]    |                       ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/closures.rs:51:12
[INFO] [stderr]    |
[INFO] [stderr] 51 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 52 | |         if random_number == 3 {
[INFO] [stderr] 53 | |             println!("Take a break today! Remember to stay hydrated!");
[INFO] [stderr] 54 | |         } else {
[INFO] [stderr] 55 | |             println!("Today, run for {} minutes!", calc_result.value());
[INFO] [stderr] 56 | |         }
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |     } else if random_number == 3 {
[INFO] [stderr] 52 |     println!("Take a break today! Remember to stay hydrated!");
[INFO] [stderr] 53 | } else {
[INFO] [stderr] 54 |     println!("Today, run for {} minutes!", calc_result.value());
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/patterns_chapter.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |     if let Point { x: 0, y: _ } = p {
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Point { x: 0, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/closures.rs:51:12
[INFO] [stderr]    |
[INFO] [stderr] 51 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 52 | |         if random_number == 3 {
[INFO] [stderr] 53 | |             println!("Take a break today! Remember to stay hydrated!");
[INFO] [stderr] 54 | |         } else {
[INFO] [stderr] 55 | |             println!("Today, run for {} minutes!", calc_result.value());
[INFO] [stderr] 56 | |         }
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |     } else if random_number == 3 {
[INFO] [stderr] 52 |     println!("Take a break today! Remember to stay hydrated!");
[INFO] [stderr] 53 | } else {
[INFO] [stderr] 54 |     println!("Today, run for {} minutes!", calc_result.value());
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/patterns_chapter.rs:27:26
[INFO] [stderr]    |
[INFO] [stderr] 27 |     if let Point { x: 0, y: _ } = p {
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `Point { x: 0, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `iterators::Counter`
[INFO] [stderr]  --> src/iterators.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | /     pub fn new() -> Counter {
[INFO] [stderr] 7 | |         Counter { counter: 0 }
[INFO] [stderr] 8 | |     }
[INFO] [stderr]   | |_____^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[derive(Default)]
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state_pattern::Post`
[INFO] [stderr]   --> src/state_pattern.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         Post {
[INFO] [stderr] 20 | |             state: Some(Box::new(StateDraft {})),
[INFO] [stderr] 21 | |             content: String::from(""),
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/state_pattern_rust.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     fn new() -> DraftPost {
[INFO] [stderr] 17 | |         DraftPost {
[INFO] [stderr] 18 | |             content: String::from(""),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/patterns_chapter.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     match robot_name {
[INFO] [stderr] 48 | |         // the syntax is not simply Some(&name) - that would destructure a reference as shown above!
[INFO] [stderr] 49 | |         Some(ref name) => println!("Found a name: {}", *name),
[INFO] [stderr] 50 | |         None => (),
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(ref name) = robot_name { println!("Found a name: {}", *name) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:37:14
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for i in 2..x + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `2..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |     for i in 2..x + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `2..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/prime.rs:64:33
[INFO] [stderr]    |
[INFO] [stderr] 64 |       let mut results: Vec<i32> = (*factors.lock().unwrap())
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 65 | |         .iter()
[INFO] [stderr] 66 | |         .map(|item| *item)
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 64 |     let mut results: Vec<i32> = (*factors.lock().unwrap())
[INFO] [stderr] 65 |         .iter().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:79:19
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for factor in 1..x + 1 {
[INFO] [stderr]    |                   ^^^^^^^^ help: use: `1..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/new_type_pattern.rs:11:12
[INFO] [stderr]    |
[INFO] [stderr] 11 |         if self.0.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `iterators::Counter`
[INFO] [stderr]  --> src/iterators.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | /     pub fn new() -> Counter {
[INFO] [stderr] 7 | |         Counter { counter: 0 }
[INFO] [stderr] 8 | |     }
[INFO] [stderr]   | |_____^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[derive(Default)]
[INFO] [stderr]   |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/points.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         assert_eq!(p3.x, p1.x + p2.x);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/points.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         assert_eq!(p3.x, p1.x + p2.x);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/points.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         assert_eq!(p3.y, p1.y + p2.y);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/points.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         assert_eq!(p3.y, p1.y + p2.y);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/points.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         assert_eq!(p0.length(), 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/points.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         assert_eq!(p0.length(), 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/points.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         assert_eq!(p1.length(), 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/points.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         assert_eq!(p1.length(), 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/spring.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         assert_eq!(s.x, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/spring.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         assert_eq!(s.x, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/spring.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         assert_eq!(s.v, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/spring.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         assert_eq!(s.v, 0.0);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/spring.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         assert_eq!(s.x, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/spring.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         assert_eq!(s.x, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/spring.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         assert_eq!(s.v, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/spring.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         assert_eq!(s.v, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/spring.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         assert_eq!(s.x, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/spring.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         assert_eq!(s.x, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/spring.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         assert_eq!(s.v, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/spring.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         assert_eq!(s.v, 0.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state_pattern::Post`
[INFO] [stderr]   --> src/state_pattern.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> Self {
[INFO] [stderr] 19 | |         Post {
[INFO] [stderr] 20 | |             state: Some(Box::new(StateDraft {})),
[INFO] [stderr] 21 | |             content: String::from(""),
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]   --> src/state_pattern_rust.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     fn new() -> DraftPost {
[INFO] [stderr] 17 | |         DraftPost {
[INFO] [stderr] 18 | |             content: String::from(""),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/patterns_chapter.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     match robot_name {
[INFO] [stderr] 48 | |         // the syntax is not simply Some(&name) - that would destructure a reference as shown above!
[INFO] [stderr] 49 | |         Some(ref name) => println!("Found a name: {}", *name),
[INFO] [stderr] 50 | |         None => (),
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Some(ref name) = robot_name { println!("Found a name: {}", *name) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/threadpool.rs:129:36
[INFO] [stderr]     |
[INFO] [stderr] 129 |         let job_ran_ref = Arc::new(Mutex::new(false));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/threadpool.rs:145:17
[INFO] [stderr]     |
[INFO] [stderr] 145 |         assert!(*job_ran_ref.lock().unwrap() == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*job_ran_ref.lock().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:37:14
[INFO] [stderr]    |
[INFO] [stderr] 37 |     for i in 2..x + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `2..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |     for i in 2..x + 1 {
[INFO] [stderr]    |              ^^^^^^^^ help: use: `2..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/prime.rs:64:33
[INFO] [stderr]    |
[INFO] [stderr] 64 |       let mut results: Vec<i32> = (*factors.lock().unwrap())
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 65 | |         .iter()
[INFO] [stderr] 66 | |         .map(|item| *item)
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 64 |     let mut results: Vec<i32> = (*factors.lock().unwrap())
[INFO] [stderr] 65 |         .iter().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prime.rs:79:19
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for factor in 1..x + 1 {
[INFO] [stderr]    |                   ^^^^^^^^ help: use: `1..=x`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/new_type_pattern.rs:11:12
[INFO] [stderr]    |
[INFO] [stderr] 11 |         if self.0.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 10 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `learningrust`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "93db584dc87d640ca51e72701846275bfe4c96cbce4c0a0fe50955c5b1ac8484"`
[INFO] running `"docker" "rm" "-f" "93db584dc87d640ca51e72701846275bfe4c96cbce4c0a0fe50955c5b1ac8484"`
[INFO] [stdout] 93db584dc87d640ca51e72701846275bfe4c96cbce4c0a0fe50955c5b1ac8484