[INFO] updating cached repository hustshawn/rust-iron-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hustshawn/rust-iron-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hustshawn/rust-iron-demo" "work/ex/clippy-test-run/sources/stable/gh/hustshawn/rust-iron-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hustshawn/rust-iron-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hustshawn/rust-iron-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hustshawn/rust-iron-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hustshawn/rust-iron-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f8107108916d5bed8c0b23adb975fb99cd665ed [INFO] sha for GitHub repo hustshawn/rust-iron-demo: 8f8107108916d5bed8c0b23adb975fb99cd665ed [INFO] validating manifest of hustshawn/rust-iron-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hustshawn/rust-iron-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hustshawn/rust-iron-demo [INFO] finished frobbing hustshawn/rust-iron-demo [INFO] frobbed toml for hustshawn/rust-iron-demo written to work/ex/clippy-test-run/sources/stable/gh/hustshawn/rust-iron-demo/Cargo.toml [INFO] started frobbing hustshawn/rust-iron-demo [INFO] finished frobbing hustshawn/rust-iron-demo [INFO] frobbed toml for hustshawn/rust-iron-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hustshawn/rust-iron-demo/Cargo.toml [INFO] crate hustshawn/rust-iron-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hustshawn/rust-iron-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hustshawn/rust-iron-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10bf2e20891da50ac87bb037311692dbacc4858c38cfdface6a25e2d2a2a8dd7 [INFO] running `"docker" "start" "-a" "10bf2e20891da50ac87bb037311692dbacc4858c38cfdface6a25e2d2a2a8dd7"` [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking iron-prj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | JsonResponse { response: response, success: true, error_message: "".to_string() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | JsonResponse { response: response, success: true, error_message: "".to_string() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | fn handler(req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | _ => format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | json::encode(&response).ok().expect("Error encoding response") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/main.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | fn handler(req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | _ => format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | json::encode(&response).ok().expect("Error encoding response") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `"docker" "inspect" "10bf2e20891da50ac87bb037311692dbacc4858c38cfdface6a25e2d2a2a8dd7"` [INFO] running `"docker" "rm" "-f" "10bf2e20891da50ac87bb037311692dbacc4858c38cfdface6a25e2d2a2a8dd7"` [INFO] [stdout] 10bf2e20891da50ac87bb037311692dbacc4858c38cfdface6a25e2d2a2a8dd7