[INFO] updating cached repository hunterrobbert/ColorCoordinator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hunterrobbert/ColorCoordinator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hunterrobbert/ColorCoordinator" "work/ex/clippy-test-run/sources/stable/gh/hunterrobbert/ColorCoordinator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hunterrobbert/ColorCoordinator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hunterrobbert/ColorCoordinator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterrobbert/ColorCoordinator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterrobbert/ColorCoordinator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 563269430f31d063342e4ce5abd7eaece5c6940b [INFO] sha for GitHub repo hunterrobbert/ColorCoordinator: 563269430f31d063342e4ce5abd7eaece5c6940b [INFO] validating manifest of hunterrobbert/ColorCoordinator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hunterrobbert/ColorCoordinator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hunterrobbert/ColorCoordinator [INFO] finished frobbing hunterrobbert/ColorCoordinator [INFO] frobbed toml for hunterrobbert/ColorCoordinator written to work/ex/clippy-test-run/sources/stable/gh/hunterrobbert/ColorCoordinator/Cargo.toml [INFO] started frobbing hunterrobbert/ColorCoordinator [INFO] finished frobbing hunterrobbert/ColorCoordinator [INFO] frobbed toml for hunterrobbert/ColorCoordinator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hunterrobbert/ColorCoordinator/Cargo.toml [INFO] crate hunterrobbert/ColorCoordinator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hunterrobbert/ColorCoordinator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hunterrobbert/ColorCoordinator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8747945815fbc2203e33b3000e4fdc746af331d02c9f3bde927e4bfe1fc622ff [INFO] running `"docker" "start" "-a" "8747945815fbc2203e33b3000e4fdc746af331d02c9f3bde927e4bfe1fc622ff"` [INFO] [stderr] Checking color_coordinator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | println!("Generating: {}", "coordinated.css"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | println!("Generating: {}", "coordinated.css"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | pub const THEME_DIR: &'static str = "src/schemes/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | pub const THEMED_DIR: &'static str = "dotfiles/themed/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub const UNTHEMED_DIR: &'static str = "dotfiles/unthemed/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub const XRES: &'static str = ".Xresources"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub const I3CONFIG: &'static str = "config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const I3STATUS: &'static str = "i3status.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | pub const VIM: &'static str = "coordinated.vim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | pub const DMENU: &'static str = "dmenu_run_themed"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub const XRES_FINAL_DEST: &'static str = "/home/hunter/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | pub const I3CONFIG_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | pub const I3STATUS_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub const VIM_FINAL_DEST: &'static str = "/home/hunter/.vim/colors/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | pub const DMENU_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | pub const THEME_DIR: &'static str = "src/schemes/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | pub const THEMED_DIR: &'static str = "dotfiles/themed/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub const UNTHEMED_DIR: &'static str = "dotfiles/unthemed/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub const XRES: &'static str = ".Xresources"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub const I3CONFIG: &'static str = "config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const I3STATUS: &'static str = "i3status.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | pub const VIM: &'static str = "coordinated.vim"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | pub const DMENU: &'static str = "dmenu_run_themed"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub const XRES_FINAL_DEST: &'static str = "/home/hunter/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | pub const I3CONFIG_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | pub const I3STATUS_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub const VIM_FINAL_DEST: &'static str = "/home/hunter/.vim/colors/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | pub const DMENU_FINAL_DEST: &'static str = "/home/hunter/.i3/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:4 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/colorscheme.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | / reader.read_to_string(buffer_string) [INFO] [stderr] 77 | | .ok() [INFO] [stderr] 78 | | .expect("Error reading color scheme text file!"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / write_on_color_loop(c, &mut colors_f, "$", ": ", ";") [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("Error writing color sass lines to new themed file"); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / reader.read_to_string(buffer_string) [INFO] [stderr] 49 | | .ok() [INFO] [stderr] 50 | | .expect("Error reading unthemed vim to buffer"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / append_unthemed_to_themed(&unthemed_f, &mut themed_f) [INFO] [stderr] 111 | | .ok() [INFO] [stderr] 112 | | .expect("Error appending remaining i3status to new file"); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / write_on_color_loop(c, &mut themed_f, line.0, line.1, line.2) [INFO] [stderr] 124 | | .ok() [INFO] [stderr] 125 | | .expect("Error writing colors to new themed file"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / append_unthemed_to_themed(&unthemed_f, &mut themed_f) [INFO] [stderr] 134 | | .ok() [INFO] [stderr] 135 | | .expect("Error appending remaining code to new themed file!"); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / reader.read_to_string(buffer_string) [INFO] [stderr] 147 | | .ok() [INFO] [stderr] 148 | | .expect("Error reading unthemed file"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | list_available_themes().ok().expect("Error reading theme dir"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / io::stdin().read_line(&mut theme_choice) [INFO] [stderr] 242 | | .ok() [INFO] [stderr] 243 | | .expect("Unable to read input"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / io::stdin().read_line(&mut file_choices) [INFO] [stderr] 260 | | .ok() [INFO] [stderr] 261 | | .expect("Couldn't interpret your file(s) choice"); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:263:43 [INFO] [stderr] | [INFO] [stderr] 263 | let opts: Vec<_> = file_choices.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | / clear_themed_dir(&constants::THEMED_DIR) [INFO] [stderr] 275 | | .ok() [INFO] [stderr] 276 | | .expect("Couldn't clear previously generated themed files"); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / clear_themed_dir("firefox/themed") [INFO] [stderr] 279 | | .ok() [INFO] [stderr] 280 | | .expect("Couldn't clear firefox themed dir"); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | / generate_themed_file(&c, &constants::XRES, xres_args) [INFO] [stderr] 285 | | .ok() [INFO] [stderr] 286 | | .expect("Couldn't write themed Xresource file!"); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | / generate_themed_file(&c, &constants::I3CONFIG, conf_args) [INFO] [stderr] 290 | | .ok() [INFO] [stderr] 291 | | .expect("Couldn't generate i3 config file!"); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / generate_vim_theme(&c) [INFO] [stderr] 294 | | .ok() [INFO] [stderr] 295 | | .expect("Couldn't generate vim color theme file!"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / generate_dmenu_script(&c) [INFO] [stderr] 298 | | .ok() [INFO] [stderr] 299 | | .expect("Couldn't generate dmenu script file!"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | / generate_themed_i3status(&c) [INFO] [stderr] 302 | | .ok() [INFO] [stderr] 303 | | .expect("Could not generate new I3STATUS file."); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / generate_firefox_theme(&c) [INFO] [stderr] 306 | | .ok() [INFO] [stderr] 307 | | .expect("Couldn't generate new firefox theme css"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / place_new_themed_file(&constants::XRES, &constants::XRES_FINAL_DEST) [INFO] [stderr] 310 | | .ok() [INFO] [stderr] 311 | | .expect("Couldn't place new XRES file in proper fs location."); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | / place_new_themed_file(&constants::I3CONFIG, &constants::I3CONFIG_FINAL_DEST) [INFO] [stderr] 314 | | .ok() [INFO] [stderr] 315 | | .expect("Couldn't place new I3CONFIG file in proper fs location"); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | / place_new_themed_file(&constants::I3STATUS, &constants::I3STATUS_FINAL_DEST) [INFO] [stderr] 318 | | .ok() [INFO] [stderr] 319 | | .expect("Couldn't place new I3STATUS file in proper fs location"); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | / place_new_themed_file(&constants::VIM, &constants::VIM_FINAL_DEST) [INFO] [stderr] 322 | | .ok() [INFO] [stderr] 323 | | .expect("Couldn't place new VIM file in proper fs location."); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:325:5 [INFO] [stderr] | [INFO] [stderr] 325 | / place_new_themed_file(&constants::DMENU, &constants::DMENU_FINAL_DEST) [INFO] [stderr] 326 | | .ok() [INFO] [stderr] 327 | | .expect("Couldn't place new DMENU file in proper fs location."); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/colorscheme.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | / reader.read_to_string(buffer_string) [INFO] [stderr] 77 | | .ok() [INFO] [stderr] 78 | | .expect("Error reading color scheme text file!"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / write_on_color_loop(c, &mut colors_f, "$", ": ", ";") [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("Error writing color sass lines to new themed file"); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / reader.read_to_string(buffer_string) [INFO] [stderr] 49 | | .ok() [INFO] [stderr] 50 | | .expect("Error reading unthemed vim to buffer"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / append_unthemed_to_themed(&unthemed_f, &mut themed_f) [INFO] [stderr] 111 | | .ok() [INFO] [stderr] 112 | | .expect("Error appending remaining i3status to new file"); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / write_on_color_loop(c, &mut themed_f, line.0, line.1, line.2) [INFO] [stderr] 124 | | .ok() [INFO] [stderr] 125 | | .expect("Error writing colors to new themed file"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / append_unthemed_to_themed(&unthemed_f, &mut themed_f) [INFO] [stderr] 134 | | .ok() [INFO] [stderr] 135 | | .expect("Error appending remaining code to new themed file!"); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / reader.read_to_string(buffer_string) [INFO] [stderr] 147 | | .ok() [INFO] [stderr] 148 | | .expect("Error reading unthemed file"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | list_available_themes().ok().expect("Error reading theme dir"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / io::stdin().read_line(&mut theme_choice) [INFO] [stderr] 242 | | .ok() [INFO] [stderr] 243 | | .expect("Unable to read input"); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / io::stdin().read_line(&mut file_choices) [INFO] [stderr] 260 | | .ok() [INFO] [stderr] 261 | | .expect("Couldn't interpret your file(s) choice"); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:263:43 [INFO] [stderr] | [INFO] [stderr] 263 | let opts: Vec<_> = file_choices.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | / clear_themed_dir(&constants::THEMED_DIR) [INFO] [stderr] 275 | | .ok() [INFO] [stderr] 276 | | .expect("Couldn't clear previously generated themed files"); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | / clear_themed_dir("firefox/themed") [INFO] [stderr] 279 | | .ok() [INFO] [stderr] 280 | | .expect("Couldn't clear firefox themed dir"); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | / generate_themed_file(&c, &constants::XRES, xres_args) [INFO] [stderr] 285 | | .ok() [INFO] [stderr] 286 | | .expect("Couldn't write themed Xresource file!"); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:289:5 [INFO] [stderr] | [INFO] [stderr] 289 | / generate_themed_file(&c, &constants::I3CONFIG, conf_args) [INFO] [stderr] 290 | | .ok() [INFO] [stderr] 291 | | .expect("Couldn't generate i3 config file!"); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | / generate_vim_theme(&c) [INFO] [stderr] 294 | | .ok() [INFO] [stderr] 295 | | .expect("Couldn't generate vim color theme file!"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / generate_dmenu_script(&c) [INFO] [stderr] 298 | | .ok() [INFO] [stderr] 299 | | .expect("Couldn't generate dmenu script file!"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | / generate_themed_i3status(&c) [INFO] [stderr] 302 | | .ok() [INFO] [stderr] 303 | | .expect("Could not generate new I3STATUS file."); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / generate_firefox_theme(&c) [INFO] [stderr] 306 | | .ok() [INFO] [stderr] 307 | | .expect("Couldn't generate new firefox theme css"); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / place_new_themed_file(&constants::XRES, &constants::XRES_FINAL_DEST) [INFO] [stderr] 310 | | .ok() [INFO] [stderr] 311 | | .expect("Couldn't place new XRES file in proper fs location."); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | / place_new_themed_file(&constants::I3CONFIG, &constants::I3CONFIG_FINAL_DEST) [INFO] [stderr] 314 | | .ok() [INFO] [stderr] 315 | | .expect("Couldn't place new I3CONFIG file in proper fs location"); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | / place_new_themed_file(&constants::I3STATUS, &constants::I3STATUS_FINAL_DEST) [INFO] [stderr] 318 | | .ok() [INFO] [stderr] 319 | | .expect("Couldn't place new I3STATUS file in proper fs location"); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | / place_new_themed_file(&constants::VIM, &constants::VIM_FINAL_DEST) [INFO] [stderr] 322 | | .ok() [INFO] [stderr] 323 | | .expect("Couldn't place new VIM file in proper fs location."); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:325:5 [INFO] [stderr] | [INFO] [stderr] 325 | / place_new_themed_file(&constants::DMENU, &constants::DMENU_FINAL_DEST) [INFO] [stderr] 326 | | .ok() [INFO] [stderr] 327 | | .expect("Couldn't place new DMENU file in proper fs location."); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "8747945815fbc2203e33b3000e4fdc746af331d02c9f3bde927e4bfe1fc622ff"` [INFO] running `"docker" "rm" "-f" "8747945815fbc2203e33b3000e4fdc746af331d02c9f3bde927e4bfe1fc622ff"` [INFO] [stdout] 8747945815fbc2203e33b3000e4fdc746af331d02c9f3bde927e4bfe1fc622ff