[INFO] updating cached repository hummingly/ics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hummingly/ics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hummingly/ics" "work/ex/clippy-test-run/sources/stable/gh/hummingly/ics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hummingly/ics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hummingly/ics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hummingly/ics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hummingly/ics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 642c6dd53b51e8e666db7d27cb223dc76e0d0d43 [INFO] sha for GitHub repo hummingly/ics: 642c6dd53b51e8e666db7d27cb223dc76e0d0d43 [INFO] validating manifest of hummingly/ics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hummingly/ics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hummingly/ics [INFO] finished frobbing hummingly/ics [INFO] frobbed toml for hummingly/ics written to work/ex/clippy-test-run/sources/stable/gh/hummingly/ics/Cargo.toml [INFO] started frobbing hummingly/ics [INFO] finished frobbing hummingly/ics [INFO] frobbed toml for hummingly/ics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hummingly/ics/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hummingly/ics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hummingly/ics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 696b222e563f0256eb806f028eb490088bd55e7ba4e16cd10cb5a278a49be1c2 [INFO] running `"docker" "start" "-a" "696b222e563f0256eb806f028eb490088bd55e7ba4e16cd10cb5a278a49be1c2"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking memchr v2.1.3 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking ics v0.2.2 (/opt/crater/workdir) [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/util.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | let expected = s.clone(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 108 | let expected = &(*s).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 108 | let expected = &str::clone(s); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ics`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "696b222e563f0256eb806f028eb490088bd55e7ba4e16cd10cb5a278a49be1c2"` [INFO] running `"docker" "rm" "-f" "696b222e563f0256eb806f028eb490088bd55e7ba4e16cd10cb5a278a49be1c2"` [INFO] [stdout] 696b222e563f0256eb806f028eb490088bd55e7ba4e16cd10cb5a278a49be1c2