[INFO] updating cached repository human9/baryon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/human9/baryon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/human9/baryon" "work/ex/clippy-test-run/sources/stable/gh/human9/baryon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/human9/baryon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/human9/baryon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/human9/baryon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/human9/baryon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0543d00b0f1b8e3c5b42fa792979bc827417f029 [INFO] sha for GitHub repo human9/baryon: 0543d00b0f1b8e3c5b42fa792979bc827417f029 [INFO] validating manifest of human9/baryon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of human9/baryon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing human9/baryon [INFO] finished frobbing human9/baryon [INFO] frobbed toml for human9/baryon written to work/ex/clippy-test-run/sources/stable/gh/human9/baryon/Cargo.toml [INFO] started frobbing human9/baryon [INFO] finished frobbing human9/baryon [INFO] frobbed toml for human9/baryon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/human9/baryon/Cargo.toml [INFO] crate human9/baryon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting human9/baryon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/human9/baryon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 836142b8eae579a21f277a09d6a5298f03c87ee7cc5946b8d824a72da2747362 [INFO] running `"docker" "start" "-a" "836142b8eae579a21f277a09d6a5298f03c87ee7cc5946b8d824a72da2747362"` [INFO] [stderr] Checking tobj v0.1.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking glm v0.2.2 [INFO] [stderr] Checking baryon v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | element_vbo: element_vbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | index_vbo: index_vbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | element_array: element_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | index_array: index_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base/window.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | uniforms: uniforms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `uniforms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | element_vbo: element_vbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | index_vbo: index_vbo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_vbo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | element_array: element_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/object.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | index_array: index_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base/window.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/shader.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | uniforms: uniforms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `uniforms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/core/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod core; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/core/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod core; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/core/scene.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `render::shader::Shader` [INFO] [stderr] --> src/core/scene.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use render::shader::Shader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/render/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod render; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/core/scene.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `render::shader::Shader` [INFO] [stderr] --> src/core/scene.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use render::shader::Shader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/render/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod render; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/physics/simulation.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | fn run(&mut self, bus: &mut Bus) -> &system::Status { [INFO] [stderr] | ^^^ help: consider using `_bus` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/render/render.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | fn run(&mut self, bus: &mut Bus) -> &system::Status { [INFO] [stderr] | ^^^ help: consider using `_bus` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/physics/simulation.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | fn run(&mut self, bus: &mut Bus) -> &system::Status { [INFO] [stderr] | ^^^ help: consider using `_bus` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bus` [INFO] [stderr] --> src/render/render.rs:87:23 [INFO] [stderr] | [INFO] [stderr] 87 | fn run(&mut self, bus: &mut Bus) -> &system::Status { [INFO] [stderr] | ^^^ help: consider using `_bus` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Failed` [INFO] [stderr] --> src/core/system.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Failed, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/core.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match system.run(&mut bus) { [INFO] [stderr] 39 | | &Status::Okay => (), [INFO] [stderr] 40 | | &Status::Failed => println!("{} has failed", system.name()), [INFO] [stderr] 41 | | &Status::Finished => complete += 1, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *system.run(&mut bus) { [INFO] [stderr] 39 | Status::Okay => (), [INFO] [stderr] 40 | Status::Failed => println!("{} has failed", system.name()), [INFO] [stderr] 41 | Status::Finished => complete += 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core/core.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | diff = (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/core/core.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | diff = (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/object.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref mesh = model.mesh; [INFO] [stderr] | ----^^^^^^^^-------------- help: try: `let mesh = &model.mesh;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/object.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | element_array.push(*mesh.positions.get(v).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | element_array.push(*mesh.positions.get(v + 1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | element_array.push(*mesh.positions.get(v + 2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | index_array.push(*map.get(index).unwrap() as u32); // push index of non-unique element [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/core/object.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mem::transmute(&element_array[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&element_array[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/core/object.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | mem::transmute(&index_array[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&index_array[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | window.set_cursor_state(glutin::CursorState::Grab); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | window.set_cursor_position(W/2, H/2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | self.window.set_cursor_position(self.m_pos.0, self.m_pos.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | self.window.set_cursor_position(self.m_pos.0, self.m_pos.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base/window.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/base/window.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | match *msg { [INFO] [stderr] 132 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/logic.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.state { [INFO] [stderr] 29 | | 0 => { [INFO] [stderr] 30 | | self.state += 1; [INFO] [stderr] 31 | | [INFO] [stderr] ... | [INFO] [stderr] 54 | | }, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let 0 = self.state { [INFO] [stderr] 29 | self.state += 1; [INFO] [stderr] 30 | [INFO] [stderr] 31 | let teapot_raw = tobj::load_obj(&Path::new("res/mesh/lucy.obj")); [INFO] [stderr] 32 | assert!(teapot_raw.is_ok()); [INFO] [stderr] 33 | let models = teapot_raw.unwrap().0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Failed` [INFO] [stderr] --> src/core/system.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Failed, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/logic.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | let teapot = object::tobj_to_object(&models.get(0).unwrap(), rc_shader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&models[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/logic.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match msg { [INFO] [stderr] 61 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/logic.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match msg { [INFO] [stderr] 61 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *msg { [INFO] [stderr] 61 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/camera.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.azimuth = self.azimuth % 360.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.azimuth %= 360.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/core.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match system.run(&mut bus) { [INFO] [stderr] 39 | | &Status::Okay => (), [INFO] [stderr] 40 | | &Status::Failed => println!("{} has failed", system.name()), [INFO] [stderr] 41 | | &Status::Finished => complete += 1, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *system.run(&mut bus) { [INFO] [stderr] 39 | Status::Okay => (), [INFO] [stderr] 40 | Status::Failed => println!("{} has failed", system.name()), [INFO] [stderr] 41 | Status::Finished => complete += 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core/core.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | diff = (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/core/core.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | diff = (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/physics/simulation.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match msg { [INFO] [stderr] 21 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/physics/simulation.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match msg { [INFO] [stderr] 21 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *msg { [INFO] [stderr] 21 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/render/render.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let ref s = o.shader; [INFO] [stderr] | ----^^^^^------------ help: try: `let s = &o.shader;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/render/render.rs:114:76 [INFO] [stderr] | [INFO] [stderr] 114 | gl::UniformMatrix4fv(s.uniforms.mvp_uniform, 1, gl::FALSE, mem::transmute(&mvp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mvp as *const game::camera::glm::Matrix4 as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/render.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.shutdown(), [INFO] [stderr] 133 | | &Message::LoadScene(ref scene) => self.load_scene(scene), [INFO] [stderr] 134 | | &Message::Resized(w, h) => { [INFO] [stderr] ... | [INFO] [stderr] 144 | | //_ => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | match *msg { [INFO] [stderr] 132 | Message::Shutdown => self.shutdown(), [INFO] [stderr] 133 | Message::LoadScene(ref scene) => self.load_scene(scene), [INFO] [stderr] 134 | Message::Resized(w, h) => { [INFO] [stderr] 135 | unsafe {gl::Viewport(0, 0, w as i32, h as i32)}; [INFO] [stderr] 136 | self.resolution = (w, h); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/render/shader.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | unsafe { ret = gl::GetAttribLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/render/shader.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | unsafe { ret = gl::GetAttribLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/render/shader.rs:44:52 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { ret = gl::GetUniformLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/render/shader.rs:44:52 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { ret = gl::GetUniformLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/shader.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / match file.read_to_string(&mut s) { [INFO] [stderr] 91 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 92 | | why.description()), [INFO] [stderr] 93 | | Ok(_) => (), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 91 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/render/shader.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | panic!("{}", str::from_utf8(&buf).ok().expect("ShaderInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/render/shader.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | panic!("{}", str::from_utf8(&buf).ok().expect("ProgramInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/object.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref mesh = model.mesh; [INFO] [stderr] | ----^^^^^^^^-------------- help: try: `let mesh = &model.mesh;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/object.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | i = i+1; [INFO] [stderr] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | element_array.push(*mesh.positions.get(v).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | element_array.push(*mesh.positions.get(v + 1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | element_array.push(*mesh.positions.get(v + 2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `mesh.positions[v + 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/core/object.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | index_array.push(*map.get(index).unwrap() as u32); // push index of non-unique element [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/core/object.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | mem::transmute(&element_array[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&element_array[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/core/object.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | mem::transmute(&index_array[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&index_array[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | window.set_cursor_state(glutin::CursorState::Grab); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | window.set_cursor_position(W/2, H/2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: Could not compile `baryon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | self.window.set_cursor_position(self.m_pos.0, self.m_pos.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/base/window.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | self.window.set_cursor_position(self.m_pos.0, self.m_pos.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/base/window.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/base/window.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | match *msg { [INFO] [stderr] 132 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/logic.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.state { [INFO] [stderr] 29 | | 0 => { [INFO] [stderr] 30 | | self.state += 1; [INFO] [stderr] 31 | | [INFO] [stderr] ... | [INFO] [stderr] 54 | | }, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let 0 = self.state { [INFO] [stderr] 29 | self.state += 1; [INFO] [stderr] 30 | [INFO] [stderr] 31 | let teapot_raw = tobj::load_obj(&Path::new("res/mesh/lucy.obj")); [INFO] [stderr] 32 | assert!(teapot_raw.is_ok()); [INFO] [stderr] 33 | let models = teapot_raw.unwrap().0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/logic.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | let teapot = object::tobj_to_object(&models.get(0).unwrap(), rc_shader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&models[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/logic.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match msg { [INFO] [stderr] 61 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/logic.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match msg { [INFO] [stderr] 61 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 62 | | _ => (), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *msg { [INFO] [stderr] 61 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game/camera.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.azimuth = self.azimuth % 360.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.azimuth %= 360.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/physics/simulation.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match msg { [INFO] [stderr] 21 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Message::Shutdown = msg { self.status = system::Status::Finished }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/physics/simulation.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match msg { [INFO] [stderr] 21 | | &Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *msg { [INFO] [stderr] 21 | Message::Shutdown => self.status = system::Status::Finished, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/render/render.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let ref s = o.shader; [INFO] [stderr] | ----^^^^^------------ help: try: `let s = &o.shader;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/render/render.rs:114:76 [INFO] [stderr] | [INFO] [stderr] 114 | gl::UniformMatrix4fv(s.uniforms.mvp_uniform, 1, gl::FALSE, mem::transmute(&mvp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mvp as *const game::camera::glm::Matrix4 as *const f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/render.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / match msg { [INFO] [stderr] 132 | | &Message::Shutdown => self.shutdown(), [INFO] [stderr] 133 | | &Message::LoadScene(ref scene) => self.load_scene(scene), [INFO] [stderr] 134 | | &Message::Resized(w, h) => { [INFO] [stderr] ... | [INFO] [stderr] 144 | | //_ => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | match *msg { [INFO] [stderr] 132 | Message::Shutdown => self.shutdown(), [INFO] [stderr] 133 | Message::LoadScene(ref scene) => self.load_scene(scene), [INFO] [stderr] 134 | Message::Resized(w, h) => { [INFO] [stderr] 135 | unsafe {gl::Viewport(0, 0, w as i32, h as i32)}; [INFO] [stderr] 136 | self.resolution = (w, h); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/render/shader.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | unsafe { ret = gl::GetAttribLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/render/shader.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | unsafe { ret = gl::GetAttribLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/render/shader.rs:44:52 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { ret = gl::GetUniformLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/render/shader.rs:44:52 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { ret = gl::GetUniformLocation(program, CString::new(name).unwrap().as_ptr()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/shader.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / match file.read_to_string(&mut s) { [INFO] [stderr] 91 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 92 | | why.description()), [INFO] [stderr] 93 | | Ok(_) => (), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 91 | why.description()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/render/shader.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | panic!("{}", str::from_utf8(&buf).ok().expect("ShaderInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/render/shader.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/render/shader.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | panic!("{}", str::from_utf8(&buf).ok().expect("ProgramInfoLog not valid utf8")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `baryon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "836142b8eae579a21f277a09d6a5298f03c87ee7cc5946b8d824a72da2747362"` [INFO] running `"docker" "rm" "-f" "836142b8eae579a21f277a09d6a5298f03c87ee7cc5946b8d824a72da2747362"` [INFO] [stdout] 836142b8eae579a21f277a09d6a5298f03c87ee7cc5946b8d824a72da2747362