[INFO] updating cached repository hubrys/image-shredder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hubrys/image-shredder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hubrys/image-shredder" "work/ex/clippy-test-run/sources/stable/gh/hubrys/image-shredder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hubrys/image-shredder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hubrys/image-shredder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hubrys/image-shredder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hubrys/image-shredder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e1977111261005ae7e0c59f099093b5c4218a1dd [INFO] sha for GitHub repo hubrys/image-shredder: e1977111261005ae7e0c59f099093b5c4218a1dd [INFO] validating manifest of hubrys/image-shredder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hubrys/image-shredder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hubrys/image-shredder [INFO] finished frobbing hubrys/image-shredder [INFO] frobbed toml for hubrys/image-shredder written to work/ex/clippy-test-run/sources/stable/gh/hubrys/image-shredder/Cargo.toml [INFO] started frobbing hubrys/image-shredder [INFO] finished frobbing hubrys/image-shredder [INFO] frobbed toml for hubrys/image-shredder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hubrys/image-shredder/Cargo.toml [INFO] crate hubrys/image-shredder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hubrys/image-shredder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hubrys/image-shredder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4679e6a8e22a5b1810a177fe42e90999d41450f899a44ec42f38ddebff8bede [INFO] running `"docker" "start" "-a" "c4679e6a8e22a5b1810a177fe42e90999d41450f899a44ec42f38ddebff8bede"` [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking raster v0.2.0 [INFO] [stderr] Checking image-shredder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping `output_image` and `original_image` manually [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / let tmp = output_image; [INFO] [stderr] 51 | | output_image = original_image; [INFO] [stderr] 52 | | original_image = tmp; [INFO] [stderr] | |________________________^ help: try: `std::mem::swap(&mut output_image, &mut original_image)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `output_image` and `original_image` manually [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / let tmp = output_image; [INFO] [stderr] 51 | | output_image = original_image; [INFO] [stderr] 52 | | original_image = tmp; [INFO] [stderr] | |________________________^ help: try: `std::mem::swap(&mut output_image, &mut original_image)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.12s [INFO] running `"docker" "inspect" "c4679e6a8e22a5b1810a177fe42e90999d41450f899a44ec42f38ddebff8bede"` [INFO] running `"docker" "rm" "-f" "c4679e6a8e22a5b1810a177fe42e90999d41450f899a44ec42f38ddebff8bede"` [INFO] [stdout] c4679e6a8e22a5b1810a177fe42e90999d41450f899a44ec42f38ddebff8bede