[INFO] updating cached repository hso132/sapphbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hso132/sapphbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hso132/sapphbot" "work/ex/clippy-test-run/sources/stable/gh/hso132/sapphbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hso132/sapphbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hso132/sapphbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/sapphbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/sapphbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aed758d0d8bb0afa67fb24ef796a4af3fef67270 [INFO] sha for GitHub repo hso132/sapphbot: aed758d0d8bb0afa67fb24ef796a4af3fef67270 [INFO] validating manifest of hso132/sapphbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hso132/sapphbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hso132/sapphbot [INFO] finished frobbing hso132/sapphbot [INFO] frobbed toml for hso132/sapphbot written to work/ex/clippy-test-run/sources/stable/gh/hso132/sapphbot/Cargo.toml [INFO] started frobbing hso132/sapphbot [INFO] finished frobbing hso132/sapphbot [INFO] frobbed toml for hso132/sapphbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/sapphbot/Cargo.toml [INFO] crate hso132/sapphbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hso132/sapphbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hso132/sapphbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 012da338b2e9131e0f9b4404b83031dbfc119d8728d9b74ab5539fc23362ae83 [INFO] running `"docker" "start" "-a" "012da338b2e9131e0f9b4404b83031dbfc119d8728d9b74ab5539fc23362ae83"` [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Checking hyper v0.12.17 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking sapphbot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn log(message: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn log(message: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused label `'updates` [INFO] [stderr] --> src/bot/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / 'updates: loop { [INFO] [stderr] 113 | | let update_url = &self.url( [INFO] [stderr] 114 | | "getUpdates", [INFO] [stderr] 115 | | &[ [INFO] [stderr] ... | [INFO] [stderr] 147 | | thread::sleep(time::Duration::from_millis(100)) [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'updates` [INFO] [stderr] --> src/bot/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / 'updates: loop { [INFO] [stderr] 113 | | let update_url = &self.url( [INFO] [stderr] 114 | | "getUpdates", [INFO] [stderr] 115 | | &[ [INFO] [stderr] ... | [INFO] [stderr] 147 | | thread::sleep(time::Duration::from_millis(100)) [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bot/mod.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | let mut text = raw_text.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot/mod.rs:300:12 [INFO] [stderr] | [INFO] [stderr] 300 | if new_images.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bot/mod.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | let mut text = raw_text.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot/mod.rs:300:12 [INFO] [stderr] | [INFO] [stderr] 300 | if new_images.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!new_images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/data/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | timeout = timeout * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/data/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | timeout = timeout * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match bot.run() { [INFO] [stderr] 15 | | Err(err) => println!("The bot has abruptly stopped. \n{:?}", err), [INFO] [stderr] 16 | | _ => (), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = bot.run() { println!("The bot has abruptly stopped. \n{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match bot.run() { [INFO] [stderr] 15 | | Err(err) => println!("The bot has abruptly stopped. \n{:?}", err), [INFO] [stderr] 16 | | _ => (), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = bot.run() { println!("The bot has abruptly stopped. \n{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.07s [INFO] running `"docker" "inspect" "012da338b2e9131e0f9b4404b83031dbfc119d8728d9b74ab5539fc23362ae83"` [INFO] running `"docker" "rm" "-f" "012da338b2e9131e0f9b4404b83031dbfc119d8728d9b74ab5539fc23362ae83"` [INFO] [stdout] 012da338b2e9131e0f9b4404b83031dbfc119d8728d9b74ab5539fc23362ae83