[INFO] updating cached repository hso132/SapphCells [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hso132/SapphCells [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hso132/SapphCells" "work/ex/clippy-test-run/sources/stable/gh/hso132/SapphCells"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hso132/SapphCells'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hso132/SapphCells" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/SapphCells"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/SapphCells'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9acfa03f84fddb9952390f46d69c2a3232da8d77 [INFO] sha for GitHub repo hso132/SapphCells: 9acfa03f84fddb9952390f46d69c2a3232da8d77 [INFO] validating manifest of hso132/SapphCells on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hso132/SapphCells on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hso132/SapphCells [INFO] finished frobbing hso132/SapphCells [INFO] frobbed toml for hso132/SapphCells written to work/ex/clippy-test-run/sources/stable/gh/hso132/SapphCells/Cargo.toml [INFO] started frobbing hso132/SapphCells [INFO] finished frobbing hso132/SapphCells [INFO] frobbed toml for hso132/SapphCells written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hso132/SapphCells/Cargo.toml [INFO] crate hso132/SapphCells has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hso132/SapphCells against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hso132/SapphCells:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 842fe58672e24e685f740508a19adb93226a3b40b517a16b96462b03161a6147 [INFO] running `"docker" "start" "-a" "842fe58672e24e685f740508a19adb93226a3b40b517a16b96462b03161a6147"` [INFO] [stderr] Checking sapphcells v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/data.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 71 | | if self.food_chance > rand::random(){ [INFO] [stderr] 72 | | Tile::FoodSource(5) [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | Tile::Empty [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | } else if self.food_chance > rand::random(){ [INFO] [stderr] 71 | Tile::FoodSource(5) [INFO] [stderr] 72 | } else { [INFO] [stderr] 73 | Tile::Empty [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/data.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 71 | | if self.food_chance > rand::random(){ [INFO] [stderr] 72 | | Tile::FoodSource(5) [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | Tile::Empty [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | } else if self.food_chance > rand::random(){ [INFO] [stderr] 71 | Tile::FoodSource(5) [INFO] [stderr] 72 | } else { [INFO] [stderr] 73 | Tile::Empty [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match event { [INFO] [stderr] 23 | | Event::Closed => window.close(), [INFO] [stderr] 24 | | _ => () [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { window.close() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | let (cell_width, cell_height) = (width as f32/board.width() as f32, height as f32/board.height() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(board.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:47:87 [INFO] [stderr] | [INFO] [stderr] 47 | let (cell_width, cell_height) = (width as f32/board.width() as f32, height as f32/board.height() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(board.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | cell.set_position(Vector2f{x: x as f32*cell_width,y: y as f32*cell_height}); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:53:66 [INFO] [stderr] | [INFO] [stderr] 53 | cell.set_position(Vector2f{x: x as f32*cell_width,y: y as f32*cell_height}); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | if max_cells > (max_x as u32 * max_y as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(max_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | if max_cells > (max_x as u32 * max_y as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(max_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::NoTerrain` [INFO] [stderr] --> src/data.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn new() -> NoTerrain { [INFO] [stderr] 93 | | NoTerrain [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::BadRandomTerrain` [INFO] [stderr] --> src/data.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> BadRandomTerrain { [INFO] [stderr] 98 | | BadRandomTerrain [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match event { [INFO] [stderr] 23 | | Event::Closed => window.close(), [INFO] [stderr] 24 | | _ => () [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { window.close() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | let (cell_width, cell_height) = (width as f32/board.width() as f32, height as f32/board.height() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(board.width())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:47:87 [INFO] [stderr] | [INFO] [stderr] 47 | let (cell_width, cell_height) = (width as f32/board.width() as f32, height as f32/board.height() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(board.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | cell.set_position(Vector2f{x: x as f32*cell_width,y: y as f32*cell_height}); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:53:66 [INFO] [stderr] | [INFO] [stderr] 53 | cell.set_position(Vector2f{x: x as f32*cell_width,y: y as f32*cell_height}); [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | if max_cells > (max_x as u32 * max_y as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(max_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | if max_cells > (max_x as u32 * max_y as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(max_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::NoTerrain` [INFO] [stderr] --> src/data.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn new() -> NoTerrain { [INFO] [stderr] 93 | | NoTerrain [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::BadRandomTerrain` [INFO] [stderr] --> src/data.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> BadRandomTerrain { [INFO] [stderr] 98 | | BadRandomTerrain [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "842fe58672e24e685f740508a19adb93226a3b40b517a16b96462b03161a6147"` [INFO] running `"docker" "rm" "-f" "842fe58672e24e685f740508a19adb93226a3b40b517a16b96462b03161a6147"` [INFO] [stdout] 842fe58672e24e685f740508a19adb93226a3b40b517a16b96462b03161a6147