[INFO] updating cached repository hsgw/rename_gerber [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hsgw/rename_gerber [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hsgw/rename_gerber" "work/ex/clippy-test-run/sources/stable/gh/hsgw/rename_gerber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hsgw/rename_gerber'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hsgw/rename_gerber" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsgw/rename_gerber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsgw/rename_gerber'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 469bc187f0c2277e5dffba3388bdfd1d1030966a [INFO] sha for GitHub repo hsgw/rename_gerber: 469bc187f0c2277e5dffba3388bdfd1d1030966a [INFO] validating manifest of hsgw/rename_gerber on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hsgw/rename_gerber on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hsgw/rename_gerber [INFO] finished frobbing hsgw/rename_gerber [INFO] frobbed toml for hsgw/rename_gerber written to work/ex/clippy-test-run/sources/stable/gh/hsgw/rename_gerber/Cargo.toml [INFO] started frobbing hsgw/rename_gerber [INFO] finished frobbing hsgw/rename_gerber [INFO] frobbed toml for hsgw/rename_gerber written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hsgw/rename_gerber/Cargo.toml [INFO] crate hsgw/rename_gerber has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hsgw/rename_gerber against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hsgw/rename_gerber:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78909f1de946ba7f95ea5f7f0a29cac2b74f59942fc87fbbb9f061ab72d67425 [INFO] running `"docker" "start" "-a" "78909f1de946ba7f95ea5f7f0a29cac2b74f59942fc87fbbb9f061ab72d67425"` [INFO] [stderr] Checking rename_gerber v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:63:90 [INFO] [stderr] | [INFO] [stderr] 63 | file_data.push(FileData{file_name: file_name.clone(), path: file.path(), ext: ext}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ext` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:63:90 [INFO] [stderr] | [INFO] [stderr] 63 | file_data.push(FileData{file_name: file_name.clone(), path: file.path(), ext: ext}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ext` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn find_by_extention( file_data: &Vec, ext: &GerberExtension) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[FileData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(_) = file_name.find(ext.from) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 59 | | if let Some(pos) = find_by_extention(&file_data, &ext) { [INFO] [stderr] 60 | | println!("{} is already found! {}, {}", ext.from, file_data[pos].file_name, file_name); [INFO] [stderr] 61 | | return [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | file_data.push(FileData{file_name: file_name.clone(), path: file.path(), ext: ext}); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________- help: try this: `if file_name.find(ext.from).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = find_by_extention(&file_data, &ext) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 72 | | // println!("{} --- {}", ext.to, file_data[i].file_name); [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | println!("!!!!! {} is not found !!!!!! ", ext.from); [INFO] [stderr] 75 | | has_missing_file = true; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________- help: try this: `if find_by_extention(&file_data, &ext).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn find_by_extention( file_data: &Vec, ext: &GerberExtension) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[FileData]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(_) = file_name.find(ext.from) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 59 | | if let Some(pos) = find_by_extention(&file_data, &ext) { [INFO] [stderr] 60 | | println!("{} is already found! {}, {}", ext.from, file_data[pos].file_name, file_name); [INFO] [stderr] 61 | | return [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | file_data.push(FileData{file_name: file_name.clone(), path: file.path(), ext: ext}); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________- help: try this: `if file_name.find(ext.from).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = find_by_extention(&file_data, &ext) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 72 | | // println!("{} --- {}", ext.to, file_data[i].file_name); [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | println!("!!!!! {} is not found !!!!!! ", ext.from); [INFO] [stderr] 75 | | has_missing_file = true; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________- help: try this: `if find_by_extention(&file_data, &ext).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "78909f1de946ba7f95ea5f7f0a29cac2b74f59942fc87fbbb9f061ab72d67425"` [INFO] running `"docker" "rm" "-f" "78909f1de946ba7f95ea5f7f0a29cac2b74f59942fc87fbbb9f061ab72d67425"` [INFO] [stdout] 78909f1de946ba7f95ea5f7f0a29cac2b74f59942fc87fbbb9f061ab72d67425