[INFO] updating cached repository hpurmann/hangman-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hpurmann/hangman-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hpurmann/hangman-rust" "work/ex/clippy-test-run/sources/stable/gh/hpurmann/hangman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hpurmann/hangman-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hpurmann/hangman-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hpurmann/hangman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hpurmann/hangman-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4fd15f06630178a23d2a0691ceafd5531f8e3b70 [INFO] sha for GitHub repo hpurmann/hangman-rust: 4fd15f06630178a23d2a0691ceafd5531f8e3b70 [INFO] validating manifest of hpurmann/hangman-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hpurmann/hangman-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hpurmann/hangman-rust [INFO] finished frobbing hpurmann/hangman-rust [INFO] frobbed toml for hpurmann/hangman-rust written to work/ex/clippy-test-run/sources/stable/gh/hpurmann/hangman-rust/Cargo.toml [INFO] started frobbing hpurmann/hangman-rust [INFO] finished frobbing hpurmann/hangman-rust [INFO] frobbed toml for hpurmann/hangman-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hpurmann/hangman-rust/Cargo.toml [INFO] crate hpurmann/hangman-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hpurmann/hangman-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hpurmann/hangman-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69e826c9d09fc5869476dc9dee3713200e8865007fb63163422cecb8799e75d8 [INFO] running `"docker" "start" "-a" "69e826c9d09fc5869476dc9dee3713200e8865007fb63163422cecb8799e75d8"` [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking dtoa v0.4.0 [INFO] [stderr] Checking itoa v0.3.0 [INFO] [stderr] Checking serde v0.9.5 [INFO] [stderr] Compiling serde_codegen_internals v0.12.1 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling serde_derive v0.9.5 [INFO] [stderr] Checking term v0.2.14 [INFO] [stderr] Compiling unicase v1.4.0 [INFO] [stderr] Compiling hyper v0.10.4 [INFO] [stderr] Checking spinner v0.4.0 [INFO] [stderr] Checking serde_json v0.9.4 [INFO] [stderr] Checking hangman-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/words.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return solution; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `solution` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return gap_word; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gap_word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/words.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return solution; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `solution` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return gap_word; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gap_word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/words.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | static_answers.get(offset as usize).unwrap().to_uppercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `static_answers[offset as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_gap_word(solution: &String, guessed_chars: &HashSet) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/words.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | static_answers.get(offset as usize).unwrap().to_uppercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `static_answers[offset as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_gap_word(solution: &String, guessed_chars: &HashSet) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.06s [INFO] running `"docker" "inspect" "69e826c9d09fc5869476dc9dee3713200e8865007fb63163422cecb8799e75d8"` [INFO] running `"docker" "rm" "-f" "69e826c9d09fc5869476dc9dee3713200e8865007fb63163422cecb8799e75d8"` [INFO] [stdout] 69e826c9d09fc5869476dc9dee3713200e8865007fb63163422cecb8799e75d8