[INFO] updating cached repository howeih/Day-43-Shuffle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-43-Shuffle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-43-Shuffle" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-43-Shuffle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-43-Shuffle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-43-Shuffle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-43-Shuffle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-43-Shuffle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d5bc8a2cd7b835833e18dee84bd06e6a0bdbea4 [INFO] sha for GitHub repo howeih/Day-43-Shuffle: 1d5bc8a2cd7b835833e18dee84bd06e6a0bdbea4 [INFO] validating manifest of howeih/Day-43-Shuffle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-43-Shuffle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-43-Shuffle [INFO] finished frobbing howeih/Day-43-Shuffle [INFO] frobbed toml for howeih/Day-43-Shuffle written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-43-Shuffle/Cargo.toml [INFO] started frobbing howeih/Day-43-Shuffle [INFO] finished frobbing howeih/Day-43-Shuffle [INFO] frobbed toml for howeih/Day-43-Shuffle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-43-Shuffle/Cargo.toml [INFO] crate howeih/Day-43-Shuffle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-43-Shuffle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-43-Shuffle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3443a7657722dd50013da1f813805b894ec7fdf1001ab95f1906c98dcc996628 [INFO] running `"docker" "start" "-a" "3443a7657722dd50013da1f813805b894ec7fdf1001ab95f1906c98dcc996628"` [INFO] [stderr] Checking shuffle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are swapping elements of `data` manually [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / let temp = data[k]; [INFO] [stderr] 11 | | data[k] = data[i]; [INFO] [stderr] 12 | | data[i] = temp; [INFO] [stderr] | |______________________^ help: try: `data.swap(k, i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `data` manually [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / let temp = data[k]; [INFO] [stderr] 11 | | data[k] = data[i]; [INFO] [stderr] 12 | | data[i] = temp; [INFO] [stderr] | |______________________^ help: try: `data.swap(k, i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "3443a7657722dd50013da1f813805b894ec7fdf1001ab95f1906c98dcc996628"` [INFO] running `"docker" "rm" "-f" "3443a7657722dd50013da1f813805b894ec7fdf1001ab95f1906c98dcc996628"` [INFO] [stdout] 3443a7657722dd50013da1f813805b894ec7fdf1001ab95f1906c98dcc996628