[INFO] updating cached repository howeih/Day-40-Counting-Ones
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/howeih/Day-40-Counting-Ones
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-40-Counting-Ones" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-40-Counting-Ones"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-40-Counting-Ones'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-40-Counting-Ones" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-40-Counting-Ones"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-40-Counting-Ones'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 275a9e732b1050d6eed6dd652f8bcdbd08baaf3c
[INFO] sha for GitHub repo howeih/Day-40-Counting-Ones: 275a9e732b1050d6eed6dd652f8bcdbd08baaf3c
[INFO] validating manifest of howeih/Day-40-Counting-Ones on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of howeih/Day-40-Counting-Ones on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing howeih/Day-40-Counting-Ones
[INFO] finished frobbing howeih/Day-40-Counting-Ones
[INFO] frobbed toml for howeih/Day-40-Counting-Ones written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-40-Counting-Ones/Cargo.toml
[INFO] started frobbing howeih/Day-40-Counting-Ones
[INFO] finished frobbing howeih/Day-40-Counting-Ones
[INFO] frobbed toml for howeih/Day-40-Counting-Ones written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-40-Counting-Ones/Cargo.toml
[INFO] crate howeih/Day-40-Counting-Ones has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting howeih/Day-40-Counting-Ones against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-40-Counting-Ones:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8fe7794e9d92ef521665a44715239b2b5c13a681c052494e80f9d42f472e66bb
[INFO] running `"docker" "start" "-a" "8fe7794e9d92ef521665a44715239b2b5c13a681c052494e80f9d42f472e66bb"`
[INFO] [stderr]     Checking counting_ones v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     z
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let z = thread::spawn(move || loop {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 21 | |         match rx.recv() {
[INFO] [stderr] 22 | |             Ok(v) => match v {
[INFO] [stderr] 23 | |                 Data::Code(code) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:20:35
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let z = thread::spawn(move || loop {
[INFO] [stderr]    |  ___________________________________^
[INFO] [stderr] 21 | |         match rx.recv() {
[INFO] [stderr] 22 | |             Ok(v) => match v {
[INFO] [stderr] 23 | |                 Data::Code(code) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     });
[INFO] [stderr]    | |_____^ help: try: `while let Ok(v) = rx.recv() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:27:31
[INFO] [stderr]    |
[INFO] [stderr] 27 |                         while bucket.get(&key).unwrap().len() == 3 {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[&key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/main.rs:28:29
[INFO] [stderr]    |
[INFO] [stderr] 28 | /                             if !bucket.contains_key(&key) {
[INFO] [stderr] 29 | |                                 bucket.insert(key, Vec::<i32>::new());
[INFO] [stderr] 30 | |                             }
[INFO] [stderr]    | |_____________________________^ help: consider using: `bucket.entry(key).or_insert(Vec::<i32>::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/main.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 | /                             if !bucket.contains_key(&next_key) {
[INFO] [stderr] 33 | |                                 bucket.insert(next_key, Vec::<i32>::new());
[INFO] [stderr] 34 | |                             }
[INFO] [stderr]    | |_____________________________^ help: consider using: `bucket.entry(next_key).or_insert(Vec::<i32>::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |                             let val = bucket.get(&key).unwrap()[1];
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[&key]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |                         for t in bucket.get(i).unwrap() {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:55:21
[INFO] [stderr]    |
[INFO] [stderr] 55 | /                     match counts.iter().last() {
[INFO] [stderr] 56 | |                         Some(s) => {
[INFO] [stderr] 57 | |                             c = s / 2;
[INFO] [stderr] 58 | |                         }
[INFO] [stderr] 59 | |                         None => {}
[INFO] [stderr] 60 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 55 |                     if let Some(s) = counts.iter().last() {
[INFO] [stderr] 56 |     c = s / 2;
[INFO] [stderr] 57 | }
[INFO] [stderr]    |
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     z
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let z = thread::spawn(move || loop {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 21 | |         match rx.recv() {
[INFO] [stderr] 22 | |             Ok(v) => match v {
[INFO] [stderr] 23 | |                 Data::Code(code) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:83:21
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let k = n as f64 * (start - i as f64 * 0.99 / 4.);
[INFO] [stderr]    |                     ^^^^^^^^ help: try: `f64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:83:41
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let k = n as f64 * (start - i as f64 * 0.99 / 4.);
[INFO] [stderr]    |                                         ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:20:35
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let z = thread::spawn(move || loop {
[INFO] [stderr]    |  ___________________________________^
[INFO] [stderr] 21 | |         match rx.recv() {
[INFO] [stderr] 22 | |             Ok(v) => match v {
[INFO] [stderr] 23 | |                 Data::Code(code) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     });
[INFO] [stderr]    | |_____^ help: try: `while let Ok(v) = rx.recv() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:27:31
[INFO] [stderr]    |
[INFO] [stderr] 27 |                         while bucket.get(&key).unwrap().len() == 3 {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[&key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/main.rs:28:29
[INFO] [stderr]    |
[INFO] [stderr] 28 | /                             if !bucket.contains_key(&key) {
[INFO] [stderr] 29 | |                                 bucket.insert(key, Vec::<i32>::new());
[INFO] [stderr] 30 | |                             }
[INFO] [stderr]    | |_____________________________^ help: consider using: `bucket.entry(key).or_insert(Vec::<i32>::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/main.rs:32:29
[INFO] [stderr]    |
[INFO] [stderr] 32 | /                             if !bucket.contains_key(&next_key) {
[INFO] [stderr] 33 | |                                 bucket.insert(next_key, Vec::<i32>::new());
[INFO] [stderr] 34 | |                             }
[INFO] [stderr]    | |_____________________________^ help: consider using: `bucket.entry(next_key).or_insert(Vec::<i32>::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |                             let val = bucket.get(&key).unwrap()[1];
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[&key]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |                         for t in bucket.get(i).unwrap() {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&bucket[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:55:21
[INFO] [stderr]    |
[INFO] [stderr] 55 | /                     match counts.iter().last() {
[INFO] [stderr] 56 | |                         Some(s) => {
[INFO] [stderr] 57 | |                             c = s / 2;
[INFO] [stderr] 58 | |                         }
[INFO] [stderr] 59 | |                         None => {}
[INFO] [stderr] 60 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 55 |                     if let Some(s) = counts.iter().last() {
[INFO] [stderr] 56 |     c = s / 2;
[INFO] [stderr] 57 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:83:21
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let k = n as f64 * (start - i as f64 * 0.99 / 4.);
[INFO] [stderr]    |                     ^^^^^^^^ help: try: `f64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:83:41
[INFO] [stderr]    |
[INFO] [stderr] 83 |             let k = n as f64 * (start - i as f64 * 0.99 / 4.);
[INFO] [stderr]    |                                         ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.59s
[INFO] running `"docker" "inspect" "8fe7794e9d92ef521665a44715239b2b5c13a681c052494e80f9d42f472e66bb"`
[INFO] running `"docker" "rm" "-f" "8fe7794e9d92ef521665a44715239b2b5c13a681c052494e80f9d42f472e66bb"`
[INFO] [stdout] 8fe7794e9d92ef521665a44715239b2b5c13a681c052494e80f9d42f472e66bb