[INFO] updating cached repository howeih/Day-31-Z-algorithm
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/howeih/Day-31-Z-algorithm
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-31-Z-algorithm" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-31-Z-algorithm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-31-Z-algorithm'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-31-Z-algorithm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-31-Z-algorithm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-31-Z-algorithm'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5fa486b383854864c1be38e93f1bbe10f97d2b2f
[INFO] sha for GitHub repo howeih/Day-31-Z-algorithm: 5fa486b383854864c1be38e93f1bbe10f97d2b2f
[INFO] validating manifest of howeih/Day-31-Z-algorithm on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of howeih/Day-31-Z-algorithm on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing howeih/Day-31-Z-algorithm
[INFO] finished frobbing howeih/Day-31-Z-algorithm
[INFO] frobbed toml for howeih/Day-31-Z-algorithm written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-31-Z-algorithm/Cargo.toml
[INFO] started frobbing howeih/Day-31-Z-algorithm
[INFO] finished frobbing howeih/Day-31-Z-algorithm
[INFO] frobbed toml for howeih/Day-31-Z-algorithm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-31-Z-algorithm/Cargo.toml
[INFO] crate howeih/Day-31-Z-algorithm has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting howeih/Day-31-Z-algorithm against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-31-Z-algorithm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7988f4b47bce2b59b57fda546cb9d36ca899ce123cef8b1d6c455b561b85f980
[INFO] running `"docker" "start" "-a" "7988f4b47bce2b59b57fda546cb9d36ca899ce123cef8b1d6c455b561b85f980"`
[INFO] [stderr]     Checking z_algo v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/main.rs:7:13
[INFO] [stderr]   |
[INFO] [stderr] 7 |         Z { target: target }
[INFO] [stderr]   |             ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/main.rs:7:13
[INFO] [stderr]   |
[INFO] [stderr] 7 |         Z { target: target }
[INFO] [stderr]   |             ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:10:55
[INFO] [stderr]    |
[INFO] [stderr] 10 |     fn find_match(&self, pattern_len: usize, z_array: &Vec<u32>) -> Vec<usize>{
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `zi` is used to index `z_array`
[INFO] [stderr]   --> src/main.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for zi in pattern_len+1.. z_array.len()-1 {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for (zi, <item>) in z_array.iter().enumerate().take(z_array.len()-1).skip(pattern_len+1) {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn find_z_array(&self, target: &Vec<char>) -> Vec<u32> {
[INFO] [stderr]    |                                    ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `ti` is used to index `z_array`
[INFO] [stderr]   --> src/main.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for ti in 1..t_len {
[INFO] [stderr]    |                   ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for (ti, <item>) in z_array.iter_mut().enumerate().take(t_len).skip(1) {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:10:55
[INFO] [stderr]    |
[INFO] [stderr] 10 |     fn find_match(&self, pattern_len: usize, z_array: &Vec<u32>) -> Vec<usize>{
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: change this to: `&[u32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `zi` is used to index `z_array`
[INFO] [stderr]   --> src/main.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for zi in pattern_len+1.. z_array.len()-1 {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for (zi, <item>) in z_array.iter().enumerate().take(z_array.len()-1).skip(pattern_len+1) {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |     fn find_z_array(&self, target: &Vec<char>) -> Vec<u32> {
[INFO] [stderr]    |                                    ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `ti` is used to index `z_array`
[INFO] [stderr]   --> src/main.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for ti in 1..t_len {
[INFO] [stderr]    |                   ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for (ti, <item>) in z_array.iter_mut().enumerate().take(t_len).skip(1) {
[INFO] [stderr]    |             ^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.72s
[INFO] running `"docker" "inspect" "7988f4b47bce2b59b57fda546cb9d36ca899ce123cef8b1d6c455b561b85f980"`
[INFO] running `"docker" "rm" "-f" "7988f4b47bce2b59b57fda546cb9d36ca899ce123cef8b1d6c455b561b85f980"`
[INFO] [stdout] 7988f4b47bce2b59b57fda546cb9d36ca899ce123cef8b1d6c455b561b85f980