[INFO] updating cached repository howeih/Day-24-Closest-pair-of-points [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-24-Closest-pair-of-points [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-24-Closest-pair-of-points" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-24-Closest-pair-of-points"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-24-Closest-pair-of-points'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-24-Closest-pair-of-points" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-24-Closest-pair-of-points"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-24-Closest-pair-of-points'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 49da6a715624978377ecd538f8d85837c693d6ae [INFO] sha for GitHub repo howeih/Day-24-Closest-pair-of-points: 49da6a715624978377ecd538f8d85837c693d6ae [INFO] validating manifest of howeih/Day-24-Closest-pair-of-points on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-24-Closest-pair-of-points on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-24-Closest-pair-of-points [INFO] finished frobbing howeih/Day-24-Closest-pair-of-points [INFO] frobbed toml for howeih/Day-24-Closest-pair-of-points written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-24-Closest-pair-of-points/Cargo.toml [INFO] started frobbing howeih/Day-24-Closest-pair-of-points [INFO] finished frobbing howeih/Day-24-Closest-pair-of-points [INFO] frobbed toml for howeih/Day-24-Closest-pair-of-points written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-24-Closest-pair-of-points/Cargo.toml [INFO] crate howeih/Day-24-Closest-pair-of-points has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-24-Closest-pair-of-points against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-24-Closest-pair-of-points:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2673c7ac632596adc11f74b535947563894b686998663f79e21ccc0fbba8ee0 [INFO] running `"docker" "start" "-a" "a2673c7ac632596adc11f74b535947563894b686998663f79e21ccc0fbba8ee0"` [INFO] [stderr] Checking closet_pair v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.414_213_562_373_095_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn search(points: &Vec, left: usize, length: usize) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | Some(p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.414_213_562_373_095_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `closet_pair`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn search(points: &Vec, left: usize, length: usize) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | Some(p.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::SQRT_2` found. Consider using it directly [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(1.4142135623730951, closet_pair(&mut points)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `closet_pair`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a2673c7ac632596adc11f74b535947563894b686998663f79e21ccc0fbba8ee0"` [INFO] running `"docker" "rm" "-f" "a2673c7ac632596adc11f74b535947563894b686998663f79e21ccc0fbba8ee0"` [INFO] [stdout] a2673c7ac632596adc11f74b535947563894b686998663f79e21ccc0fbba8ee0