[INFO] updating cached repository howeih/Day-17-Perceptron [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-17-Perceptron [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-17-Perceptron" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-17-Perceptron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-17-Perceptron'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-17-Perceptron" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-17-Perceptron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-17-Perceptron'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53d4c0593b6cceda67b0271785dcd3e43c988abc [INFO] sha for GitHub repo howeih/Day-17-Perceptron: 53d4c0593b6cceda67b0271785dcd3e43c988abc [INFO] validating manifest of howeih/Day-17-Perceptron on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-17-Perceptron on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-17-Perceptron [INFO] finished frobbing howeih/Day-17-Perceptron [INFO] frobbed toml for howeih/Day-17-Perceptron written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-17-Perceptron/Cargo.toml [INFO] started frobbing howeih/Day-17-Perceptron [INFO] finished frobbing howeih/Day-17-Perceptron [INFO] frobbed toml for howeih/Day-17-Perceptron written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-17-Perceptron/Cargo.toml [INFO] crate howeih/Day-17-Perceptron has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-17-Perceptron against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-17-Perceptron:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba5a43359d98b365b65c4d5debcb208c37eb77f260fda2e696a5d10734438638 [INFO] running `"docker" "start" "-a" "ba5a43359d98b365b65c4d5debcb208c37eb77f260fda2e696a5d10734438638"` [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking ndarray v0.11.2 [INFO] [stderr] Checking perceptron v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let h = perceptron(&xr.to_owned(), &w.to_owned()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let h = perceptron(&xr.to_owned(), &w.to_owned()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in x.genrows().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | for xr in x.genrows() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if h != y[i] { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(h - y[i]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if h != y[i] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let pos; [INFO] [stderr] 35 | | if y[i] == 1.0 { [INFO] [stderr] 36 | | pos = w.to_owned() + xr.to_owned(); // xr+w; [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | pos = w.to_owned() - xr.to_owned(); // xr+w; [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let pos = if y[i] == 1.0 { w.to_owned() + xr.to_owned() } else { w.to_owned() - xr.to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | if y[i] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(y[i] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | if y[i] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if h == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(h - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if h == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `perceptron`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in x.genrows().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | for xr in x.genrows() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if h != y[i] { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(h - y[i]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if h != y[i] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let pos; [INFO] [stderr] 35 | | if y[i] == 1.0 { [INFO] [stderr] 36 | | pos = w.to_owned() + xr.to_owned(); // xr+w; [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | pos = w.to_owned() - xr.to_owned(); // xr+w; [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let pos = if y[i] == 1.0 { w.to_owned() + xr.to_owned() } else { w.to_owned() - xr.to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | if y[i] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(y[i] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | if y[i] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if h == y { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(h - y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if h == y { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `perceptron`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ba5a43359d98b365b65c4d5debcb208c37eb77f260fda2e696a5d10734438638"` [INFO] running `"docker" "rm" "-f" "ba5a43359d98b365b65c4d5debcb208c37eb77f260fda2e696a5d10734438638"` [INFO] [stdout] ba5a43359d98b365b65c4d5debcb208c37eb77f260fda2e696a5d10734438638