[INFO] updating cached repository howeih/Day-16-Breaking-OTP [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/howeih/Day-16-Breaking-OTP [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-16-Breaking-OTP" "work/ex/clippy-test-run/sources/stable/gh/howeih/Day-16-Breaking-OTP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/howeih/Day-16-Breaking-OTP'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/howeih/Day-16-Breaking-OTP" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-16-Breaking-OTP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-16-Breaking-OTP'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88ecf20c196a727418900c85bc3f41c3bcb4688b [INFO] sha for GitHub repo howeih/Day-16-Breaking-OTP: 88ecf20c196a727418900c85bc3f41c3bcb4688b [INFO] validating manifest of howeih/Day-16-Breaking-OTP on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howeih/Day-16-Breaking-OTP on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howeih/Day-16-Breaking-OTP [INFO] finished frobbing howeih/Day-16-Breaking-OTP [INFO] frobbed toml for howeih/Day-16-Breaking-OTP written to work/ex/clippy-test-run/sources/stable/gh/howeih/Day-16-Breaking-OTP/Cargo.toml [INFO] started frobbing howeih/Day-16-Breaking-OTP [INFO] finished frobbing howeih/Day-16-Breaking-OTP [INFO] frobbed toml for howeih/Day-16-Breaking-OTP written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/howeih/Day-16-Breaking-OTP/Cargo.toml [INFO] crate howeih/Day-16-Breaking-OTP has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howeih/Day-16-Breaking-OTP against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/howeih/Day-16-Breaking-OTP:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3250bb6b5cebec114d3e33af0d12a0e6002094a1954c706430f87413cca12c1f [INFO] running `"docker" "start" "-a" "3250bb6b5cebec114d3e33af0d12a0e6002094a1954c706430f87413cca12c1f"` [INFO] [stderr] Checking breaking_OTP v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `breaking_OTP` should have a snake case name such as `breaking_otp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut key: Option<&u8> = None; [INFO] [stderr] 86 | | if keyvec.len() == 1 { [INFO] [stderr] 87 | | key = Some(keyvec.pop().unwrap()); [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let key = if keyvec.len() == 1 { Some(keyvec.pop().unwrap()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: crate `breaking_OTP` should have a snake case name such as `breaking_otp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut key: Option<&u8> = None; [INFO] [stderr] 86 | | if keyvec.len() == 1 { [INFO] [stderr] 87 | | key = Some(keyvec.pop().unwrap()); [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let key = if keyvec.len() == 1 { Some(keyvec.pop().unwrap()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `"docker" "inspect" "3250bb6b5cebec114d3e33af0d12a0e6002094a1954c706430f87413cca12c1f"` [INFO] running `"docker" "rm" "-f" "3250bb6b5cebec114d3e33af0d12a0e6002094a1954c706430f87413cca12c1f"` [INFO] [stdout] 3250bb6b5cebec114d3e33af0d12a0e6002094a1954c706430f87413cca12c1f