[INFO] updating cached repository horizon-research/rust-vros-simulate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/horizon-research/rust-vros-simulate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/horizon-research/rust-vros-simulate" "work/ex/clippy-test-run/sources/stable/gh/horizon-research/rust-vros-simulate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/horizon-research/rust-vros-simulate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/horizon-research/rust-vros-simulate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/horizon-research/rust-vros-simulate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/horizon-research/rust-vros-simulate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c7dd55d3a5f4f31606a6870cf52efb672b2a4cd [INFO] sha for GitHub repo horizon-research/rust-vros-simulate: 7c7dd55d3a5f4f31606a6870cf52efb672b2a4cd [INFO] validating manifest of horizon-research/rust-vros-simulate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of horizon-research/rust-vros-simulate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing horizon-research/rust-vros-simulate [INFO] finished frobbing horizon-research/rust-vros-simulate [INFO] frobbed toml for horizon-research/rust-vros-simulate written to work/ex/clippy-test-run/sources/stable/gh/horizon-research/rust-vros-simulate/Cargo.toml [INFO] started frobbing horizon-research/rust-vros-simulate [INFO] finished frobbing horizon-research/rust-vros-simulate [INFO] frobbed toml for horizon-research/rust-vros-simulate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/horizon-research/rust-vros-simulate/Cargo.toml [INFO] crate horizon-research/rust-vros-simulate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting horizon-research/rust-vros-simulate against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/horizon-research/rust-vros-simulate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ac4c5646042b6d0b482d3d82619107cda838bae40384df59157fcbc569401d3 [INFO] running `"docker" "start" "-a" "5ac4c5646042b6d0b482d3d82619107cda838bae40384df59157fcbc569401d3"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/src/main.rs [INFO] [stderr] warning: `panic` setting is ignored for `test` profile [INFO] [stderr] Checking vros-simulate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `Level` [INFO] [stderr] --> src/simulator.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / enum CacheLevel { [INFO] [stderr] 16 | | LevelOne, [INFO] [stderr] 17 | | LevelTwo, [INFO] [stderr] 18 | | LevelThree, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ds.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return ratio; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ratio` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Level` [INFO] [stderr] --> src/simulator.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / enum CacheLevel { [INFO] [stderr] 16 | | LevelOne, [INFO] [stderr] 17 | | LevelTwo, [INFO] [stderr] 18 | | LevelThree, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ds.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return ratio; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ratio` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t_2` [INFO] [stderr] --> src/ds.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | let t_2 = Viewport::create_new_with_size(&t_1, 2000, 2000); [INFO] [stderr] | ^^^ help: consider using `_t_2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:70 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/simulator.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] 79 | | segment: usize, fov_width: usize, fov_height: usize, level_two_width: usize, [INFO] [stderr] 80 | | level_two_height: usize, power_constant_1080p_360: Vec, [INFO] [stderr] 81 | | power_constant_1080p: Vec, opt_flag: bool) -> Self { [INFO] [stderr] ... | [INFO] [stderr] 109 | | sim [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | let id_vec: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | let coord: Vec<&str> = id_vec[2].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:176:52 [INFO] [stderr] | [INFO] [stderr] 176 | let line_split: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:180:58 [INFO] [stderr] | [INFO] [stderr] 180 | let extract: Vec<&str> = line_split[2].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/simulator.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if self.fov_width == self.level_two_width && self.fov_height == self.level_two_height { [INFO] [stderr] 261 | | false [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | true [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(self.fov_width == self.level_two_width && self.fov_height == self.level_two_height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simulator.rs:343:44 [INFO] [stderr] | [INFO] [stderr] 343 | self.hit_list_for_soc.push(hit_soc_cache_pair.0.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hit_soc_cache_pair.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/simulator.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | / match hit_soc_cache_pair.1 { [INFO] [stderr] 349 | | CacheLevel::LevelThree => self.segment_resend_counter += 1, [INFO] [stderr] 350 | | _ => () [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________^ help: try this: `if let CacheLevel::LevelThree = hit_soc_cache_pair.1 { self.segment_resend_counter += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:437:56 [INFO] [stderr] | [INFO] [stderr] 437 | let temp_name: &str = self.user_file.split("/").collect::>()[1]; [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:438:29 [INFO] [stderr] | [INFO] [stderr] 438 | temp_name.split("-").collect::>()[0] [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/simulator.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/simulator.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/simulator.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/simulator.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ds.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | x = constants::FULL_SIZE_WIDTH_I32 + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x += constants::FULL_SIZE_WIDTH_I32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ds.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let ratio: f64 = (total_x * total_y) as f64 / (user_fov.width * user_fov.height) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_x * total_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ds.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn new(index: i32, traces: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 122 | pub fn new(index: i32, traces: &[Viewport]) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `traces.clone()` to [INFO] [stderr] | [INFO] [stderr] 123 | let t = traces.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:63 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:86 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:51 [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &[PowerConstants], power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 46 | power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 52 | fov_height, power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 58 | level_two_width, level_two_height, power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:95 [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &[PowerConstants]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | power_constant_1080p.to_owned(), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 53 | power_constant_1080p.to_owned(), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 59 | power_constant_1080p.to_owned(), true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/main.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] 35 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 36 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 37 | | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:67:35 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:67:85 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:70:47 [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &[PowerConstants], power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 82 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 86 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:70:91 [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &[PowerConstants], opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 83 | power_constant_1080p.to_owned(), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 87 | power_constant_1080p.to_owned(), true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] 68 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 69 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 70 | | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] ... | [INFO] [stderr] 113 | | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | hit_ratios.0 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | hit_ratios.1 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | hit_ratios.2 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | no_resend_segment_rate /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:51 [INFO] [stderr] | [INFO] [stderr] 113 | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:78 [INFO] [stderr] | [INFO] [stderr] 113 | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:63 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:86 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &[PowerConstants], power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 128 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 132 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:119:92 [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &[PowerConstants], opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 129 | power_constant_1080p.to_owned(), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 133 | power_constant_1080p.to_owned(), true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | / fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] 117 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 118 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 119 | | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] ... | [INFO] [stderr] 148 | | println!("{} {} {} {}", hit_ratios.0, hit_ratios.1, hit_ratios.2, threshold); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | hit_ratios.0 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | hit_ratios.1 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | hit_ratios.2 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/simulator.rs:78:70 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/simulator.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new(user_file: &String, dump_file: &String, cluster_json: &String, threshold: f64, [INFO] [stderr] 79 | | segment: usize, fov_width: usize, fov_height: usize, level_two_width: usize, [INFO] [stderr] 80 | | level_two_height: usize, power_constant_1080p_360: Vec, [INFO] [stderr] 81 | | power_constant_1080p: Vec, opt_flag: bool) -> Self { [INFO] [stderr] ... | [INFO] [stderr] 109 | | sim [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: Could not compile `vros-simulate`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | let id_vec: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | let coord: Vec<&str> = id_vec[2].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:176:52 [INFO] [stderr] | [INFO] [stderr] 176 | let line_split: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:180:58 [INFO] [stderr] | [INFO] [stderr] 180 | let extract: Vec<&str> = line_split[2].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/simulator.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if self.fov_width == self.level_two_width && self.fov_height == self.level_two_height { [INFO] [stderr] 261 | | false [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | true [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `!(self.fov_width == self.level_two_width && self.fov_height == self.level_two_height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/simulator.rs:343:44 [INFO] [stderr] | [INFO] [stderr] 343 | self.hit_list_for_soc.push(hit_soc_cache_pair.0.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hit_soc_cache_pair.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/simulator.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | / match hit_soc_cache_pair.1 { [INFO] [stderr] 349 | | CacheLevel::LevelThree => self.segment_resend_counter += 1, [INFO] [stderr] 350 | | _ => () [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________^ help: try this: `if let CacheLevel::LevelThree = hit_soc_cache_pair.1 { self.segment_resend_counter += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:437:56 [INFO] [stderr] | [INFO] [stderr] 437 | let temp_name: &str = self.user_file.split("/").collect::>()[1]; [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/simulator.rs:438:29 [INFO] [stderr] | [INFO] [stderr] 438 | temp_name.split("-").collect::>()[0] [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/simulator.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/simulator.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/simulator.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/simulator.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert_eq!(cache_hit_ratios[1], 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ds.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | x = constants::FULL_SIZE_WIDTH_I32 + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x += constants::FULL_SIZE_WIDTH_I32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ds.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | let ratio: f64 = (total_x * total_y) as f64 / (user_fov.width * user_fov.height) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_x * total_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ds.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn new(index: i32, traces: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 122 | pub fn new(index: i32, traces: &[Viewport]) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `traces.clone()` to [INFO] [stderr] | [INFO] [stderr] 123 | let t = traces.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:63 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:34:86 [INFO] [stderr] | [INFO] [stderr] 34 | fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:51 [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &[PowerConstants], power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 46 | power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 52 | fov_height, power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 58 | level_two_width, level_two_height, power_constant_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:37:95 [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 37 | power_constant_4k_360: &Vec, power_constant_1080p: &[PowerConstants]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | power_constant_1080p.to_owned(), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 53 | power_constant_1080p.to_owned(), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 59 | power_constant_1080p.to_owned(), true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/main.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / fn compare_each_simulation(object_result: &String, dump_file: &String, cluster_json: &String, [INFO] [stderr] 35 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 36 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 37 | | power_constant_4k_360: &Vec, power_constant_1080p: &Vec) { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:67:35 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:67:85 [INFO] [stderr] | [INFO] [stderr] 67 | fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:70:47 [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &[PowerConstants], power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 82 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 86 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:70:91 [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 70 | power_constants_4k_360: &Vec, power_constant_1080p: &[PowerConstants], opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 83 | power_constant_1080p.to_owned(), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 87 | power_constant_1080p.to_owned(), true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn single_simulate_pc(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] 68 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 69 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 70 | | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] ... | [INFO] [stderr] 113 | | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | hit_ratios.0 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | hit_ratios.1 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | hit_ratios.2 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | no_resend_segment_rate /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:51 [INFO] [stderr] | [INFO] [stderr] 113 | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:78 [INFO] [stderr] | [INFO] [stderr] 113 | println!("{} {} {} {} {} {} {}", pc_tuple.0 / count as f64, pc_tuple.1 / count as f64, threshold, hit_ratios.0, hit_ratios.1, hit_ratios.2, no_resend_segment_rate); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:63 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:116:86 [INFO] [stderr] | [INFO] [stderr] 116 | fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &[PowerConstants], power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 128 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constants_4k_360.clone()` to [INFO] [stderr] | [INFO] [stderr] 132 | level_two_width, level_two_height, power_constants_4k_360.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:119:92 [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 119 | power_constants_4k_360: &Vec, power_constant_1080p: &[PowerConstants], opt: OptimizeVersion) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 129 | power_constant_1080p.to_owned(), false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `power_constant_1080p.clone()` to [INFO] [stderr] | [INFO] [stderr] 133 | power_constant_1080p.to_owned(), true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/main.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | / fn single_simulate_hit(user_paths: &Vec, dump_file: &String, cluster_json: &String, [INFO] [stderr] 117 | | threshold: f64, segment: usize, fov_width: usize, fov_height: usize, [INFO] [stderr] 118 | | level_two_width: usize, level_two_height: usize, [INFO] [stderr] 119 | | power_constants_4k_360: &Vec, power_constant_1080p: &Vec, opt: OptimizeVersion) { [INFO] [stderr] ... | [INFO] [stderr] 148 | | println!("{} {} {} {}", hit_ratios.0, hit_ratios.1, hit_ratios.2, threshold); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | hit_ratios.0 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | hit_ratios.1 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | hit_ratios.2 /= count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `vros-simulate`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5ac4c5646042b6d0b482d3d82619107cda838bae40384df59157fcbc569401d3"` [INFO] running `"docker" "rm" "-f" "5ac4c5646042b6d0b482d3d82619107cda838bae40384df59157fcbc569401d3"` [INFO] [stdout] 5ac4c5646042b6d0b482d3d82619107cda838bae40384df59157fcbc569401d3