[INFO] updating cached repository hoodie/peerchat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hoodie/peerchat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hoodie/peerchat" "work/ex/clippy-test-run/sources/stable/gh/hoodie/peerchat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hoodie/peerchat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hoodie/peerchat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hoodie/peerchat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hoodie/peerchat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6e21ac00fe3f41b321192d32d60964db24e016fe [INFO] sha for GitHub repo hoodie/peerchat: 6e21ac00fe3f41b321192d32d60964db24e016fe [INFO] validating manifest of hoodie/peerchat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hoodie/peerchat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hoodie/peerchat [INFO] finished frobbing hoodie/peerchat [INFO] frobbed toml for hoodie/peerchat written to work/ex/clippy-test-run/sources/stable/gh/hoodie/peerchat/Cargo.toml [INFO] started frobbing hoodie/peerchat [INFO] finished frobbing hoodie/peerchat [INFO] frobbed toml for hoodie/peerchat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hoodie/peerchat/Cargo.toml [INFO] crate hoodie/peerchat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hoodie/peerchat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hoodie/peerchat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb70eb0ea906a7687e569b8d10cd8e001d5e771dd9ddbeea47da442e4a37efe5 [INFO] running `"docker" "start" "-a" "fb70eb0ea906a7687e569b8d10cd8e001d5e771dd9ddbeea47da442e4a37efe5"` [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking peerchat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> examples/peerchat.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if let Ok(_) = io::stdin().read_line(&mut input) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 20 | | if let Some(input) = input.lines().nth(0){ [INFO] [stderr] 21 | | send_as(name, input) [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | break; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_line(&mut input).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the `msg @ _` pattern can be written as just `msg` [INFO] [stderr] --> examples/peerchat.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | msg @ _ => warn!("unhandled message: {:?}", msg) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg` [INFO] [stderr] --> examples/server.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | fn broadcast(msg: &str, receivers: &[SocketAddr]) { [INFO] [stderr] | ^^^ help: consider using `_msg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `receivers` [INFO] [stderr] --> examples/server.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | fn broadcast(msg: &str, receivers: &[SocketAddr]) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_receivers` instead [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> examples/minimal.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | if let Ok(_) = io::stdin().read_line(&mut input) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 19 | | if let Some(msg) = input.lines().nth(0){ [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | send_msg( [INFO] [stderr] ... | [INFO] [stderr] 30 | | break; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read_line(&mut input).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the `msg @ _` pattern can be written as just `msg` [INFO] [stderr] --> examples/minimal.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | msg @ _ => warn!("unhandled message: {:?}", msg) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: function is never used: `broadcast` [INFO] [stderr] --> examples/server.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn broadcast(msg: &str, receivers: &[SocketAddr]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the `msg @ _` pattern can be written as just `msg` [INFO] [stderr] --> examples/server.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | msg @ _ => warn!("unhandled message: {:?}", msg) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.83s [INFO] running `"docker" "inspect" "fb70eb0ea906a7687e569b8d10cd8e001d5e771dd9ddbeea47da442e4a37efe5"` [INFO] running `"docker" "rm" "-f" "fb70eb0ea906a7687e569b8d10cd8e001d5e771dd9ddbeea47da442e4a37efe5"` [INFO] [stdout] fb70eb0ea906a7687e569b8d10cd8e001d5e771dd9ddbeea47da442e4a37efe5