[INFO] updating cached repository hone/npmstats.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hone/npmstats.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hone/npmstats.rs" "work/ex/clippy-test-run/sources/stable/gh/hone/npmstats.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hone/npmstats.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hone/npmstats.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hone/npmstats.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hone/npmstats.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec580096cb0b0377373da23fa3747247a48b8267 [INFO] sha for GitHub repo hone/npmstats.rs: ec580096cb0b0377373da23fa3747247a48b8267 [INFO] validating manifest of hone/npmstats.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hone/npmstats.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hone/npmstats.rs [INFO] finished frobbing hone/npmstats.rs [INFO] frobbed toml for hone/npmstats.rs written to work/ex/clippy-test-run/sources/stable/gh/hone/npmstats.rs/Cargo.toml [INFO] started frobbing hone/npmstats.rs [INFO] finished frobbing hone/npmstats.rs [INFO] frobbed toml for hone/npmstats.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hone/npmstats.rs/Cargo.toml [INFO] crate hone/npmstats.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hone/npmstats.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hone/npmstats.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4659b74ce292f1dacb89559b86fdf0f565c9cfd8c113d4a691d38bb85712c79c [INFO] running `"docker" "start" "-a" "4659b74ce292f1dacb89559b86fdf0f565c9cfd8c113d4a691d38bb85712c79c"` [INFO] [stderr] Compiling openssl v0.9.19 [INFO] [stderr] Checking gnuplot v0.0.22 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Compiling openssl-sys v0.9.19 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking libflate v0.1.11 [INFO] [stderr] Checking futures-cpupool v0.1.6 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking mime v0.3.4 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking npmstats v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/options.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm_registry.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | const API_BASE: &'static str = "api.npmjs.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/options.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm_registry.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | const API_BASE: &'static str = "api.npmjs.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let mut axes2d = fg.axes2d() [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/npm_registry.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn downloads(&self, modules: &Vec) -> (Vec, HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/npm_registry.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | for year in 2015..today.year() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `2015..=today.year()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/npm_registry.rs:52:65 [INFO] [stderr] | [INFO] [stderr] 52 | let mut entry = downloads.entry(module).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/npm_registry.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | fn monthly_downloads(&self, modules: &Vec, month: u32, year: u32) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/npm_registry.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | for ref module in modules { [INFO] [stderr] | ^^^^^^^^^^ ------- help: try: `let module = &modules;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/npm_registry.rs:107:60 [INFO] [stderr] | [INFO] [stderr] 107 | NaiveDate::from_ymd_opt(year as i32, month + 1, 1).unwrap_or(NaiveDate::from_ymd(year as i32 + 1, 1, 1)).pred().day() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| NaiveDate::from_ymd(year as i32 + 1, 1, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | let parts: Vec<&str> = date.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the variable `color_index` is used as a loop counter. Consider using `for (color_index, item) in downloads.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | for (module, counts) in downloads { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let mut axes2d = fg.axes2d() [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/npm_registry.rs:40:38 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn downloads(&self, modules: &Vec) -> (Vec, HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/npm_registry.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | for year in 2015..today.year() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `2015..=today.year()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/npm_registry.rs:52:65 [INFO] [stderr] | [INFO] [stderr] 52 | let mut entry = downloads.entry(module).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/npm_registry.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | fn monthly_downloads(&self, modules: &Vec, month: u32, year: u32) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/npm_registry.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | for ref module in modules { [INFO] [stderr] | ^^^^^^^^^^ ------- help: try: `let module = &modules;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/npm_registry.rs:107:60 [INFO] [stderr] | [INFO] [stderr] 107 | NaiveDate::from_ymd_opt(year as i32, month + 1, 1).unwrap_or(NaiveDate::from_ymd(year as i32 + 1, 1, 1)).pred().day() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| NaiveDate::from_ymd(year as i32 + 1, 1, 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | let parts: Vec<&str> = date.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the variable `color_index` is used as a loop counter. Consider using `for (color_index, item) in downloads.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | for (module, counts) in downloads { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.38s [INFO] running `"docker" "inspect" "4659b74ce292f1dacb89559b86fdf0f565c9cfd8c113d4a691d38bb85712c79c"` [INFO] running `"docker" "rm" "-f" "4659b74ce292f1dacb89559b86fdf0f565c9cfd8c113d4a691d38bb85712c79c"` [INFO] [stdout] 4659b74ce292f1dacb89559b86fdf0f565c9cfd8c113d4a691d38bb85712c79c