[INFO] updating cached repository homeisfar/raytracerr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/homeisfar/raytracerr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/homeisfar/raytracerr" "work/ex/clippy-test-run/sources/stable/gh/homeisfar/raytracerr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/homeisfar/raytracerr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/homeisfar/raytracerr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/raytracerr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/raytracerr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7761da2a8cdd010acfa63c99112a2c2a8507ad41 [INFO] sha for GitHub repo homeisfar/raytracerr: 7761da2a8cdd010acfa63c99112a2c2a8507ad41 [INFO] validating manifest of homeisfar/raytracerr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of homeisfar/raytracerr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing homeisfar/raytracerr [INFO] finished frobbing homeisfar/raytracerr [INFO] frobbed toml for homeisfar/raytracerr written to work/ex/clippy-test-run/sources/stable/gh/homeisfar/raytracerr/Cargo.toml [INFO] started frobbing homeisfar/raytracerr [INFO] finished frobbing homeisfar/raytracerr [INFO] frobbed toml for homeisfar/raytracerr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/raytracerr/Cargo.toml [INFO] crate homeisfar/raytracerr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting homeisfar/raytracerr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/homeisfar/raytracerr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33d50f8adabd79c35695e9bf3f7143a3a2723038ebeabc5c0be127991bb45c8d [INFO] running `"docker" "start" "-a" "33d50f8adabd79c35695e9bf3f7143a3a2723038ebeabc5c0be127991bb45c8d"` [INFO] [stderr] Compiling num-traits v0.2.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Compiling num-derive v0.2.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking raytracerr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Add` [INFO] [stderr] --> src/scene_structs.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::{Add, Sub}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | scene [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let scene = Scene { [INFO] [stderr] | _________________^ [INFO] [stderr] 29 | | width: 800, [INFO] [stderr] 30 | | height: 200, [INFO] [stderr] 31 | | fov: 90.0, [INFO] [stderr] ... | [INFO] [stderr] 44 | | }, [INFO] [stderr] 45 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | let camera_sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | let camera_sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:100:40 [INFO] [stderr] | [INFO] [stderr] 100 | let camera_sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:100:58 [INFO] [stderr] | [INFO] [stderr] 100 | let camera_sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Add` [INFO] [stderr] --> src/scene_structs.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ops::{Add, Sub}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | scene [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | let scene = Scene { [INFO] [stderr] | _________________^ [INFO] [stderr] 29 | | width: 800, [INFO] [stderr] 30 | | height: 200, [INFO] [stderr] 31 | | fov: 90.0, [INFO] [stderr] ... | [INFO] [stderr] 44 | | }, [INFO] [stderr] 45 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | let camera_sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | let camera_sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:100:40 [INFO] [stderr] | [INFO] [stderr] 100 | let camera_sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_structs.rs:100:58 [INFO] [stderr] | [INFO] [stderr] 100 | let camera_sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.96s [INFO] running `"docker" "inspect" "33d50f8adabd79c35695e9bf3f7143a3a2723038ebeabc5c0be127991bb45c8d"` [INFO] running `"docker" "rm" "-f" "33d50f8adabd79c35695e9bf3f7143a3a2723038ebeabc5c0be127991bb45c8d"` [INFO] [stdout] 33d50f8adabd79c35695e9bf3f7143a3a2723038ebeabc5c0be127991bb45c8d