[INFO] updating cached repository homeisfar/lofi-rasterizerr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/homeisfar/lofi-rasterizerr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/homeisfar/lofi-rasterizerr" "work/ex/clippy-test-run/sources/stable/gh/homeisfar/lofi-rasterizerr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/homeisfar/lofi-rasterizerr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/homeisfar/lofi-rasterizerr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/lofi-rasterizerr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/lofi-rasterizerr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b793ae8ac33d8b4612349fa240622b135e61865 [INFO] sha for GitHub repo homeisfar/lofi-rasterizerr: 1b793ae8ac33d8b4612349fa240622b135e61865 [INFO] validating manifest of homeisfar/lofi-rasterizerr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of homeisfar/lofi-rasterizerr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing homeisfar/lofi-rasterizerr [INFO] finished frobbing homeisfar/lofi-rasterizerr [INFO] frobbed toml for homeisfar/lofi-rasterizerr written to work/ex/clippy-test-run/sources/stable/gh/homeisfar/lofi-rasterizerr/Cargo.toml [INFO] started frobbing homeisfar/lofi-rasterizerr [INFO] finished frobbing homeisfar/lofi-rasterizerr [INFO] frobbed toml for homeisfar/lofi-rasterizerr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/homeisfar/lofi-rasterizerr/Cargo.toml [INFO] crate homeisfar/lofi-rasterizerr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting homeisfar/lofi-rasterizerr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/homeisfar/lofi-rasterizerr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb9db1451727fa83bb89a726d7b4f5786430301b1528e92def0315854087ea0b [INFO] running `"docker" "start" "-a" "bb9db1451727fa83bb89a726d7b4f5786430301b1528e92def0315854087ea0b"` [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking lofi_rasterizerr v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/img_data.rs:16:44 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(r: u8, g: u8, b: u8, a: u8, l: u8) -> Pixel { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/img_data.rs:16:44 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(r: u8, g: u8, b: u8, a: u8, l: u8) -> Pixel { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ImageDetails` [INFO] [stderr] --> src/img_data.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct ImageDetails { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `BLACK` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | static BLACK: u8 = 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `WHITE` [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | static WHITE: u8 = 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `simpleThreshold` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static simpleThreshold: u8 = 127; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/img_data.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn to_luma(r: u8, g: u8, b: u8) -> u8 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ((r as f32) * 0.212) as u8 + [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | ((g as f32) * 0.715) as u8 + [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | ((b as f32) * 0.072) as u8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: static variable `simpleThreshold` should have an upper case name such as `SIMPLE_THRESHOLD` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static simpleThreshold: u8 = 127; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | (elapsed_time.as_secs() * 1_000) + (elapsed_time.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed_time.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | (elapsed_time.as_secs() * 1_000) + (elapsed_time.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed_time.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ImageDetails` [INFO] [stderr] --> src/img_data.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct ImageDetails { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `BLACK` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | static BLACK: u8 = 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `WHITE` [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | static WHITE: u8 = 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `simpleThreshold` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static simpleThreshold: u8 = 127; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/img_data.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn to_luma(r: u8, g: u8, b: u8) -> u8 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | ((r as f32) * 0.212) as u8 + [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | ((g as f32) * 0.715) as u8 + [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/img_data.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | ((b as f32) * 0.072) as u8 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: static variable `simpleThreshold` should have an upper case name such as `SIMPLE_THRESHOLD` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static simpleThreshold: u8 = 127; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | (elapsed_time.as_secs() * 1_000) + (elapsed_time.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed_time.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | (elapsed_time.as_secs() * 1_000) + (elapsed_time.subsec_nanos() / 1_000_000) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed_time.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.78s [INFO] running `"docker" "inspect" "bb9db1451727fa83bb89a726d7b4f5786430301b1528e92def0315854087ea0b"` [INFO] running `"docker" "rm" "-f" "bb9db1451727fa83bb89a726d7b4f5786430301b1528e92def0315854087ea0b"` [INFO] [stdout] bb9db1451727fa83bb89a726d7b4f5786430301b1528e92def0315854087ea0b