[INFO] updating cached repository holmandw/velg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/holmandw/velg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/holmandw/velg" "work/ex/clippy-test-run/sources/stable/gh/holmandw/velg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/holmandw/velg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/holmandw/velg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holmandw/velg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holmandw/velg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04aa12deea2a7f6cc814cbea001a587137ade9aa [INFO] sha for GitHub repo holmandw/velg: 04aa12deea2a7f6cc814cbea001a587137ade9aa [INFO] validating manifest of holmandw/velg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of holmandw/velg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing holmandw/velg [INFO] finished frobbing holmandw/velg [INFO] frobbed toml for holmandw/velg written to work/ex/clippy-test-run/sources/stable/gh/holmandw/velg/Cargo.toml [INFO] started frobbing holmandw/velg [INFO] finished frobbing holmandw/velg [INFO] frobbed toml for holmandw/velg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/holmandw/velg/Cargo.toml [INFO] crate holmandw/velg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting holmandw/velg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/holmandw/velg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 181781de3467c2c7763ed0a7f058168682dd0c176262b1b9395c0879be9aa6af [INFO] running `"docker" "start" "-a" "181781de3467c2c7763ed0a7f058168682dd0c176262b1b9395c0879be9aa6af"` [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking velg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match args.flag_all { [INFO] [stderr] 46 | | true => show_all(&values, n), [INFO] [stderr] 47 | | false => show_one(&values, n), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_all { show_all(&values, n) } else { show_one(&values, n) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match args.flag_all { [INFO] [stderr] 46 | | true => show_all(&values, n), [INFO] [stderr] 47 | | false => show_one(&values, n), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if args.flag_all { show_all(&values, n) } else { show_one(&values, n) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.41s [INFO] running `"docker" "inspect" "181781de3467c2c7763ed0a7f058168682dd0c176262b1b9395c0879be9aa6af"` [INFO] running `"docker" "rm" "-f" "181781de3467c2c7763ed0a7f058168682dd0c176262b1b9395c0879be9aa6af"` [INFO] [stdout] 181781de3467c2c7763ed0a7f058168682dd0c176262b1b9395c0879be9aa6af