[INFO] updating cached repository hockeybuggy/rust_pong [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hockeybuggy/rust_pong [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hockeybuggy/rust_pong" "work/ex/clippy-test-run/sources/stable/gh/hockeybuggy/rust_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hockeybuggy/rust_pong'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hockeybuggy/rust_pong" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hockeybuggy/rust_pong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hockeybuggy/rust_pong'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cb0429c90801a3e65cbff991f934e85e8a65244 [INFO] sha for GitHub repo hockeybuggy/rust_pong: 6cb0429c90801a3e65cbff991f934e85e8a65244 [INFO] validating manifest of hockeybuggy/rust_pong on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hockeybuggy/rust_pong on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hockeybuggy/rust_pong [INFO] finished frobbing hockeybuggy/rust_pong [INFO] frobbed toml for hockeybuggy/rust_pong written to work/ex/clippy-test-run/sources/stable/gh/hockeybuggy/rust_pong/Cargo.toml [INFO] started frobbing hockeybuggy/rust_pong [INFO] finished frobbing hockeybuggy/rust_pong [INFO] frobbed toml for hockeybuggy/rust_pong written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hockeybuggy/rust_pong/Cargo.toml [INFO] crate hockeybuggy/rust_pong has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hockeybuggy/rust_pong against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hockeybuggy/rust_pong:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96cf3b4e2861ac714cc3d424b25cb7ff7dd84255b3066854d9314c48834307ee [INFO] running `"docker" "start" "-a" "96cf3b4e2861ac714cc3d424b25cb7ff7dd84255b3066854d9314c48834307ee"` [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.1 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking glutin v0.8.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking rust_pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | ball: ball, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ball` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | left_paddle: left_paddle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_paddle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | right_paddle: right_paddle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_paddle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | ball: ball, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ball` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | left_paddle: left_paddle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_paddle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pong/game.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | right_paddle: right_paddle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_paddle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / return Ball { [INFO] [stderr] 38 | | x: 0.0, [INFO] [stderr] 39 | | y: 0.0, [INFO] [stderr] 40 | | size: 10.0, [INFO] [stderr] ... | [INFO] [stderr] 43 | | velocity_y: initial_velocity_y, [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | Ball { [INFO] [stderr] 38 | x: 0.0, [INFO] [stderr] 39 | y: 0.0, [INFO] [stderr] 40 | size: 10.0, [INFO] [stderr] 41 | [INFO] [stderr] 42 | velocity_x: initial_velocity_x, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.x > bounds.right; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x > bounds.right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.x < bounds.left; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x < bounds.left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return [self.x, self.y, radius]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x, self.y, radius]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/game.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return game; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Paddle { [INFO] [stderr] 22 | | x: -180.0, [INFO] [stderr] 23 | | y: 10.0, [INFO] [stderr] 24 | | dy: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 28 | | score: 0, [INFO] [stderr] 29 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Paddle { [INFO] [stderr] 22 | x: -180.0, [INFO] [stderr] 23 | y: 10.0, [INFO] [stderr] 24 | dy: 0.0, [INFO] [stderr] 25 | height: 100.0, [INFO] [stderr] 26 | width: 10.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return Paddle { [INFO] [stderr] 34 | | x: 180.0, [INFO] [stderr] 35 | | y: 10.0, [INFO] [stderr] 36 | | dy: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 40 | | score: 0, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Paddle { [INFO] [stderr] 34 | x: 180.0, [INFO] [stderr] 35 | y: 10.0, [INFO] [stderr] 36 | dy: 0.0, [INFO] [stderr] 37 | height: 100.0, [INFO] [stderr] 38 | width: 10.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return self.x - self.width / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x - self.width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return self.x + self.width / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x + self.width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return self.y - self.height / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y - self.height / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return self.y + self.height / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y + self.height / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return x >= self.left() && x < self.right() && y >= self.top() && y < self.bottom(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x >= self.left() && x < self.right() && y >= self.top() && y < self.bottom()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return rectangle::rectangle_by_corners( [INFO] [stderr] 103 | | self.left(), [INFO] [stderr] 104 | | self.top(), [INFO] [stderr] 105 | | self.right(), [INFO] [stderr] 106 | | self.bottom(), [INFO] [stderr] 107 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | rectangle::rectangle_by_corners( [INFO] [stderr] 103 | self.left(), [INFO] [stderr] 104 | self.top(), [INFO] [stderr] 105 | self.right(), [INFO] [stderr] 106 | self.bottom(), [INFO] [stderr] 107 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / return Ball { [INFO] [stderr] 38 | | x: 0.0, [INFO] [stderr] 39 | | y: 0.0, [INFO] [stderr] 40 | | size: 10.0, [INFO] [stderr] ... | [INFO] [stderr] 43 | | velocity_y: initial_velocity_y, [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | Ball { [INFO] [stderr] 38 | x: 0.0, [INFO] [stderr] 39 | y: 0.0, [INFO] [stderr] 40 | size: 10.0, [INFO] [stderr] 41 | [INFO] [stderr] 42 | velocity_x: initial_velocity_x, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return self.x > bounds.right; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x > bounds.right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return self.x < bounds.left; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x < bounds.left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/ball.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return [self.x, self.y, radius]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x, self.y, radius]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/game.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return game; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Paddle { [INFO] [stderr] 22 | | x: -180.0, [INFO] [stderr] 23 | | y: 10.0, [INFO] [stderr] 24 | | dy: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 28 | | score: 0, [INFO] [stderr] 29 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Paddle { [INFO] [stderr] 22 | x: -180.0, [INFO] [stderr] 23 | y: 10.0, [INFO] [stderr] 24 | dy: 0.0, [INFO] [stderr] 25 | height: 100.0, [INFO] [stderr] 26 | width: 10.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return Paddle { [INFO] [stderr] 34 | | x: 180.0, [INFO] [stderr] 35 | | y: 10.0, [INFO] [stderr] 36 | | dy: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 40 | | score: 0, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Paddle { [INFO] [stderr] 34 | x: 180.0, [INFO] [stderr] 35 | y: 10.0, [INFO] [stderr] 36 | dy: 0.0, [INFO] [stderr] 37 | height: 100.0, [INFO] [stderr] 38 | width: 10.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return self.x - self.width / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x - self.width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return self.x + self.width / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x + self.width / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return self.y - self.height / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y - self.height / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return self.y + self.height / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y + self.height / 2.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return x >= self.left() && x < self.right() && y >= self.top() && y < self.bottom(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x >= self.left() && x < self.right() && y >= self.top() && y < self.bottom()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pong/paddle.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return rectangle::rectangle_by_corners( [INFO] [stderr] 103 | | self.left(), [INFO] [stderr] 104 | | self.top(), [INFO] [stderr] 105 | | self.right(), [INFO] [stderr] 106 | | self.bottom(), [INFO] [stderr] 107 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | rectangle::rectangle_by_corners( [INFO] [stderr] 103 | self.left(), [INFO] [stderr] 104 | self.top(), [INFO] [stderr] 105 | self.right(), [INFO] [stderr] 106 | self.bottom(), [INFO] [stderr] 107 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/pong/game.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pong/game.rs:68:36 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong/game.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | let x = (window_size[0] / 2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size[0] / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong/game.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let y = (window_size[1] / 2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size[1] / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/pong/game.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pong/game.rs:68:36 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong/game.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | let x = (window_size[0] / 2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size[0] / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong/game.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let y = (window_size[1] / 2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size[1] / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.17s [INFO] running `"docker" "inspect" "96cf3b4e2861ac714cc3d424b25cb7ff7dd84255b3066854d9314c48834307ee"` [INFO] running `"docker" "rm" "-f" "96cf3b4e2861ac714cc3d424b25cb7ff7dd84255b3066854d9314c48834307ee"` [INFO] [stdout] 96cf3b4e2861ac714cc3d424b25cb7ff7dd84255b3066854d9314c48834307ee