[INFO] updating cached repository hobofan/rsdocs-dashing [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hobofan/rsdocs-dashing [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hobofan/rsdocs-dashing" "work/ex/clippy-test-run/sources/stable/gh/hobofan/rsdocs-dashing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hobofan/rsdocs-dashing'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hobofan/rsdocs-dashing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hobofan/rsdocs-dashing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hobofan/rsdocs-dashing'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23a4b6af88f42f8355585102be9ce4d73a013655 [INFO] sha for GitHub repo hobofan/rsdocs-dashing: 23a4b6af88f42f8355585102be9ce4d73a013655 [INFO] validating manifest of hobofan/rsdocs-dashing on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hobofan/rsdocs-dashing on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hobofan/rsdocs-dashing [INFO] finished frobbing hobofan/rsdocs-dashing [INFO] frobbed toml for hobofan/rsdocs-dashing written to work/ex/clippy-test-run/sources/stable/gh/hobofan/rsdocs-dashing/Cargo.toml [INFO] started frobbing hobofan/rsdocs-dashing [INFO] finished frobbing hobofan/rsdocs-dashing [INFO] frobbed toml for hobofan/rsdocs-dashing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hobofan/rsdocs-dashing/Cargo.toml [INFO] crate hobofan/rsdocs-dashing has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hobofan/rsdocs-dashing against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hobofan/rsdocs-dashing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44f4e616d1cfe7bb5c27a994f2da694dfbf404db176c323fe30822e94dfcd399 [INFO] running `"docker" "start" "-a" "44f4e616d1cfe7bb5c27a994f2da694dfbf404db176c323fe30822e94dfcd399"` [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking rsdocs-dashing v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let filename = path.file_name().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 61 | let filename = &(*path.file_name().unwrap()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 61 | let filename = &std::ffi::OsStr::clone(path.file_name().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | file.write_all(r#" [INFO] [stderr] | ____________________^ [INFO] [stderr] 70 | | .sidebar, .sub, .srclink { [INFO] [stderr] 71 | | display: none; [INFO] [stderr] 72 | | } [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 69 | file.write_all(br#" [INFO] [stderr] 70 | .sidebar, .sub, .srclink { [INFO] [stderr] 71 | display: none; [INFO] [stderr] 72 | } [INFO] [stderr] 73 | [INFO] [stderr] 74 | .content { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsdocs-dashing`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | let filename = path.file_name().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 61 | let filename = &(*path.file_name().unwrap()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 61 | let filename = &std::ffi::OsStr::clone(path.file_name().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | file.write_all(r#" [INFO] [stderr] | ____________________^ [INFO] [stderr] 70 | | .sidebar, .sub, .srclink { [INFO] [stderr] 71 | | display: none; [INFO] [stderr] 72 | | } [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | "#.as_bytes()).unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 69 | file.write_all(br#" [INFO] [stderr] 70 | .sidebar, .sub, .srclink { [INFO] [stderr] 71 | display: none; [INFO] [stderr] 72 | } [INFO] [stderr] 73 | [INFO] [stderr] 74 | .content { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsdocs-dashing`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "44f4e616d1cfe7bb5c27a994f2da694dfbf404db176c323fe30822e94dfcd399"` [INFO] running `"docker" "rm" "-f" "44f4e616d1cfe7bb5c27a994f2da694dfbf404db176c323fe30822e94dfcd399"` [INFO] [stdout] 44f4e616d1cfe7bb5c27a994f2da694dfbf404db176c323fe30822e94dfcd399