[INFO] updating cached repository hkmix/rust-term-colourizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hkmix/rust-term-colourizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hkmix/rust-term-colourizer" "work/ex/clippy-test-run/sources/stable/gh/hkmix/rust-term-colourizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hkmix/rust-term-colourizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hkmix/rust-term-colourizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hkmix/rust-term-colourizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hkmix/rust-term-colourizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31b4cfd6991060e2758c903b3942fe6306c124f1 [INFO] sha for GitHub repo hkmix/rust-term-colourizer: 31b4cfd6991060e2758c903b3942fe6306c124f1 [INFO] validating manifest of hkmix/rust-term-colourizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hkmix/rust-term-colourizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hkmix/rust-term-colourizer [INFO] finished frobbing hkmix/rust-term-colourizer [INFO] frobbed toml for hkmix/rust-term-colourizer written to work/ex/clippy-test-run/sources/stable/gh/hkmix/rust-term-colourizer/Cargo.toml [INFO] started frobbing hkmix/rust-term-colourizer [INFO] finished frobbing hkmix/rust-term-colourizer [INFO] frobbed toml for hkmix/rust-term-colourizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hkmix/rust-term-colourizer/Cargo.toml [INFO] crate hkmix/rust-term-colourizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hkmix/rust-term-colourizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hkmix/rust-term-colourizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 58e52b36298bff08ba144c240d5f1fde8923d2e0ac09725b394c59eba82ab331 [INFO] running `"docker" "start" "-a" "58e52b36298bff08ba144c240d5f1fde8923d2e0ac09725b394c59eba82ab331"` [INFO] [stderr] Checking rust-term-colourizer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | / match r_data[idx] { [INFO] [stderr] 52 | | RegexData::RegExp(ref rexp) => { [INFO] [stderr] 53 | | // Matched RegExp [INFO] [stderr] 54 | | captures = rexp.captures(&text); [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let RegexData::RegExp(ref rexp) = r_data[idx] { [INFO] [stderr] 52 | // Matched RegExp [INFO] [stderr] 53 | captures = rexp.captures(&text); [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | fn read_file(filename: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if line_text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line_text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | / match r_data[idx] { [INFO] [stderr] 52 | | RegexData::RegExp(ref rexp) => { [INFO] [stderr] 53 | | // Matched RegExp [INFO] [stderr] 54 | | captures = rexp.captures(&text); [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let RegexData::RegExp(ref rexp) = r_data[idx] { [INFO] [stderr] 52 | // Matched RegExp [INFO] [stderr] 53 | captures = rexp.captures(&text); [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | fn read_file(filename: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if line_text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line_text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "58e52b36298bff08ba144c240d5f1fde8923d2e0ac09725b394c59eba82ab331"` [INFO] running `"docker" "rm" "-f" "58e52b36298bff08ba144c240d5f1fde8923d2e0ac09725b394c59eba82ab331"` [INFO] [stdout] 58e52b36298bff08ba144c240d5f1fde8923d2e0ac09725b394c59eba82ab331