[INFO] updating cached repository hjr3/softnet-stat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hjr3/softnet-stat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hjr3/softnet-stat" "work/ex/clippy-test-run/sources/stable/gh/hjr3/softnet-stat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hjr3/softnet-stat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hjr3/softnet-stat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/softnet-stat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/softnet-stat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c28fc949b87ffa1e07822f2b31ecd276a014355 [INFO] sha for GitHub repo hjr3/softnet-stat: 9c28fc949b87ffa1e07822f2b31ecd276a014355 [INFO] validating manifest of hjr3/softnet-stat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hjr3/softnet-stat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hjr3/softnet-stat [INFO] finished frobbing hjr3/softnet-stat [INFO] frobbed toml for hjr3/softnet-stat written to work/ex/clippy-test-run/sources/stable/gh/hjr3/softnet-stat/Cargo.toml [INFO] started frobbing hjr3/softnet-stat [INFO] finished frobbing hjr3/softnet-stat [INFO] frobbed toml for hjr3/softnet-stat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/softnet-stat/Cargo.toml [INFO] crate hjr3/softnet-stat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hjr3/softnet-stat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hjr3/softnet-stat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f9eb42c15296f22b344f17de1a9ba4be6f98581f5d3f7d8b5c666f93ad9269f [INFO] running `"docker" "start" "-a" "1f9eb42c15296f22b344f17de1a9ba4be6f98581f5d3f7d8b5c666f93ad9269f"` [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking nom v4.0.0-beta2 [INFO] [stderr] Checking softnet-stat v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | processed: 1842008611, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_842_008_611` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / fn parse_softnet_line(input: &[u8]) -> IResult<&[u8], SoftnetStat> { [INFO] [stderr] 73 | | [INFO] [stderr] 74 | | // do_parse! returns Err::Incomplete on zero length input, which causes problems with other [INFO] [stderr] 75 | | // sequence combinators. Return an end of file error instead. [INFO] [stderr] ... | [INFO] [stderr] 125 | | ) [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if input.as_bytes().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.as_bytes().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | fn print(stats: &Vec, spacer: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | fn json(stats: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | fn prometheus(stats: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / fn parse_softnet_line(input: &[u8]) -> IResult<&[u8], SoftnetStat> { [INFO] [stderr] 73 | | [INFO] [stderr] 74 | | // do_parse! returns Err::Incomplete on zero length input, which causes problems with other [INFO] [stderr] 75 | | // sequence combinators. Return an end of file error instead. [INFO] [stderr] ... | [INFO] [stderr] 125 | | ) [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | if input.as_bytes().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.as_bytes().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | fn print(stats: &Vec, spacer: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | fn json(stats: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | fn prometheus(stats: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[SoftnetStat]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.89s [INFO] running `"docker" "inspect" "1f9eb42c15296f22b344f17de1a9ba4be6f98581f5d3f7d8b5c666f93ad9269f"` [INFO] running `"docker" "rm" "-f" "1f9eb42c15296f22b344f17de1a9ba4be6f98581f5d3f7d8b5c666f93ad9269f"` [INFO] [stdout] 1f9eb42c15296f22b344f17de1a9ba4be6f98581f5d3f7d8b5c666f93ad9269f