[INFO] updating cached repository hjr3/building-better-interfaces [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hjr3/building-better-interfaces [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hjr3/building-better-interfaces" "work/ex/clippy-test-run/sources/stable/gh/hjr3/building-better-interfaces"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hjr3/building-better-interfaces'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hjr3/building-better-interfaces" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/building-better-interfaces"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/building-better-interfaces'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d30913d5f3230f435fed75e13571d4164d6b5d3 [INFO] sha for GitHub repo hjr3/building-better-interfaces: 4d30913d5f3230f435fed75e13571d4164d6b5d3 [INFO] validating manifest of hjr3/building-better-interfaces on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hjr3/building-better-interfaces on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hjr3/building-better-interfaces [INFO] finished frobbing hjr3/building-better-interfaces [INFO] frobbed toml for hjr3/building-better-interfaces written to work/ex/clippy-test-run/sources/stable/gh/hjr3/building-better-interfaces/Cargo.toml [INFO] started frobbing hjr3/building-better-interfaces [INFO] finished frobbing hjr3/building-better-interfaces [INFO] frobbed toml for hjr3/building-better-interfaces written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjr3/building-better-interfaces/Cargo.toml [INFO] crate hjr3/building-better-interfaces has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hjr3/building-better-interfaces against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hjr3/building-better-interfaces:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc9880fe442c06e47589556abcf7b31355c3c2db9fb03d8071e1970d10174d7b [INFO] running `"docker" "start" "-a" "cc9880fe442c06e47589556abcf7b31355c3c2db9fb03d8071e1970d10174d7b"` [INFO] [stderr] Checking building-better-interfaces v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | given: given, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `given` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classroom.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | seats: seats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `seats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/student.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:231:21 [INFO] [stderr] | [INFO] [stderr] 231 | given: given, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `given` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classroom.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | seats: seats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `seats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/student.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seat: seat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `name::NameString` [INFO] [stderr] --> src/name.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> NameString { [INFO] [stderr] 13 | | NameString { [INFO] [stderr] 14 | | inner: String::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/name.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn from_str(s: &str) -> NameString { [INFO] [stderr] 19 | | NameString { [INFO] [stderr] 20 | | inner: s.to_string() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | unsafe { mem::transmute(& *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(& *self.inner as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { mem::transmute(&mut *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut *self.inner as *mut str as *mut name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | unsafe { mem::transmute(& *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(& *self.inner as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | unsafe { mem::transmute(&mut *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut *self.inner as *mut str as *mut name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | unsafe { mem::transmute(name) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(name as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `roster::Roster<'a>` [INFO] [stderr] --> src/roster.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Roster<'a> { [INFO] [stderr] 11 | | Roster { [INFO] [stderr] 12 | | names: Vec::new(), [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `classroom::Classroom` [INFO] [stderr] --> src/classroom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Classroom { [INFO] [stderr] 10 | | Classroom::with_seats(32) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `courses::Courses` [INFO] [stderr] --> src/courses.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Courses { [INFO] [stderr] 7 | | Courses { [INFO] [stderr] 8 | | inner: Vec::new(), [INFO] [stderr] 9 | | } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `name::NameString` [INFO] [stderr] --> src/name.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> NameString { [INFO] [stderr] 13 | | NameString { [INFO] [stderr] 14 | | inner: String::new() [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/name.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn from_str(s: &str) -> NameString { [INFO] [stderr] 19 | | NameString { [INFO] [stderr] 20 | | inner: s.to_string() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | unsafe { mem::transmute(& *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(& *self.inner as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { mem::transmute(&mut *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut *self.inner as *mut str as *mut name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | unsafe { mem::transmute(& *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(& *self.inner as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | unsafe { mem::transmute(&mut *self.inner) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut *self.inner as *mut str as *mut name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/name.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | unsafe { mem::transmute(name) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(name as *const str as *const name::NameStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/name.rs:351:30 [INFO] [stderr] | [INFO] [stderr] 351 | assert_eq!(expected, expected.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/name.rs:358:39 [INFO] [stderr] | [INFO] [stderr] 358 | let _expected: &mut NameStr = name_ref.as_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `name_ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/name.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | / fn my_cow<'a>(n: Cow<'a, NameStr>) -> Cow<'a, NameStr> { [INFO] [stderr] 463 | | n [INFO] [stderr] 464 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `roster::Roster<'a>` [INFO] [stderr] --> src/roster.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Roster<'a> { [INFO] [stderr] 11 | | Roster { [INFO] [stderr] 12 | | names: Vec::new(), [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `classroom::Classroom` [INFO] [stderr] --> src/classroom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Classroom { [INFO] [stderr] 10 | | Classroom::with_seats(32) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `courses::Courses` [INFO] [stderr] --> src/courses.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Courses { [INFO] [stderr] 7 | | Courses { [INFO] [stderr] 8 | | inner: Vec::new(), [INFO] [stderr] 9 | | } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "cc9880fe442c06e47589556abcf7b31355c3c2db9fb03d8071e1970d10174d7b"` [INFO] running `"docker" "rm" "-f" "cc9880fe442c06e47589556abcf7b31355c3c2db9fb03d8071e1970d10174d7b"` [INFO] [stdout] cc9880fe442c06e47589556abcf7b31355c3c2db9fb03d8071e1970d10174d7b