[INFO] updating cached repository hjarrell/MuddyRustyAndSwampy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hjarrell/MuddyRustyAndSwampy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hjarrell/MuddyRustyAndSwampy" "work/ex/clippy-test-run/sources/stable/gh/hjarrell/MuddyRustyAndSwampy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hjarrell/MuddyRustyAndSwampy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hjarrell/MuddyRustyAndSwampy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjarrell/MuddyRustyAndSwampy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjarrell/MuddyRustyAndSwampy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bb807816c08921336362c8e4cb3d06eee6e5e4d2 [INFO] sha for GitHub repo hjarrell/MuddyRustyAndSwampy: bb807816c08921336362c8e4cb3d06eee6e5e4d2 [INFO] validating manifest of hjarrell/MuddyRustyAndSwampy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hjarrell/MuddyRustyAndSwampy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hjarrell/MuddyRustyAndSwampy [INFO] finished frobbing hjarrell/MuddyRustyAndSwampy [INFO] frobbed toml for hjarrell/MuddyRustyAndSwampy written to work/ex/clippy-test-run/sources/stable/gh/hjarrell/MuddyRustyAndSwampy/Cargo.toml [INFO] started frobbing hjarrell/MuddyRustyAndSwampy [INFO] finished frobbing hjarrell/MuddyRustyAndSwampy [INFO] frobbed toml for hjarrell/MuddyRustyAndSwampy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hjarrell/MuddyRustyAndSwampy/Cargo.toml [INFO] crate hjarrell/MuddyRustyAndSwampy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hjarrell/MuddyRustyAndSwampy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hjarrell/MuddyRustyAndSwampy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8396d4bbd5b29d0737f9a2d041a56dc38720f1a126990ea18bc439828c4b4e5c [INFO] running `"docker" "start" "-a" "8396d4bbd5b29d0737f9a2d041a56dc38720f1a126990ea18bc439828c4b4e5c"` [INFO] [stderr] Checking muddy_rusty_and_swampy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | ReadStateNormal, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | ReadStateCommand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | ReadStateSubNeg, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `ReadState` [INFO] [stderr] --> src/server.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / enum ReadState { [INFO] [stderr] 16 | | ReadStateNormal, [INFO] [stderr] 17 | | ReadStateCommand, [INFO] [stderr] 18 | | ReadStateSubNeg, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Tn` [INFO] [stderr] --> src/server.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum TelnetCommandCode { [INFO] [stderr] 23 | | TnInterpretAsCommand = 255, [INFO] [stderr] 24 | | TnAreYouThere = 246, [INFO] [stderr] 25 | | TnWill = 251, [INFO] [stderr] ... | [INFO] [stderr] 30 | | TnSubnegotiationEnd = 240, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return mudd_server; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mudd_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | ReadStateNormal, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | ReadStateCommand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name starts with the enum's name [INFO] [stderr] --> src/server.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | ReadStateSubNeg, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `ReadState` [INFO] [stderr] --> src/server.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / enum ReadState { [INFO] [stderr] 16 | | ReadStateNormal, [INFO] [stderr] 17 | | ReadStateCommand, [INFO] [stderr] 18 | | ReadStateSubNeg, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Tn` [INFO] [stderr] --> src/server.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum TelnetCommandCode { [INFO] [stderr] 23 | | TnInterpretAsCommand = 255, [INFO] [stderr] 24 | | TnAreYouThere = 246, [INFO] [stderr] 25 | | TnWill = 251, [INFO] [stderr] ... | [INFO] [stderr] 30 | | TnSubnegotiationEnd = 240, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return mudd_server; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mudd_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TnAreYouThere` [INFO] [stderr] --> src/server.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | TnAreYouThere = 246, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/server.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | id: u32, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `addr` [INFO] [stderr] --> src/server.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | addr: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TnAreYouThere` [INFO] [stderr] --> src/server.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | TnAreYouThere = 246, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/server.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | id: u32, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `addr` [INFO] [stderr] --> src/server.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | addr: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn get_room_from_exit(rooms: &Vec, exit_name: String) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn has_exit_with_name(&self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/game.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / .collect::>() [INFO] [stderr] 84 | | .contains(name) [INFO] [stderr] | |___________________________^ help: replace with: `.any(|&x| x == name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:136:31 [INFO] [stderr] | [INFO] [stderr] 136 | self.attempt_send(to, String::from(message + "\n\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `message + "\n\r"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn get_room_from_exit(rooms: &Vec, exit_name: String) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/server.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | .duration_since(self.clients.get(&id).unwrap().last_check) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.clients[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | &self.attempt_send(id, String::from("\x00")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.attempt_send(id, String::from("\x00"));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | &self.set_client_last_check(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.set_client_last_check(id);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/game.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn has_exit_with_name(&self, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/game.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / .collect::>() [INFO] [stderr] 84 | | .contains(name) [INFO] [stderr] | |___________________________^ help: replace with: `.any(|&x| x == name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server.rs:136:31 [INFO] [stderr] | [INFO] [stderr] 136 | self.attempt_send(to, String::from(message + "\n\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `message + "\n\r"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/server.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | .duration_since(self.clients.get(&id).unwrap().last_check) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.clients[&id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | &self.attempt_send(id, String::from("\x00")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.attempt_send(id, String::from("\x00"));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/server.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | &self.set_client_last_check(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.set_client_last_check(id);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | while serv.server_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!serv.server_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:43 [INFO] [stderr] | [INFO] [stderr] 71 | if player.name == String::from("\n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | while serv.server_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!serv.server_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | if split_command.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:71:43 [INFO] [stderr] | [INFO] [stderr] 71 | if player.name == String::from("\n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | if split_command.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | / match room_change { [INFO] [stderr] 186 | | Some(room) => { [INFO] [stderr] 187 | | player.room = room; [INFO] [stderr] 188 | | serv.send_message(id, format!("You arrive at '{}'", player.room.name)); [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | _ => {} [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | if let Some(room) = room_change { [INFO] [stderr] 186 | player.room = room; [INFO] [stderr] 187 | serv.send_message(id, format!("You arrive at '{}'", player.room.name)); [INFO] [stderr] 188 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | / match players.remove(&id) { [INFO] [stderr] 196 | | Some(player) => { [INFO] [stderr] 197 | | serv.send_all(format!("{} quit the game", player.name)); [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | None => {} [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 195 | if let Some(player) = players.remove(&id) { [INFO] [stderr] 196 | serv.send_all(format!("{} quit the game", player.name)); [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | / match room_change { [INFO] [stderr] 186 | | Some(room) => { [INFO] [stderr] 187 | | player.room = room; [INFO] [stderr] 188 | | serv.send_message(id, format!("You arrive at '{}'", player.room.name)); [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | _ => {} [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | if let Some(room) = room_change { [INFO] [stderr] 186 | player.room = room; [INFO] [stderr] 187 | serv.send_message(id, format!("You arrive at '{}'", player.room.name)); [INFO] [stderr] 188 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | / match players.remove(&id) { [INFO] [stderr] 196 | | Some(player) => { [INFO] [stderr] 197 | | serv.send_all(format!("{} quit the game", player.name)); [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | None => {} [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 195 | if let Some(player) = players.remove(&id) { [INFO] [stderr] 196 | serv.send_all(format!("{} quit the game", player.name)); [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "8396d4bbd5b29d0737f9a2d041a56dc38720f1a126990ea18bc439828c4b4e5c"` [INFO] running `"docker" "rm" "-f" "8396d4bbd5b29d0737f9a2d041a56dc38720f1a126990ea18bc439828c4b4e5c"` [INFO] [stdout] 8396d4bbd5b29d0737f9a2d041a56dc38720f1a126990ea18bc439828c4b4e5c