[INFO] updating cached repository hinohi/rust-mancala [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hinohi/rust-mancala [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hinohi/rust-mancala" "work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-mancala"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-mancala'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hinohi/rust-mancala" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-mancala"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-mancala'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d70472b60031a4d3e10f2fcf5458806585b40bb [INFO] sha for GitHub repo hinohi/rust-mancala: 3d70472b60031a4d3e10f2fcf5458806585b40bb [INFO] validating manifest of hinohi/rust-mancala on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hinohi/rust-mancala on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hinohi/rust-mancala [INFO] finished frobbing hinohi/rust-mancala [INFO] frobbed toml for hinohi/rust-mancala written to work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-mancala/Cargo.toml [INFO] started frobbing hinohi/rust-mancala [INFO] finished frobbing hinohi/rust-mancala [INFO] frobbed toml for hinohi/rust-mancala written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-mancala/Cargo.toml [INFO] crate hinohi/rust-mancala has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hinohi/rust-mancala against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-mancala:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49cf7c323c2ccf4af21dd8e3fe397ff638c0d60798edbfa07f2df2dbd791b24c [INFO] running `"docker" "start" "-a" "49cf7c323c2ccf4af21dd8e3fe397ff638c0d60798edbfa07f2df2dbd791b24c"` [INFO] [stderr] Compiling syn v0.15.7 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking mancala-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ai/simple.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ai/simple.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ai/simple.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ai/simple.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ai/depth_search.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 28 | | if state == GameState::InBattle { [INFO] [stderr] 29 | | sb as i32 - sa as i32 [INFO] [stderr] 30 | | } else if state == GameState::WinA { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if state == GameState::InBattle { [INFO] [stderr] 28 | sb as i32 - sa as i32 [INFO] [stderr] 29 | } else if state == GameState::WinA { [INFO] [stderr] 30 | -100 + sb as i32 - sa as i32 [INFO] [stderr] 31 | } else if state == GameState::WinB { [INFO] [stderr] 32 | 100 + sb as i32 - sa as i32 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ai/depth_search.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 28 | | if state == GameState::InBattle { [INFO] [stderr] 29 | | sb as i32 - sa as i32 [INFO] [stderr] 30 | | } else if state == GameState::WinA { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if state == GameState::InBattle { [INFO] [stderr] 28 | sb as i32 - sa as i32 [INFO] [stderr] 29 | } else if state == GameState::WinA { [INFO] [stderr] 30 | -100 + sb as i32 - sa as i32 [INFO] [stderr] 31 | } else if state == GameState::WinB { [INFO] [stderr] 32 | 100 + sb as i32 - sa as i32 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ai/base.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / let pos_list; [INFO] [stderr] 26 | | if self.board.side == 0 { [INFO] [stderr] 27 | | pos_list = self.ai_a.think(&self.board); [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | pos_list = self.ai_b.think(&self.board); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let pos_list = if self.board.side == 0 { self.ai_a.think(&self.board) } else { self.ai_b.think(&self.board) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | 100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | 100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | -100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | -100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | -100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:31:36 [INFO] [stderr] | [INFO] [stderr] 31 | -100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | 100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | 100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/ai/simple.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | writeln!(stderr(), "====\n{}", board).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | write!(stderr(), "your turn: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Board` [INFO] [stderr] --> src/game.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Board { [INFO] [stderr] 62 | | Board { [INFO] [stderr] 63 | | side: 0, [INFO] [stderr] 64 | | pits: [[STONE; PIT]; 2], [INFO] [stderr] 65 | | score: [0, 0], [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ret` [INFO] [stderr] --> src/game.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (i, ) in ret.iter_mut().enumerate().take(PIT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `ret[..PIT].clone_from_slice(&self.pits[self.side as usize][..PIT])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `ret[PIT..(PIT + PIT)].clone_from_slice(&self.pits[1 - self.side as usize][..PIT])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ai/base.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / let pos_list; [INFO] [stderr] 26 | | if self.board.side == 0 { [INFO] [stderr] 27 | | pos_list = self.ai_a.think(&self.board); [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | pos_list = self.ai_b.think(&self.board); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let pos_list = if self.board.side == 0 { self.ai_a.think(&self.board) } else { self.ai_b.think(&self.board) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | 100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | 100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | -100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | -100 + sa as i32 - sb as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | -100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:31:36 [INFO] [stderr] | [INFO] [stderr] 31 | -100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | 100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/depth_search.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | 100 + sb as i32 - sa as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(sa)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ai/mem.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/ai/simple.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | writeln!(stderr(), "====\n{}", board).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | write!(stderr(), "your turn: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/ai/simple.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Err(e) => write!(stderr(), "{}\n", e).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `game::Board` [INFO] [stderr] --> src/game.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Board { [INFO] [stderr] 62 | | Board { [INFO] [stderr] 63 | | side: 0, [INFO] [stderr] 64 | | pits: [[STONE; PIT]; 2], [INFO] [stderr] 65 | | score: [0, 0], [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ret` [INFO] [stderr] --> src/game.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (i, ) in ret.iter_mut().enumerate().take(PIT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `ret[..PIT].clone_from_slice(&self.pits[self.side as usize][..PIT])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/game.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..PIT { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `ret[PIT..(PIT + PIT)].clone_from_slice(&self.pits[1 - self.side as usize][..PIT])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | if !board.check_pos(pos).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.check_pos(pos).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | s1 as i32 - s2 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/learn.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | s2 as i32 - s1 as i32 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(s1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.21s [INFO] running `"docker" "inspect" "49cf7c323c2ccf4af21dd8e3fe397ff638c0d60798edbfa07f2df2dbd791b24c"` [INFO] running `"docker" "rm" "-f" "49cf7c323c2ccf4af21dd8e3fe397ff638c0d60798edbfa07f2df2dbd791b24c"` [INFO] [stdout] 49cf7c323c2ccf4af21dd8e3fe397ff638c0d60798edbfa07f2df2dbd791b24c