[INFO] updating cached repository hinohi/rust-bfi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hinohi/rust-bfi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hinohi/rust-bfi" "work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-bfi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-bfi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hinohi/rust-bfi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-bfi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-bfi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 175b263486aee63733ca96d86e9a592b817cf979 [INFO] sha for GitHub repo hinohi/rust-bfi: 175b263486aee63733ca96d86e9a592b817cf979 [INFO] validating manifest of hinohi/rust-bfi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hinohi/rust-bfi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hinohi/rust-bfi [INFO] finished frobbing hinohi/rust-bfi [INFO] frobbed toml for hinohi/rust-bfi written to work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-bfi/Cargo.toml [INFO] started frobbing hinohi/rust-bfi [INFO] finished frobbing hinohi/rust-bfi [INFO] frobbed toml for hinohi/rust-bfi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hinohi/rust-bfi/Cargo.toml [INFO] crate hinohi/rust-bfi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hinohi/rust-bfi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hinohi/rust-bfi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dccb44ed94b4de1b06d8e100b3ed08780675d1f683102fda128de37cd066bdc7 [INFO] running `"docker" "start" "-a" "dccb44ed94b4de1b06d8e100b3ed08780675d1f683102fda128de37cd066bdc7"` [INFO] [stderr] Checking rust-bfi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | let dst = src.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:246:28 [INFO] [stderr] | [INFO] [stderr] 246 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 247 | | self.point = self.point.wrapping_add(*i as usize); [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:244:31 [INFO] [stderr] | [INFO] [stderr] 244 | if *i > 0 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 245 | | self.point = self.point.wrapping_add(*i as usize); [INFO] [stderr] 246 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / let pos; [INFO] [stderr] 260 | | if *d > 0 { [INFO] [stderr] 261 | | pos = self.point + (*d as usize); [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | assert!(self.point >= ((-d) as usize)); [INFO] [stderr] 264 | | pos = self.point - ((-d) as usize); [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let pos = if *d > 0 { self.point + (*d as usize) } else { ..; self.point - ((-d) as usize) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:267:45 [INFO] [stderr] | [INFO] [stderr] 267 | let b = a.wrapping_add((self.mem[self.point] as i32 * mul) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.mem[self.point])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / match reader.read_to_string(&mut buf) { [INFO] [stderr] 283 | | Err(e) => return Err(e.to_string()), [INFO] [stderr] 284 | | Ok(_) => (), [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = reader.read_to_string(&mut buf) { return Err(e.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / match run(args) { [INFO] [stderr] 331 | | Err(e) => { [INFO] [stderr] 332 | | println!("{:?}", e); [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | _ => (), [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 330 | if let Err(e) = run(args) { [INFO] [stderr] 331 | println!("{:?}", e); [INFO] [stderr] 332 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-bfi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | let dst = src.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:246:28 [INFO] [stderr] | [INFO] [stderr] 246 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 247 | | self.point = self.point.wrapping_add(*i as usize); [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:244:31 [INFO] [stderr] | [INFO] [stderr] 244 | if *i > 0 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 245 | | self.point = self.point.wrapping_add(*i as usize); [INFO] [stderr] 246 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / let pos; [INFO] [stderr] 260 | | if *d > 0 { [INFO] [stderr] 261 | | pos = self.point + (*d as usize); [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | assert!(self.point >= ((-d) as usize)); [INFO] [stderr] 264 | | pos = self.point - ((-d) as usize); [INFO] [stderr] 265 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let pos = if *d > 0 { self.point + (*d as usize) } else { ..; self.point - ((-d) as usize) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:267:45 [INFO] [stderr] | [INFO] [stderr] 267 | let b = a.wrapping_add((self.mem[self.point] as i32 * mul) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.mem[self.point])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / match reader.read_to_string(&mut buf) { [INFO] [stderr] 283 | | Err(e) => return Err(e.to_string()), [INFO] [stderr] 284 | | Ok(_) => (), [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = reader.read_to_string(&mut buf) { return Err(e.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / match run(args) { [INFO] [stderr] 331 | | Err(e) => { [INFO] [stderr] 332 | | println!("{:?}", e); [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | _ => (), [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 330 | if let Err(e) = run(args) { [INFO] [stderr] 331 | println!("{:?}", e); [INFO] [stderr] 332 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-bfi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dccb44ed94b4de1b06d8e100b3ed08780675d1f683102fda128de37cd066bdc7"` [INFO] running `"docker" "rm" "-f" "dccb44ed94b4de1b06d8e100b3ed08780675d1f683102fda128de37cd066bdc7"` [INFO] [stdout] dccb44ed94b4de1b06d8e100b3ed08780675d1f683102fda128de37cd066bdc7