[INFO] updating cached repository hhatto/wwup-in-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/hhatto/wwup-in-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/hhatto/wwup-in-rust" "work/ex/clippy-test-run/sources/stable/gh/hhatto/wwup-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hhatto/wwup-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/hhatto/wwup-in-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/wwup-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/wwup-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ef78053e5a0447048fafc7824dd7adb64c60c12 [INFO] sha for GitHub repo hhatto/wwup-in-rust: 7ef78053e5a0447048fafc7824dd7adb64c60c12 [INFO] validating manifest of hhatto/wwup-in-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hhatto/wwup-in-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hhatto/wwup-in-rust [INFO] finished frobbing hhatto/wwup-in-rust [INFO] frobbed toml for hhatto/wwup-in-rust written to work/ex/clippy-test-run/sources/stable/gh/hhatto/wwup-in-rust/Cargo.toml [INFO] started frobbing hhatto/wwup-in-rust [INFO] finished frobbing hhatto/wwup-in-rust [INFO] frobbed toml for hhatto/wwup-in-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/wwup-in-rust/Cargo.toml [INFO] crate hhatto/wwup-in-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hhatto/wwup-in-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hhatto/wwup-in-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03bbe724a28e23c9b4d3415e1c2bf0d54e61fb42f442100078aedc32f938fc31 [INFO] running `"docker" "start" "-a" "03bbe724a28e23c9b4d3415e1c2bf0d54e61fb42f442100078aedc32f938fc31"` [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking chan-signal v0.2.0 [INFO] [stderr] Checking nix v0.7.0 [INFO] [stderr] Checking prctl v1.0.0 [INFO] [stderr] Checking wwup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/6_processes_have_resource_limits.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | rlimit.rlim_cur = rlimit.rlim_cur * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rlimit.rlim_cur *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::setrlimit` doesn't need a mutable reference [INFO] [stderr] --> src/6_processes_have_resource_limits.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | libc::setrlimit(libc::RLIMIT_NOFILE, &mut rlimit); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::setrlimit` doesn't need a mutable reference [INFO] [stderr] --> src/6_processes_have_resource_limits.rs:34:46 [INFO] [stderr] | [INFO] [stderr] 34 | libc::setrlimit(libc::RLIMIT_NOFILE, &mut rlimit); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/19_spawning_terminal_processes.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let file = libc::popen(CString::new("less").unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/19_spawning_terminal_processes.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let file = libc::popen(CString::new("less").unwrap().as_ptr(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/19_spawning_terminal_processes.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | CString::new("w").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/19_spawning_terminal_processes.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | CString::new("w").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wwup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/17_processes_can_communicate.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if len <= 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using len == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/17_processes_can_communicate.rs:94:12 [INFO] [stderr] | [INFO] [stderr] 94 | if len <= 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using len == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wwup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/7_processes_have_an_environment.rs:8:40 [INFO] [stderr] | [INFO] [stderr] 8 | println!("{}", env::var("MESSAGE").unwrap_or("envvar not found".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "envvar not found".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `child` [INFO] [stderr] --> src/12_orphaned_processes.rs:11:38 [INFO] [stderr] | [INFO] [stderr] 11 | unistd::ForkResult::Parent { child } => { [INFO] [stderr] | ^^^^^ help: try ignoring the field: `child: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "03bbe724a28e23c9b4d3415e1c2bf0d54e61fb42f442100078aedc32f938fc31"` [INFO] running `"docker" "rm" "-f" "03bbe724a28e23c9b4d3415e1c2bf0d54e61fb42f442100078aedc32f938fc31"` [INFO] [stdout] 03bbe724a28e23c9b4d3415e1c2bf0d54e61fb42f442100078aedc32f938fc31