[INFO] updating cached repository hhatto/pgstatprof
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/hhatto/pgstatprof
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/hhatto/pgstatprof" "work/ex/clippy-test-run/sources/stable/gh/hhatto/pgstatprof"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/hhatto/pgstatprof'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/hhatto/pgstatprof" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/pgstatprof"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/pgstatprof'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2ad60d4760ad368e4bc6dc9083b98a9d923afaa0
[INFO] sha for GitHub repo hhatto/pgstatprof: 2ad60d4760ad368e4bc6dc9083b98a9d923afaa0
[INFO] validating manifest of hhatto/pgstatprof on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hhatto/pgstatprof on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hhatto/pgstatprof
[INFO] finished frobbing hhatto/pgstatprof
[INFO] frobbed toml for hhatto/pgstatprof written to work/ex/clippy-test-run/sources/stable/gh/hhatto/pgstatprof/Cargo.toml
[INFO] started frobbing hhatto/pgstatprof
[INFO] finished frobbing hhatto/pgstatprof
[INFO] frobbed toml for hhatto/pgstatprof written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/hhatto/pgstatprof/Cargo.toml
[INFO] crate hhatto/pgstatprof has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hhatto/pgstatprof against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/hhatto/pgstatprof:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b68dc5c206e3a746c76cd02bc3c0ac669f06bd5b41efe498a9f8d4fe3b1e92e1
[INFO] running `"docker" "start" "-a" "b68dc5c206e3a746c76cd02bc3c0ac669f06bd5b41efe498a9f8d4fe3b1e92e1"`
[INFO] [stderr]     Checking fallible-iterator v0.1.5
[INFO] [stderr]     Checking users v0.7.0
[INFO] [stderr]     Checking phf_shared v0.7.21
[INFO] [stderr]     Checking stringprep v0.1.2
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]     Checking phf v0.7.21
[INFO] [stderr]     Checking postgres-protocol v0.3.2
[INFO] [stderr]     Checking postgres-shared v0.4.1
[INFO] [stderr]     Checking postgres v0.15.2
[INFO] [stderr]     Checking pgstatprof v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             limit: limit,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `limit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |         NormalizePattern { re: re, subs: subs }
[INFO] [stderr]     |                            ^^^^^^ help: replace it with: `re`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:36
[INFO] [stderr]     |
[INFO] [stderr] 142 |         NormalizePattern { re: re, subs: subs }
[INFO] [stderr]     |                                    ^^^^^^^^^^ help: replace it with: `subs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:198:13
[INFO] [stderr]     |
[INFO] [stderr] 198 |             state: state,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:199:13
[INFO] [stderr]     |
[INFO] [stderr] 199 |             info: info,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `info`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             limit: limit,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `limit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:28
[INFO] [stderr]     |
[INFO] [stderr] 142 |         NormalizePattern { re: re, subs: subs }
[INFO] [stderr]     |                            ^^^^^^ help: replace it with: `re`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:142:36
[INFO] [stderr]     |
[INFO] [stderr] 142 |         NormalizePattern { re: re, subs: subs }
[INFO] [stderr]     |                                    ^^^^^^^^^^ help: replace it with: `subs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:198:13
[INFO] [stderr]     |
[INFO] [stderr] 198 |             state: state,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:199:13
[INFO] [stderr]     |
[INFO] [stderr] 199 |             info: info,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `info`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:28
[INFO] [stderr]    |
[INFO] [stderr] 19 | const QUERY_SHOW_PROCESS: &'static str = "SELECT state,query FROM pg_stat_activity";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: digits grouped inconsistently by underscores
[INFO] [stderr]    --> src/main.rs:229:29
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 t.tm_nsec / 1000_000,
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::inconsistent_digit_grouping)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `cnt` is used as a loop counter. Consider using `for (cnt, item) in pp.enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 |     for (k, v) in pp {
[INFO] [stderr]    |                   ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:28
[INFO] [stderr]    |
[INFO] [stderr] 19 | const QUERY_SHOW_PROCESS: &'static str = "SELECT state,query FROM pg_stat_activity";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: digits grouped inconsistently by underscores
[INFO] [stderr]    --> src/main.rs:229:29
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 t.tm_nsec / 1000_000,
[INFO] [stderr]     |                             ^^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::inconsistent_digit_grouping)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:309:10
[INFO] [stderr]     |
[INFO] [stderr] 309 |         .expect(format!("fail get postgres connection: {}", conn_uri).as_str());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail get postgres connection: {}", conn_uri))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `cnt` is used as a loop counter. Consider using `for (cnt, item) in pp.enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 |     for (k, v) in pp {
[INFO] [stderr]    |                   ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:309:10
[INFO] [stderr]     |
[INFO] [stderr] 309 |         .expect(format!("fail get postgres connection: {}", conn_uri).as_str());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("fail get postgres connection: {}", conn_uri))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.85s
[INFO] running `"docker" "inspect" "b68dc5c206e3a746c76cd02bc3c0ac669f06bd5b41efe498a9f8d4fe3b1e92e1"`
[INFO] running `"docker" "rm" "-f" "b68dc5c206e3a746c76cd02bc3c0ac669f06bd5b41efe498a9f8d4fe3b1e92e1"`
[INFO] [stdout] b68dc5c206e3a746c76cd02bc3c0ac669f06bd5b41efe498a9f8d4fe3b1e92e1